* [PATCH -next] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop
@ 2024-08-22 6:25 Jinjie Ruan
2024-09-03 15:08 ` Daniel Thompson
2024-09-30 12:39 ` (subset) " Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Jinjie Ruan @ 2024-08-22 6:25 UTC (permalink / raw)
To: lee, daniel.thompson, jingoohan1, deller, dri-devel, linux-fbdev,
linux-kernel
Cc: ruanjinjie
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/video/backlight/88pm860x_bl.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/video/backlight/88pm860x_bl.c b/drivers/video/backlight/88pm860x_bl.c
index 25e409bbb1a2..720b5ada7fe8 100644
--- a/drivers/video/backlight/88pm860x_bl.c
+++ b/drivers/video/backlight/88pm860x_bl.c
@@ -151,7 +151,7 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,
struct pm860x_backlight_data *data,
char *name)
{
- struct device_node *nproot, *np;
+ struct device_node *nproot;
int iset = 0;
nproot = of_get_child_by_name(pdev->dev.parent->of_node, "backlights");
@@ -159,14 +159,13 @@ static int pm860x_backlight_dt_init(struct platform_device *pdev,
dev_err(&pdev->dev, "failed to find backlights node\n");
return -ENODEV;
}
- for_each_child_of_node(nproot, np) {
+ for_each_child_of_node_scoped(nproot, np) {
if (of_node_name_eq(np, name)) {
of_property_read_u32(np, "marvell,88pm860x-iset",
&iset);
data->iset = PM8606_WLED_CURRENT(iset);
of_property_read_u32(np, "marvell,88pm860x-pwm",
&data->pwm);
- of_node_put(np);
break;
}
}
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop
2024-08-22 6:25 [PATCH -next] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop Jinjie Ruan
@ 2024-09-03 15:08 ` Daniel Thompson
2024-09-30 12:39 ` (subset) " Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Thompson @ 2024-09-03 15:08 UTC (permalink / raw)
To: Jinjie Ruan; +Cc: lee, jingoohan1, deller, dri-devel, linux-fbdev, linux-kernel
On Thu, Aug 22, 2024 at 02:25:46PM +0800, Jinjie Ruan wrote:
> Use scoped for_each_child_of_node_scoped() when iterating over device
> nodes to make code a bit simpler.
>
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Daniel.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: (subset) [PATCH -next] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop
2024-08-22 6:25 [PATCH -next] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop Jinjie Ruan
2024-09-03 15:08 ` Daniel Thompson
@ 2024-09-30 12:39 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2024-09-30 12:39 UTC (permalink / raw)
To: lee, daniel.thompson, jingoohan1, deller, dri-devel, linux-fbdev,
linux-kernel, Jinjie Ruan
On Thu, 22 Aug 2024 14:25:46 +0800, Jinjie Ruan wrote:
> Use scoped for_each_child_of_node_scoped() when iterating over device
> nodes to make code a bit simpler.
>
>
Applied, thanks!
[1/1] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop
commit: 3db60398b4c10425dd32c076280af7f334431064
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-30 12:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-22 6:25 [PATCH -next] backlight: 88pm860x_bl: Simplify with scoped for each OF child loop Jinjie Ruan
2024-09-03 15:08 ` Daniel Thompson
2024-09-30 12:39 ` (subset) " Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).