linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
	deller@gmx.de, bonbons@linux-vserver.org, jikos@kernel.org,
	bentiss@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-omap@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Jiri Kosina <jkosina@suse.com>
Subject: [PATCH v2 25/28] HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev
Date: Fri,  6 Sep 2024 09:52:39 +0200	[thread overview]
Message-ID: <20240906075439.98476-26-tzimmermann@suse.de> (raw)
In-Reply-To: <20240906075439.98476-1-tzimmermann@suse.de>

Store the lcd device in struct fb_info.lcd_dev. The lcd subsystem can
now detect the lcd's fbdev device from this field.

This makes the implementation of check_fb in picolcd_lcdops obsolete.
Remove it.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
Acked-by: Jiri Kosina <jkosina@suse.com>
---
 drivers/hid/hid-picolcd_fb.c  | 4 ++++
 drivers/hid/hid-picolcd_lcd.c | 6 ------
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c
index 83e3409d170c..22188acfcbb0 100644
--- a/drivers/hid/hid-picolcd_fb.c
+++ b/drivers/hid/hid-picolcd_fb.c
@@ -497,6 +497,10 @@ int picolcd_init_framebuffer(struct picolcd_data *data)
 #endif
 #endif
 
+#ifdef CONFIG_HID_PICOLCD_LCD
+	info->lcd_dev = data->lcd;
+#endif
+
 	fbdata = info->par;
 	spin_lock_init(&fbdata->lock);
 	fbdata->picolcd = data;
diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
index 061a33ba7b1d..318f19eac0e7 100644
--- a/drivers/hid/hid-picolcd_lcd.c
+++ b/drivers/hid/hid-picolcd_lcd.c
@@ -41,15 +41,9 @@ static int picolcd_set_contrast(struct lcd_device *ldev, int contrast)
 	return 0;
 }
 
-static int picolcd_check_lcd_fb(struct lcd_device *ldev, struct fb_info *fb)
-{
-	return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev));
-}
-
 static const struct lcd_ops picolcd_lcdops = {
 	.get_contrast   = picolcd_get_contrast,
 	.set_contrast   = picolcd_set_contrast,
-	.check_fb       = picolcd_check_lcd_fb,
 };
 
 int picolcd_init_lcd(struct picolcd_data *data, struct hid_report *report)
-- 
2.46.0


  parent reply	other threads:[~2024-09-06  7:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06  7:52 [PATCH v2 00/28] backlight: lcd: Remove fbdev dependencies Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 01/28] backlight: lcd: Rearrange code in fb_notifier_callback() Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 02/28] backlight: lcd: Test against struct fb_info.lcd_dev Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 03/28] backlight: lcd: Add LCD_POWER_ constants for power states Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 04/28] backlight: corgi_lcd: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 05/28] backlight: hx8357: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 06/28] backlight: ili922x: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 07/28] backlight: ili9320: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 08/28] backlight: jornada720_lcd: Include <linux/io.h> for IOMEM() macro Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 09/28] backlight: jornada720_lcd: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 10/28] backlight: l4f00242t03: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 11/28] backlight: lms283gf05: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 12/28] backlight: lms501kf03: Remove unnecessary include of <linux/backlight.h> Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 13/28] backlight: lms501kf03: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 14/28] backlight: ltv350qv: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 15/28] backlight: otm3225a: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 16/28] backlight: platform_lcd: Remove include statement for <linux/backlight.h> Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 17/28] backlight: platform_lcd: Remove match_fb from struct plat_lcd_data Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 18/28] backlight: platform_lcd: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 19/28] backlight: tdo24m: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 20/28] fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-10-03 18:33   ` Kees Bakker
2024-10-04 14:01     ` Thomas Zimmermann
2024-11-23 20:11   ` Andy Shevchenko
2024-09-06  7:52 ` [PATCH v2 21/28] fbdev: clps711x-fb: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 22/28] fbdev: imxfb: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 23/28] fbdev: imxfb: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 24/28] fbdev: omap: " Thomas Zimmermann
2024-09-06  7:52 ` Thomas Zimmermann [this message]
2024-09-06  7:52 ` [PATCH v2 26/28] backlight: lcd: Replace check_fb with controls_device Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 27/28] backlight: lcd: Remove struct fb_videomode from set_mode callback Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 28/28] backlight: lcd: Do not include <linux/fb.h> in lcd header Thomas Zimmermann
2024-09-30 15:50 ` [PATCH v2 00/28] backlight: lcd: Remove fbdev dependencies Lee Jones
2024-10-01  8:55 ` [GIT PULL] Immutable branch between Backlight, HID and fbdev due for the v6.13 merge window Lee Jones
2024-10-21 15:51   ` Jiri Kosina
2024-10-25  8:59     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240906075439.98476-26-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=bentiss@kernel.org \
    --cc=bonbons@linux-vserver.org \
    --cc=daniel.thompson@linaro.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=jikos@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=jkosina@suse.com \
    --cc=kernel@pengutronix.de \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).