linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: lee@kernel.org, daniel.thompson@linaro.org, jingoohan1@gmail.com,
	deller@gmx.de, bonbons@linux-vserver.org, jikos@kernel.org,
	bentiss@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, shawnguo@kernel.org, festevam@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linux-omap@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 02/28] backlight: lcd: Test against struct fb_info.lcd_dev
Date: Fri,  6 Sep 2024 09:52:16 +0200	[thread overview]
Message-ID: <20240906075439.98476-3-tzimmermann@suse.de> (raw)
In-Reply-To: <20240906075439.98476-1-tzimmermann@suse.de>

Add struct fb_info.lcd_dev for fbdev drivers to store a reference to
their lcd device. Update the lcd's fb_notifier_callback() to test for
this field. The lcd module can now detect if an lcd device belongs to
an fbdev device.

This works similar to the bl_dev for backlights and will allow for
the removal of the check_fb callback from several fbdev driver's lcd
devices.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org>
---
 drivers/video/backlight/lcd.c |  3 +++
 include/linux/fb.h            | 13 +++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
index 2f57d6867d42..c69407aed296 100644
--- a/drivers/video/backlight/lcd.c
+++ b/drivers/video/backlight/lcd.c
@@ -30,6 +30,7 @@ static int fb_notifier_callback(struct notifier_block *self,
 	struct lcd_device *ld = container_of(self, struct lcd_device, fb_notif);
 	struct fb_event *evdata = data;
 	struct fb_info *info = evdata->info;
+	struct lcd_device *fb_lcd = fb_lcd_device(info);
 
 	guard(mutex)(&ld->ops_lock);
 
@@ -37,6 +38,8 @@ static int fb_notifier_callback(struct notifier_block *self,
 		return 0;
 	if (ld->ops->check_fb && !ld->ops->check_fb(ld, info))
 		return 0;
+	if (fb_lcd && fb_lcd != ld)
+		return 0;
 
 	if (event == FB_EVENT_BLANK) {
 		if (ld->ops->set_power)
diff --git a/include/linux/fb.h b/include/linux/fb.h
index 865dad03e73e..bf1893616e9c 100644
--- a/include/linux/fb.h
+++ b/include/linux/fb.h
@@ -21,6 +21,7 @@ struct fb_info;
 struct file;
 struct i2c_adapter;
 struct inode;
+struct lcd_device;
 struct module;
 struct notifier_block;
 struct page;
@@ -480,6 +481,13 @@ struct fb_info {
 	struct mutex bl_curve_mutex;
 	u8 bl_curve[FB_BACKLIGHT_LEVELS];
 #endif
+
+	/*
+	 * Assigned LCD device; set before framebuffer
+	 * registration, remove after unregister
+	 */
+	struct lcd_device *lcd_dev;
+
 #ifdef CONFIG_FB_DEFERRED_IO
 	struct delayed_work deferred_work;
 	unsigned long npagerefs;
@@ -753,6 +761,11 @@ static inline struct backlight_device *fb_bl_device(struct fb_info *info)
 }
 #endif
 
+static inline struct lcd_device *fb_lcd_device(struct fb_info *info)
+{
+	return info->lcd_dev;
+}
+
 /* fbmon.c */
 #define FB_MAXTIMINGS		0
 #define FB_VSYNCTIMINGS		1
-- 
2.46.0


  parent reply	other threads:[~2024-09-06  7:54 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06  7:52 [PATCH v2 00/28] backlight: lcd: Remove fbdev dependencies Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 01/28] backlight: lcd: Rearrange code in fb_notifier_callback() Thomas Zimmermann
2024-09-06  7:52 ` Thomas Zimmermann [this message]
2024-09-06  7:52 ` [PATCH v2 03/28] backlight: lcd: Add LCD_POWER_ constants for power states Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 04/28] backlight: corgi_lcd: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 05/28] backlight: hx8357: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 06/28] backlight: ili922x: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 07/28] backlight: ili9320: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 08/28] backlight: jornada720_lcd: Include <linux/io.h> for IOMEM() macro Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 09/28] backlight: jornada720_lcd: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 10/28] backlight: l4f00242t03: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 11/28] backlight: lms283gf05: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 12/28] backlight: lms501kf03: Remove unnecessary include of <linux/backlight.h> Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 13/28] backlight: lms501kf03: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 14/28] backlight: ltv350qv: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 15/28] backlight: otm3225a: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 16/28] backlight: platform_lcd: Remove include statement for <linux/backlight.h> Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 17/28] backlight: platform_lcd: Remove match_fb from struct plat_lcd_data Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 18/28] backlight: platform_lcd: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 19/28] backlight: tdo24m: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 20/28] fbdev: clps711x-fb: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-10-03 18:33   ` Kees Bakker
2024-10-04 14:01     ` Thomas Zimmermann
2024-11-23 20:11   ` Andy Shevchenko
2024-09-06  7:52 ` [PATCH v2 21/28] fbdev: clps711x-fb: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 22/28] fbdev: imxfb: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 23/28] fbdev: imxfb: Use lcd power constants Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 24/28] fbdev: omap: " Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 25/28] HID: picoLCD: Replace check_fb in favor of struct fb_info.lcd_dev Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 26/28] backlight: lcd: Replace check_fb with controls_device Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 27/28] backlight: lcd: Remove struct fb_videomode from set_mode callback Thomas Zimmermann
2024-09-06  7:52 ` [PATCH v2 28/28] backlight: lcd: Do not include <linux/fb.h> in lcd header Thomas Zimmermann
2024-09-30 15:50 ` [PATCH v2 00/28] backlight: lcd: Remove fbdev dependencies Lee Jones
2024-10-01  8:55 ` [GIT PULL] Immutable branch between Backlight, HID and fbdev due for the v6.13 merge window Lee Jones
2024-10-21 15:51   ` Jiri Kosina
2024-10-25  8:59     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240906075439.98476-3-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=bentiss@kernel.org \
    --cc=bonbons@linux-vserver.org \
    --cc=daniel.thompson@linaro.org \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=festevam@gmail.com \
    --cc=jikos@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).