From: Qianqiang Liu <qianqiang.liu@163.com>
To: aniel@ffwll.ch, deller@gmx.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
Qianqiang Liu <qianqiang.liu@163.com>,
stable@vger.kernel.org,
syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com
Subject: [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs
Date: Mon, 16 Sep 2024 09:10:28 +0800 [thread overview]
Message-ID: <20240916011027.303875-1-qianqiang.liu@163.com> (raw)
syzbot has found a NULL pointer dereference bug in fbcon [1].
This issue is caused by ops->putcs being a NULL pointer.
We need to check the pointer before using it.
[1] https://syzkaller.appspot.com/bug?extid=3d613ae53c031502687a
Cc: stable@vger.kernel.org
Reported-and-tested-by: syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com
Signed-off-by: Qianqiang Liu <qianqiang.liu@163.com>
---
drivers/video/fbdev/core/fbcon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index 3f7333dca508..96c1262cc981 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -1284,7 +1284,7 @@ static void fbcon_putcs(struct vc_data *vc, const u16 *s, unsigned int count,
struct fbcon_display *p = &fb_display[vc->vc_num];
struct fbcon_ops *ops = info->fbcon_par;
- if (!fbcon_is_inactive(vc, info))
+ if (!fbcon_is_inactive(vc, info) && ops->putcs)
ops->putcs(vc, info, s, count, real_y(p, ypos), xpos,
get_color(vc, info, scr_readw(s), 1),
get_color(vc, info, scr_readw(s), 0));
--
2.39.2
next reply other threads:[~2024-09-16 1:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 1:10 Qianqiang Liu [this message]
2024-09-17 6:25 ` [PATCH] fbcon: Fix a NULL pointer dereference issue in fbcon_putcs Helge Deller
2024-09-20 15:30 ` Qianqiang Liu
2024-09-24 16:13 ` [PATCH v2] " Qianqiang Liu
2024-09-24 16:59 ` Helge Deller
2024-09-25 5:29 ` [PATCH v3] " Qianqiang Liu
2024-09-25 19:33 ` Helge Deller
-- strict thread matches above, loose matches on Subject: below --
2024-09-17 7:28 [PATCH] " Qianqiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240916011027.303875-1-qianqiang.liu@163.com \
--to=qianqiang.liu@163.com \
--cc=aniel@ffwll.ch \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=syzbot+3d613ae53c031502687a@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).