* Re: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2
2024-09-21 15:21 [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2 Fabricio Gasperin
@ 2024-09-21 15:38 ` Vinicius Peixoto
2024-09-21 23:49 ` kernel test robot
2024-09-22 2:15 ` kernel test robot
2 siblings, 0 replies; 4+ messages in thread
From: Vinicius Peixoto @ 2024-09-21 15:38 UTC (permalink / raw)
To: Fabricio Gasperin, Sudip Mukherjee, Teddy Wang,
Greg Kroah-Hartman, linux-fbdev, linux-staging, linux-kernel,
~lkcamp/patches
Hi Fabricio,
On 9/21/24 12:21, Fabricio Gasperin wrote:
> Rename function sm750_hw_cursor_setData2 to sm_750_hw_cursor_setdata2
>
> Change made in order to silence the camelCase warning from checkpatch.pl
>
> Signed-off-by: Fabricio Gasperin <fgasperin@lkcamp.dev>
> ---
> drivers/staging/sm750fb/sm750_cursor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_cursor.c b/drivers/staging/sm750fb/sm750_cursor.c
> index eea4d1bd36ce..e95f39b51a2f 100644
> --- a/drivers/staging/sm750fb/sm750_cursor.c
> +++ b/drivers/staging/sm750fb/sm750_cursor.c
> @@ -131,7 +131,7 @@ void sm750_hw_cursor_setData(struct lynx_cursor *cursor, u16 rop,
> }
> }
>
> -void sm750_hw_cursor_setData2(struct lynx_cursor *cursor, u16 rop,
> +void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
> const u8 *pcol, const u8 *pmsk)
I think you missed one other occurrence of this function in the header
(drivers/staging/sm750fb/sm750_cursor.h), which causes it to fail to
build. Please fix the function name there as well. I think those are the
only two occurrences of it, though.
> {
> int i, j, count, pitch, offset;
Thanks,
Vinicius
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2
2024-09-21 15:21 [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2 Fabricio Gasperin
2024-09-21 15:38 ` Vinicius Peixoto
@ 2024-09-21 23:49 ` kernel test robot
2024-09-22 2:15 ` kernel test robot
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2024-09-21 23:49 UTC (permalink / raw)
To: Fabricio Gasperin, Sudip Mukherjee, Teddy Wang,
Greg Kroah-Hartman, linux-fbdev, linux-staging, linux-kernel,
~lkcamp/patches
Cc: oe-kbuild-all
Hi Fabricio,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Fabricio-Gasperin/staging-sm750fb-Rename-variable-sm750_hw_cursor_setData2/20240921-232248
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20240921152124.11560-1-fgasperin%40lkcamp.dev
patch subject: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2
config: arm-allyesconfig (https://download.01.org/0day-ci/archive/20240922/202409220704.MXWsOMfL-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.1.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409220704.MXWsOMfL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409220704.MXWsOMfL-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> drivers/staging/sm750fb/sm750_cursor.c:134:6: warning: no previous prototype for 'sm750_hw_cursor_setdata2' [-Wmissing-prototypes]
134 | void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
| ^~~~~~~~~~~~~~~~~~~~~~~~
vim +/sm750_hw_cursor_setdata2 +134 drivers/staging/sm750fb/sm750_cursor.c
133
> 134 void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2
2024-09-21 15:21 [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2 Fabricio Gasperin
2024-09-21 15:38 ` Vinicius Peixoto
2024-09-21 23:49 ` kernel test robot
@ 2024-09-22 2:15 ` kernel test robot
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2024-09-22 2:15 UTC (permalink / raw)
To: Fabricio Gasperin, Sudip Mukherjee, Teddy Wang,
Greg Kroah-Hartman, linux-fbdev, linux-staging, linux-kernel,
~lkcamp/patches
Cc: llvm, oe-kbuild-all
Hi Fabricio,
kernel test robot noticed the following build warnings:
[auto build test WARNING on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Fabricio-Gasperin/staging-sm750fb-Rename-variable-sm750_hw_cursor_setData2/20240921-232248
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20240921152124.11560-1-fgasperin%40lkcamp.dev
patch subject: [PATCH] staging: sm750fb: Rename variable sm750_hw_cursor_setData2
config: um-allmodconfig (https://download.01.org/0day-ci/archive/20240922/202409221050.Gx1KK7qA-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 8663a75fa2f31299ab8d1d90288d9df92aadee88)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240922/202409221050.Gx1KK7qA-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409221050.Gx1KK7qA-lkp@intel.com/
All warnings (new ones prefixed by >>):
In file included from drivers/staging/sm750fb/sm750_cursor.c:6:
In file included from include/linux/mm.h:2228:
include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
514 | return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
| ~~~~~~~~~~~ ^ ~~~
In file included from drivers/staging/sm750fb/sm750_cursor.c:9:
In file included from include/linux/fb.h:5:
In file included from include/uapi/linux/fb.h:6:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:25:
In file included from include/linux/kernel_stat.h:8:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:548:31: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
548 | val = __raw_readb(PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:561:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
561 | val = __le16_to_cpu((__le16 __force)__raw_readw(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:37:51: note: expanded from macro '__le16_to_cpu'
37 | #define __le16_to_cpu(x) ((__force __u16)(__le16)(x))
| ^
In file included from drivers/staging/sm750fb/sm750_cursor.c:9:
In file included from include/linux/fb.h:5:
In file included from include/uapi/linux/fb.h:6:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:25:
In file included from include/linux/kernel_stat.h:8:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:574:61: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
574 | val = __le32_to_cpu((__le32 __force)__raw_readl(PCI_IOBASE + addr));
| ~~~~~~~~~~ ^
include/uapi/linux/byteorder/little_endian.h:35:51: note: expanded from macro '__le32_to_cpu'
35 | #define __le32_to_cpu(x) ((__force __u32)(__le32)(x))
| ^
In file included from drivers/staging/sm750fb/sm750_cursor.c:9:
In file included from include/linux/fb.h:5:
In file included from include/uapi/linux/fb.h:6:
In file included from include/linux/i2c.h:19:
In file included from include/linux/regulator/consumer.h:35:
In file included from include/linux/suspend.h:5:
In file included from include/linux/swap.h:9:
In file included from include/linux/memcontrol.h:13:
In file included from include/linux/cgroup.h:25:
In file included from include/linux/kernel_stat.h:8:
In file included from include/linux/interrupt.h:11:
In file included from include/linux/hardirq.h:11:
In file included from arch/um/include/asm/hardirq.h:5:
In file included from include/asm-generic/hardirq.h:17:
In file included from include/linux/irq.h:20:
In file included from include/linux/io.h:14:
In file included from arch/um/include/asm/io.h:24:
include/asm-generic/io.h:585:33: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
585 | __raw_writeb(value, PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:595:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
595 | __raw_writew((u16 __force)cpu_to_le16(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:605:59: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
605 | __raw_writel((u32 __force)cpu_to_le32(value), PCI_IOBASE + addr);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:693:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
693 | readsb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:701:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
701 | readsw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:709:20: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
709 | readsl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:718:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
718 | writesb(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:727:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
727 | writesw(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
include/asm-generic/io.h:736:21: warning: performing pointer arithmetic on a null pointer has undefined behavior [-Wnull-pointer-arithmetic]
736 | writesl(PCI_IOBASE + addr, buffer, count);
| ~~~~~~~~~~ ^
>> drivers/staging/sm750fb/sm750_cursor.c:134:6: warning: no previous prototype for function 'sm750_hw_cursor_setdata2' [-Wmissing-prototypes]
134 | void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
| ^
drivers/staging/sm750fb/sm750_cursor.c:134:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
134 | void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
| ^
| static
14 warnings generated.
vim +/sm750_hw_cursor_setdata2 +134 drivers/staging/sm750fb/sm750_cursor.c
133
> 134 void sm750_hw_cursor_setdata2(struct lynx_cursor *cursor, u16 rop,
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread