* Re: [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant
2025-02-22 20:15 [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant Madhur Kumar
@ 2025-02-23 9:34 ` kernel test robot
2025-02-23 14:57 ` kernel test robot
2025-03-20 14:09 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-02-23 9:34 UTC (permalink / raw)
To: Madhur Kumar, sudipm.mukherjee, teddy.wang
Cc: llvm, oe-kbuild-all, gregkh, linux-fbdev, linux-staging,
linux-kernel, Madhur Kumar, Dan Carpenter
Hi Madhur,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Madhur-Kumar/staging-sm750fb-Make-g_fbmode-truly-constant/20250223-041638
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250222201514.15730-1-madhurkumar004%40gmail.com
patch subject: [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant
config: x86_64-buildonly-randconfig-001-20250223 (https://download.01.org/0day-ci/archive/20250223/202502231754.pnnw8mMg-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250223/202502231754.pnnw8mMg-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502231754.pnnw8mMg-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/staging/sm750fb/sm750.c:7:
In file included from include/linux/mm.h:2224:
include/linux/vmstat.h:504:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
504 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
505 | item];
| ~~~~
include/linux/vmstat.h:511:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
511 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
512 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
include/linux/vmstat.h:524:43: warning: arithmetic between different enumeration types ('enum zone_stat_item' and 'enum numa_stat_item') [-Wenum-enum-conversion]
524 | return vmstat_text[NR_VM_ZONE_STAT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~ ^
525 | NR_VM_NUMA_EVENT_ITEMS +
| ~~~~~~~~~~~~~~~~~~~~~~
>> drivers/staging/sm750fb/sm750.c:788:19: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
788 | g_fbmode[index] = g_def_fbmode;
| ~~~~~~~~~~~~~~~ ^
drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
36 | static const char * const g_fbmode[] = {NULL, NULL};
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/sm750fb/sm750.c:790:20: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
790 | g_fbmode[index] = g_fbmode[0];
| ~~~~~~~~~~~~~~~ ^
drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
36 | static const char * const g_fbmode[] = {NULL, NULL};
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/sm750fb/sm750.c:951:17: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
951 | g_fbmode[0] = opt;
| ~~~~~~~~~~~ ^
drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
36 | static const char * const g_fbmode[] = {NULL, NULL};
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
drivers/staging/sm750fb/sm750.c:955:17: error: cannot assign to variable 'g_fbmode' with const-qualified type 'const char *const[2]'
955 | g_fbmode[1] = opt;
| ~~~~~~~~~~~ ^
drivers/staging/sm750fb/sm750.c:36:27: note: variable 'g_fbmode' declared const here
36 | static const char * const g_fbmode[] = {NULL, NULL};
| ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
3 warnings and 4 errors generated.
vim +788 drivers/staging/sm750fb/sm750.c
81dee67e215b23f Sudip Mukherjee 2015-03-03 715
81dee67e215b23f Sudip Mukherjee 2015-03-03 716 static int lynxfb_set_fbinfo(struct fb_info *info, int index)
81dee67e215b23f Sudip Mukherjee 2015-03-03 717 {
81dee67e215b23f Sudip Mukherjee 2015-03-03 718 int i;
81dee67e215b23f Sudip Mukherjee 2015-03-03 719 struct lynxfb_par *par;
e359b6a863e19f2 Mike Rapoport 2015-10-26 720 struct sm750_dev *sm750_dev;
81dee67e215b23f Sudip Mukherjee 2015-03-03 721 struct lynxfb_crtc *crtc;
81dee67e215b23f Sudip Mukherjee 2015-03-03 722 struct lynxfb_output *output;
81dee67e215b23f Sudip Mukherjee 2015-03-03 723 struct fb_var_screeninfo *var;
81dee67e215b23f Sudip Mukherjee 2015-03-03 724 struct fb_fix_screeninfo *fix;
81dee67e215b23f Sudip Mukherjee 2015-03-03 725
81dee67e215b23f Sudip Mukherjee 2015-03-03 726 const struct fb_videomode *pdb[] = {
81dee67e215b23f Sudip Mukherjee 2015-03-03 727 lynx750_ext, NULL, vesa_modes,
81dee67e215b23f Sudip Mukherjee 2015-03-03 728 };
81dee67e215b23f Sudip Mukherjee 2015-03-03 729 int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
d5d66cfea2ca281 Kelsey Skunberg 2019-04-27 730 static const char * const mdb_desc[] = {
81dee67e215b23f Sudip Mukherjee 2015-03-03 731 "driver prepared modes",
81dee67e215b23f Sudip Mukherjee 2015-03-03 732 "kernel prepared default modedb",
81dee67e215b23f Sudip Mukherjee 2015-03-03 733 "kernel HELPERS prepared vesa_modes",
81dee67e215b23f Sudip Mukherjee 2015-03-03 734 };
81dee67e215b23f Sudip Mukherjee 2015-03-03 735
70407df77665c0e Michel von Czettritz 2015-03-26 736 static const char *fixId[2] = {
81dee67e215b23f Sudip Mukherjee 2015-03-03 737 "sm750_fb1", "sm750_fb2",
81dee67e215b23f Sudip Mukherjee 2015-03-03 738 };
81dee67e215b23f Sudip Mukherjee 2015-03-03 739
81dee67e215b23f Sudip Mukherjee 2015-03-03 740 int ret, line_length;
81dee67e215b23f Sudip Mukherjee 2015-03-03 741
81dee67e215b23f Sudip Mukherjee 2015-03-03 742 ret = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 743 par = (struct lynxfb_par *)info->par;
e359b6a863e19f2 Mike Rapoport 2015-10-26 744 sm750_dev = par->dev;
81dee67e215b23f Sudip Mukherjee 2015-03-03 745 crtc = &par->crtc;
81dee67e215b23f Sudip Mukherjee 2015-03-03 746 output = &par->output;
81dee67e215b23f Sudip Mukherjee 2015-03-03 747 var = &info->var;
81dee67e215b23f Sudip Mukherjee 2015-03-03 748 fix = &info->fix;
81dee67e215b23f Sudip Mukherjee 2015-03-03 749
81dee67e215b23f Sudip Mukherjee 2015-03-03 750 /* set index */
81dee67e215b23f Sudip Mukherjee 2015-03-03 751 par->index = index;
81dee67e215b23f Sudip Mukherjee 2015-03-03 752 output->channel = &crtc->channel;
81dee67e215b23f Sudip Mukherjee 2015-03-03 753 sm750fb_set_drv(par);
81dee67e215b23f Sudip Mukherjee 2015-03-03 754
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 755 /*
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 756 * set current cursor variable and proc pointer,
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 757 * must be set after crtc member initialized
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 758 */
fdc234d85210d91 Benjamin Philip 2021-07-28 759 crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
e359b6a863e19f2 Mike Rapoport 2015-10-26 760 crtc->cursor.mmio = sm750_dev->pvReg +
e359b6a863e19f2 Mike Rapoport 2015-10-26 761 0x800f0 + (int)crtc->channel * 0x140;
81dee67e215b23f Sudip Mukherjee 2015-03-03 762
81dee67e215b23f Sudip Mukherjee 2015-03-03 763 pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio);
cd33da26036ea54 Christopher Carbone 2022-08-23 764 crtc->cursor.max_h = 64;
cd33da26036ea54 Christopher Carbone 2022-08-23 765 crtc->cursor.max_w = 64;
39f9137268ee3df Benjamin Philip 2021-07-26 766 crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8;
e359b6a863e19f2 Mike Rapoport 2015-10-26 767 crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset;
81dee67e215b23f Sudip Mukherjee 2015-03-03 768
3de08a2d14ff8c7 Lorenzo Stoakes 2015-03-20 769 memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
f7c8a046577e09d Thomas Zimmermann 2023-11-27 770 if (!g_hwcursor)
52d0744d751d8f1 Arnd Bergmann 2016-11-09 771 sm750_hw_cursor_disable(&crtc->cursor);
81dee67e215b23f Sudip Mukherjee 2015-03-03 772
81dee67e215b23f Sudip Mukherjee 2015-03-03 773 /* set info->fbops, must be set before fb_find_mode */
e359b6a863e19f2 Mike Rapoport 2015-10-26 774 if (!sm750_dev->accel_off) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 775 /* use 2d acceleration */
f7c8a046577e09d Thomas Zimmermann 2023-11-27 776 if (!g_hwcursor)
f7c8a046577e09d Thomas Zimmermann 2023-11-27 777 info->fbops = &lynxfb_ops_accel;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 778 else
f7c8a046577e09d Thomas Zimmermann 2023-11-27 779 info->fbops = &lynxfb_ops_accel_with_cursor;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 780 } else {
f7c8a046577e09d Thomas Zimmermann 2023-11-27 781 if (!g_hwcursor)
81dee67e215b23f Sudip Mukherjee 2015-03-03 782 info->fbops = &lynxfb_ops;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 783 else
f7c8a046577e09d Thomas Zimmermann 2023-11-27 784 info->fbops = &lynxfb_ops_with_cursor;
f7c8a046577e09d Thomas Zimmermann 2023-11-27 785 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 786
81dee67e215b23f Sudip Mukherjee 2015-03-03 787 if (!g_fbmode[index]) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 @788 g_fbmode[index] = g_def_fbmode;
81dee67e215b23f Sudip Mukherjee 2015-03-03 789 if (index)
81dee67e215b23f Sudip Mukherjee 2015-03-03 790 g_fbmode[index] = g_fbmode[0];
81dee67e215b23f Sudip Mukherjee 2015-03-03 791 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 792
81dee67e215b23f Sudip Mukherjee 2015-03-03 793 for (i = 0; i < 3; i++) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 794 ret = fb_find_mode(var, info, g_fbmode[index],
81dee67e215b23f Sudip Mukherjee 2015-03-03 795 pdb[i], cdb[i], NULL, 8);
81dee67e215b23f Sudip Mukherjee 2015-03-03 796
81dee67e215b23f Sudip Mukherjee 2015-03-03 797 if (ret == 1) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 798 pr_info("success! use specified mode:%s in %s\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 799 g_fbmode[index],
81dee67e215b23f Sudip Mukherjee 2015-03-03 800 mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 801 break;
81dee67e215b23f Sudip Mukherjee 2015-03-03 802 } else if (ret == 2) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 803 pr_warn("use specified mode:%s in %s,with an ignored refresh rate\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 804 g_fbmode[index],
81dee67e215b23f Sudip Mukherjee 2015-03-03 805 mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 806 break;
81dee67e215b23f Sudip Mukherjee 2015-03-03 807 } else if (ret == 3) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 808 pr_warn("wanna use default mode\n");
4bd9503d0becdb6 Michel von Czettritz 2015-03-26 809 /*break;*/
81dee67e215b23f Sudip Mukherjee 2015-03-03 810 } else if (ret == 4) {
81dee67e215b23f Sudip Mukherjee 2015-03-03 811 pr_warn("fall back to any valid mode\n");
81dee67e215b23f Sudip Mukherjee 2015-03-03 812 } else {
3318bb5e945f700 Michel von Czettritz 2015-03-26 813 pr_warn("ret = %d,fb_find_mode failed,with %s\n",
3318bb5e945f700 Michel von Czettritz 2015-03-26 814 ret,
3318bb5e945f700 Michel von Czettritz 2015-03-26 815 mdb_desc[i]);
81dee67e215b23f Sudip Mukherjee 2015-03-03 816 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 817 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 818
81dee67e215b23f Sudip Mukherjee 2015-03-03 819 /* some member of info->var had been set by fb_find_mode */
81dee67e215b23f Sudip Mukherjee 2015-03-03 820
271dbae3c6a1daa Prasant Jalan 2017-04-01 821 pr_info("Member of info->var is :\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 822 "xres=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 823 "yres=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 824 "xres_virtual=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 825 "yres_virtual=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 826 "xoffset=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 827 "yoffset=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 828 "bits_per_pixel=%d\n"
271dbae3c6a1daa Prasant Jalan 2017-04-01 829 " ...\n",
3318bb5e945f700 Michel von Czettritz 2015-03-26 830 var->xres,
3318bb5e945f700 Michel von Czettritz 2015-03-26 831 var->yres,
3318bb5e945f700 Michel von Czettritz 2015-03-26 832 var->xres_virtual,
3318bb5e945f700 Michel von Czettritz 2015-03-26 833 var->yres_virtual,
3318bb5e945f700 Michel von Czettritz 2015-03-26 834 var->xoffset,
3318bb5e945f700 Michel von Czettritz 2015-03-26 835 var->yoffset,
3318bb5e945f700 Michel von Czettritz 2015-03-26 836 var->bits_per_pixel);
81dee67e215b23f Sudip Mukherjee 2015-03-03 837
81dee67e215b23f Sudip Mukherjee 2015-03-03 838 /* set par */
81dee67e215b23f Sudip Mukherjee 2015-03-03 839 par->info = info;
81dee67e215b23f Sudip Mukherjee 2015-03-03 840
81dee67e215b23f Sudip Mukherjee 2015-03-03 841 /* set info */
e3a3f9f5123683b Mike Rapoport 2015-10-26 842 line_length = ALIGN((var->xres_virtual * var->bits_per_pixel / 8),
e3a3f9f5123683b Mike Rapoport 2015-10-26 843 crtc->line_pad);
81dee67e215b23f Sudip Mukherjee 2015-03-03 844
81dee67e215b23f Sudip Mukherjee 2015-03-03 845 info->pseudo_palette = &par->pseudo_palette[0];
cc59bde1c920ab6 Benjamin Philip 2021-07-28 846 info->screen_base = crtc->v_screen;
81dee67e215b23f Sudip Mukherjee 2015-03-03 847 pr_debug("screen_base vaddr = %p\n", info->screen_base);
81dee67e215b23f Sudip Mukherjee 2015-03-03 848 info->screen_size = line_length * var->yres_virtual;
81dee67e215b23f Sudip Mukherjee 2015-03-03 849
81dee67e215b23f Sudip Mukherjee 2015-03-03 850 /* set info->fix */
81dee67e215b23f Sudip Mukherjee 2015-03-03 851 fix->type = FB_TYPE_PACKED_PIXELS;
81dee67e215b23f Sudip Mukherjee 2015-03-03 852 fix->type_aux = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 853 fix->xpanstep = crtc->xpanstep;
81dee67e215b23f Sudip Mukherjee 2015-03-03 854 fix->ypanstep = crtc->ypanstep;
81dee67e215b23f Sudip Mukherjee 2015-03-03 855 fix->ywrapstep = crtc->ywrapstep;
81dee67e215b23f Sudip Mukherjee 2015-03-03 856 fix->accel = FB_ACCEL_SMI;
81dee67e215b23f Sudip Mukherjee 2015-03-03 857
9c15db83a86bf83 Kumar Kartikeya Dwivedi 2021-01-31 858 strscpy(fix->id, fixId[index], sizeof(fix->id));
81dee67e215b23f Sudip Mukherjee 2015-03-03 859
fdc234d85210d91 Benjamin Philip 2021-07-28 860 fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
81dee67e215b23f Sudip Mukherjee 2015-03-03 861 pr_info("fix->smem_start = %lx\n", fix->smem_start);
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 862 /*
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 863 * according to mmap experiment from user space application,
81dee67e215b23f Sudip Mukherjee 2015-03-03 864 * fix->mmio_len should not larger than virtual size
81dee67e215b23f Sudip Mukherjee 2015-03-03 865 * (xres_virtual x yres_virtual x ByPP)
81dee67e215b23f Sudip Mukherjee 2015-03-03 866 * Below line maybe buggy when user mmap fb dev node and write
81dee67e215b23f Sudip Mukherjee 2015-03-03 867 * data into the bound over virtual size
d11ac7cbcc266c6 Sudip Mukherjee 2015-08-07 868 */
81dee67e215b23f Sudip Mukherjee 2015-03-03 869 fix->smem_len = crtc->vidmem_size;
81dee67e215b23f Sudip Mukherjee 2015-03-03 870 pr_info("fix->smem_len = %x\n", fix->smem_len);
81dee67e215b23f Sudip Mukherjee 2015-03-03 871 info->screen_size = fix->smem_len;
81dee67e215b23f Sudip Mukherjee 2015-03-03 872 fix->line_length = line_length;
e359b6a863e19f2 Mike Rapoport 2015-10-26 873 fix->mmio_start = sm750_dev->vidreg_start;
81dee67e215b23f Sudip Mukherjee 2015-03-03 874 pr_info("fix->mmio_start = %lx\n", fix->mmio_start);
e359b6a863e19f2 Mike Rapoport 2015-10-26 875 fix->mmio_len = sm750_dev->vidreg_size;
81dee67e215b23f Sudip Mukherjee 2015-03-03 876 pr_info("fix->mmio_len = %x\n", fix->mmio_len);
b610e1193a917f4 Matej Dujava 2020-04-30 877
b610e1193a917f4 Matej Dujava 2020-04-30 878 lynxfb_set_visual_mode(info);
81dee67e215b23f Sudip Mukherjee 2015-03-03 879
81dee67e215b23f Sudip Mukherjee 2015-03-03 880 /* set var */
81dee67e215b23f Sudip Mukherjee 2015-03-03 881 var->activate = FB_ACTIVATE_NOW;
81dee67e215b23f Sudip Mukherjee 2015-03-03 882 var->accel_flags = 0;
81dee67e215b23f Sudip Mukherjee 2015-03-03 883 var->vmode = FB_VMODE_NONINTERLACED;
81dee67e215b23f Sudip Mukherjee 2015-03-03 884
81dee67e215b23f Sudip Mukherjee 2015-03-03 885 pr_debug("#1 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 886 info->cmap.start, info->cmap.len,
81dee67e215b23f Sudip Mukherjee 2015-03-03 887 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23f Sudip Mukherjee 2015-03-03 888 info->cmap.transp);
81dee67e215b23f Sudip Mukherjee 2015-03-03 889
61c507cf652da1b Michel von Czettritz 2015-03-26 890 ret = fb_alloc_cmap(&info->cmap, 256, 0);
61c507cf652da1b Michel von Czettritz 2015-03-26 891 if (ret < 0) {
008272072d61a8c Masanari Iida 2015-05-28 892 pr_err("Could not allocate memory for cmap.\n");
81dee67e215b23f Sudip Mukherjee 2015-03-03 893 goto exit;
81dee67e215b23f Sudip Mukherjee 2015-03-03 894 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 895
81dee67e215b23f Sudip Mukherjee 2015-03-03 896 pr_debug("#2 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23f Sudip Mukherjee 2015-03-03 897 info->cmap.start, info->cmap.len,
81dee67e215b23f Sudip Mukherjee 2015-03-03 898 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23f Sudip Mukherjee 2015-03-03 899 info->cmap.transp);
81dee67e215b23f Sudip Mukherjee 2015-03-03 900
81dee67e215b23f Sudip Mukherjee 2015-03-03 901 exit:
81dee67e215b23f Sudip Mukherjee 2015-03-03 902 lynxfb_ops_check_var(var, info);
81dee67e215b23f Sudip Mukherjee 2015-03-03 903 return ret;
81dee67e215b23f Sudip Mukherjee 2015-03-03 904 }
81dee67e215b23f Sudip Mukherjee 2015-03-03 905
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant
2025-02-22 20:15 [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant Madhur Kumar
2025-02-23 9:34 ` kernel test robot
@ 2025-02-23 14:57 ` kernel test robot
2025-03-20 14:09 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2025-02-23 14:57 UTC (permalink / raw)
To: Madhur Kumar, sudipm.mukherjee, teddy.wang
Cc: oe-kbuild-all, gregkh, linux-fbdev, linux-staging, linux-kernel,
Madhur Kumar, Dan Carpenter
Hi Madhur,
kernel test robot noticed the following build errors:
[auto build test ERROR on staging/staging-testing]
url: https://github.com/intel-lab-lkp/linux/commits/Madhur-Kumar/staging-sm750fb-Make-g_fbmode-truly-constant/20250223-041638
base: staging/staging-testing
patch link: https://lore.kernel.org/r/20250222201514.15730-1-madhurkumar004%40gmail.com
patch subject: [PATCH] [PATCH v2] staging: sm750fb: Make g_fbmode truly constant
config: sparc64-randconfig-001-20250223 (https://download.01.org/0day-ci/archive/20250223/202502232236.CRIQt4Wb-lkp@intel.com/config)
compiler: sparc64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250223/202502232236.CRIQt4Wb-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502232236.CRIQt4Wb-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/staging/sm750fb/sm750.c: In function 'lynxfb_set_fbinfo':
>> drivers/staging/sm750fb/sm750.c:788:33: error: assignment of read-only location 'g_fbmode[index]'
788 | g_fbmode[index] = g_def_fbmode;
| ^
drivers/staging/sm750fb/sm750.c:790:41: error: assignment of read-only location 'g_fbmode[index]'
790 | g_fbmode[index] = g_fbmode[0];
| ^
drivers/staging/sm750fb/sm750.c: In function 'sm750fb_setup':
>> drivers/staging/sm750fb/sm750.c:951:45: error: assignment of read-only location 'g_fbmode[0]'
951 | g_fbmode[0] = opt;
| ^
drivers/staging/sm750fb/sm750.c:955:45: error: assignment of read-only location 'g_fbmode[1]'
955 | g_fbmode[1] = opt;
| ^
vim +788 drivers/staging/sm750fb/sm750.c
81dee67e215b23 Sudip Mukherjee 2015-03-03 715
81dee67e215b23 Sudip Mukherjee 2015-03-03 716 static int lynxfb_set_fbinfo(struct fb_info *info, int index)
81dee67e215b23 Sudip Mukherjee 2015-03-03 717 {
81dee67e215b23 Sudip Mukherjee 2015-03-03 718 int i;
81dee67e215b23 Sudip Mukherjee 2015-03-03 719 struct lynxfb_par *par;
e359b6a863e19f Mike Rapoport 2015-10-26 720 struct sm750_dev *sm750_dev;
81dee67e215b23 Sudip Mukherjee 2015-03-03 721 struct lynxfb_crtc *crtc;
81dee67e215b23 Sudip Mukherjee 2015-03-03 722 struct lynxfb_output *output;
81dee67e215b23 Sudip Mukherjee 2015-03-03 723 struct fb_var_screeninfo *var;
81dee67e215b23 Sudip Mukherjee 2015-03-03 724 struct fb_fix_screeninfo *fix;
81dee67e215b23 Sudip Mukherjee 2015-03-03 725
81dee67e215b23 Sudip Mukherjee 2015-03-03 726 const struct fb_videomode *pdb[] = {
81dee67e215b23 Sudip Mukherjee 2015-03-03 727 lynx750_ext, NULL, vesa_modes,
81dee67e215b23 Sudip Mukherjee 2015-03-03 728 };
81dee67e215b23 Sudip Mukherjee 2015-03-03 729 int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
d5d66cfea2ca28 Kelsey Skunberg 2019-04-27 730 static const char * const mdb_desc[] = {
81dee67e215b23 Sudip Mukherjee 2015-03-03 731 "driver prepared modes",
81dee67e215b23 Sudip Mukherjee 2015-03-03 732 "kernel prepared default modedb",
81dee67e215b23 Sudip Mukherjee 2015-03-03 733 "kernel HELPERS prepared vesa_modes",
81dee67e215b23 Sudip Mukherjee 2015-03-03 734 };
81dee67e215b23 Sudip Mukherjee 2015-03-03 735
70407df77665c0 Michel von Czettritz 2015-03-26 736 static const char *fixId[2] = {
81dee67e215b23 Sudip Mukherjee 2015-03-03 737 "sm750_fb1", "sm750_fb2",
81dee67e215b23 Sudip Mukherjee 2015-03-03 738 };
81dee67e215b23 Sudip Mukherjee 2015-03-03 739
81dee67e215b23 Sudip Mukherjee 2015-03-03 740 int ret, line_length;
81dee67e215b23 Sudip Mukherjee 2015-03-03 741
81dee67e215b23 Sudip Mukherjee 2015-03-03 742 ret = 0;
81dee67e215b23 Sudip Mukherjee 2015-03-03 743 par = (struct lynxfb_par *)info->par;
e359b6a863e19f Mike Rapoport 2015-10-26 744 sm750_dev = par->dev;
81dee67e215b23 Sudip Mukherjee 2015-03-03 745 crtc = &par->crtc;
81dee67e215b23 Sudip Mukherjee 2015-03-03 746 output = &par->output;
81dee67e215b23 Sudip Mukherjee 2015-03-03 747 var = &info->var;
81dee67e215b23 Sudip Mukherjee 2015-03-03 748 fix = &info->fix;
81dee67e215b23 Sudip Mukherjee 2015-03-03 749
81dee67e215b23 Sudip Mukherjee 2015-03-03 750 /* set index */
81dee67e215b23 Sudip Mukherjee 2015-03-03 751 par->index = index;
81dee67e215b23 Sudip Mukherjee 2015-03-03 752 output->channel = &crtc->channel;
81dee67e215b23 Sudip Mukherjee 2015-03-03 753 sm750fb_set_drv(par);
81dee67e215b23 Sudip Mukherjee 2015-03-03 754
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 755 /*
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 756 * set current cursor variable and proc pointer,
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 757 * must be set after crtc member initialized
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 758 */
fdc234d85210d9 Benjamin Philip 2021-07-28 759 crtc->cursor.offset = crtc->o_screen + crtc->vidmem_size - 1024;
e359b6a863e19f Mike Rapoport 2015-10-26 760 crtc->cursor.mmio = sm750_dev->pvReg +
e359b6a863e19f Mike Rapoport 2015-10-26 761 0x800f0 + (int)crtc->channel * 0x140;
81dee67e215b23 Sudip Mukherjee 2015-03-03 762
81dee67e215b23 Sudip Mukherjee 2015-03-03 763 pr_info("crtc->cursor.mmio = %p\n", crtc->cursor.mmio);
cd33da26036ea5 Christopher Carbone 2022-08-23 764 crtc->cursor.max_h = 64;
cd33da26036ea5 Christopher Carbone 2022-08-23 765 crtc->cursor.max_w = 64;
39f9137268ee3d Benjamin Philip 2021-07-26 766 crtc->cursor.size = crtc->cursor.max_h * crtc->cursor.max_w * 2 / 8;
e359b6a863e19f Mike Rapoport 2015-10-26 767 crtc->cursor.vstart = sm750_dev->pvMem + crtc->cursor.offset;
81dee67e215b23 Sudip Mukherjee 2015-03-03 768
3de08a2d14ff8c Lorenzo Stoakes 2015-03-20 769 memset_io(crtc->cursor.vstart, 0, crtc->cursor.size);
f7c8a046577e09 Thomas Zimmermann 2023-11-27 770 if (!g_hwcursor)
52d0744d751d8f Arnd Bergmann 2016-11-09 771 sm750_hw_cursor_disable(&crtc->cursor);
81dee67e215b23 Sudip Mukherjee 2015-03-03 772
81dee67e215b23 Sudip Mukherjee 2015-03-03 773 /* set info->fbops, must be set before fb_find_mode */
e359b6a863e19f Mike Rapoport 2015-10-26 774 if (!sm750_dev->accel_off) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 775 /* use 2d acceleration */
f7c8a046577e09 Thomas Zimmermann 2023-11-27 776 if (!g_hwcursor)
f7c8a046577e09 Thomas Zimmermann 2023-11-27 777 info->fbops = &lynxfb_ops_accel;
f7c8a046577e09 Thomas Zimmermann 2023-11-27 778 else
f7c8a046577e09 Thomas Zimmermann 2023-11-27 779 info->fbops = &lynxfb_ops_accel_with_cursor;
f7c8a046577e09 Thomas Zimmermann 2023-11-27 780 } else {
f7c8a046577e09 Thomas Zimmermann 2023-11-27 781 if (!g_hwcursor)
81dee67e215b23 Sudip Mukherjee 2015-03-03 782 info->fbops = &lynxfb_ops;
f7c8a046577e09 Thomas Zimmermann 2023-11-27 783 else
f7c8a046577e09 Thomas Zimmermann 2023-11-27 784 info->fbops = &lynxfb_ops_with_cursor;
f7c8a046577e09 Thomas Zimmermann 2023-11-27 785 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 786
81dee67e215b23 Sudip Mukherjee 2015-03-03 787 if (!g_fbmode[index]) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 @788 g_fbmode[index] = g_def_fbmode;
81dee67e215b23 Sudip Mukherjee 2015-03-03 789 if (index)
81dee67e215b23 Sudip Mukherjee 2015-03-03 790 g_fbmode[index] = g_fbmode[0];
81dee67e215b23 Sudip Mukherjee 2015-03-03 791 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 792
81dee67e215b23 Sudip Mukherjee 2015-03-03 793 for (i = 0; i < 3; i++) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 794 ret = fb_find_mode(var, info, g_fbmode[index],
81dee67e215b23 Sudip Mukherjee 2015-03-03 795 pdb[i], cdb[i], NULL, 8);
81dee67e215b23 Sudip Mukherjee 2015-03-03 796
81dee67e215b23 Sudip Mukherjee 2015-03-03 797 if (ret == 1) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 798 pr_info("success! use specified mode:%s in %s\n",
81dee67e215b23 Sudip Mukherjee 2015-03-03 799 g_fbmode[index],
81dee67e215b23 Sudip Mukherjee 2015-03-03 800 mdb_desc[i]);
81dee67e215b23 Sudip Mukherjee 2015-03-03 801 break;
81dee67e215b23 Sudip Mukherjee 2015-03-03 802 } else if (ret == 2) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 803 pr_warn("use specified mode:%s in %s,with an ignored refresh rate\n",
81dee67e215b23 Sudip Mukherjee 2015-03-03 804 g_fbmode[index],
81dee67e215b23 Sudip Mukherjee 2015-03-03 805 mdb_desc[i]);
81dee67e215b23 Sudip Mukherjee 2015-03-03 806 break;
81dee67e215b23 Sudip Mukherjee 2015-03-03 807 } else if (ret == 3) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 808 pr_warn("wanna use default mode\n");
4bd9503d0becdb Michel von Czettritz 2015-03-26 809 /*break;*/
81dee67e215b23 Sudip Mukherjee 2015-03-03 810 } else if (ret == 4) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 811 pr_warn("fall back to any valid mode\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 812 } else {
3318bb5e945f70 Michel von Czettritz 2015-03-26 813 pr_warn("ret = %d,fb_find_mode failed,with %s\n",
3318bb5e945f70 Michel von Czettritz 2015-03-26 814 ret,
3318bb5e945f70 Michel von Czettritz 2015-03-26 815 mdb_desc[i]);
81dee67e215b23 Sudip Mukherjee 2015-03-03 816 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 817 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 818
81dee67e215b23 Sudip Mukherjee 2015-03-03 819 /* some member of info->var had been set by fb_find_mode */
81dee67e215b23 Sudip Mukherjee 2015-03-03 820
271dbae3c6a1da Prasant Jalan 2017-04-01 821 pr_info("Member of info->var is :\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 822 "xres=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 823 "yres=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 824 "xres_virtual=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 825 "yres_virtual=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 826 "xoffset=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 827 "yoffset=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 828 "bits_per_pixel=%d\n"
271dbae3c6a1da Prasant Jalan 2017-04-01 829 " ...\n",
3318bb5e945f70 Michel von Czettritz 2015-03-26 830 var->xres,
3318bb5e945f70 Michel von Czettritz 2015-03-26 831 var->yres,
3318bb5e945f70 Michel von Czettritz 2015-03-26 832 var->xres_virtual,
3318bb5e945f70 Michel von Czettritz 2015-03-26 833 var->yres_virtual,
3318bb5e945f70 Michel von Czettritz 2015-03-26 834 var->xoffset,
3318bb5e945f70 Michel von Czettritz 2015-03-26 835 var->yoffset,
3318bb5e945f70 Michel von Czettritz 2015-03-26 836 var->bits_per_pixel);
81dee67e215b23 Sudip Mukherjee 2015-03-03 837
81dee67e215b23 Sudip Mukherjee 2015-03-03 838 /* set par */
81dee67e215b23 Sudip Mukherjee 2015-03-03 839 par->info = info;
81dee67e215b23 Sudip Mukherjee 2015-03-03 840
81dee67e215b23 Sudip Mukherjee 2015-03-03 841 /* set info */
e3a3f9f5123683 Mike Rapoport 2015-10-26 842 line_length = ALIGN((var->xres_virtual * var->bits_per_pixel / 8),
e3a3f9f5123683 Mike Rapoport 2015-10-26 843 crtc->line_pad);
81dee67e215b23 Sudip Mukherjee 2015-03-03 844
81dee67e215b23 Sudip Mukherjee 2015-03-03 845 info->pseudo_palette = &par->pseudo_palette[0];
cc59bde1c920ab Benjamin Philip 2021-07-28 846 info->screen_base = crtc->v_screen;
81dee67e215b23 Sudip Mukherjee 2015-03-03 847 pr_debug("screen_base vaddr = %p\n", info->screen_base);
81dee67e215b23 Sudip Mukherjee 2015-03-03 848 info->screen_size = line_length * var->yres_virtual;
81dee67e215b23 Sudip Mukherjee 2015-03-03 849
81dee67e215b23 Sudip Mukherjee 2015-03-03 850 /* set info->fix */
81dee67e215b23 Sudip Mukherjee 2015-03-03 851 fix->type = FB_TYPE_PACKED_PIXELS;
81dee67e215b23 Sudip Mukherjee 2015-03-03 852 fix->type_aux = 0;
81dee67e215b23 Sudip Mukherjee 2015-03-03 853 fix->xpanstep = crtc->xpanstep;
81dee67e215b23 Sudip Mukherjee 2015-03-03 854 fix->ypanstep = crtc->ypanstep;
81dee67e215b23 Sudip Mukherjee 2015-03-03 855 fix->ywrapstep = crtc->ywrapstep;
81dee67e215b23 Sudip Mukherjee 2015-03-03 856 fix->accel = FB_ACCEL_SMI;
81dee67e215b23 Sudip Mukherjee 2015-03-03 857
9c15db83a86bf8 Kumar Kartikeya Dwivedi 2021-01-31 858 strscpy(fix->id, fixId[index], sizeof(fix->id));
81dee67e215b23 Sudip Mukherjee 2015-03-03 859
fdc234d85210d9 Benjamin Philip 2021-07-28 860 fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
81dee67e215b23 Sudip Mukherjee 2015-03-03 861 pr_info("fix->smem_start = %lx\n", fix->smem_start);
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 862 /*
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 863 * according to mmap experiment from user space application,
81dee67e215b23 Sudip Mukherjee 2015-03-03 864 * fix->mmio_len should not larger than virtual size
81dee67e215b23 Sudip Mukherjee 2015-03-03 865 * (xres_virtual x yres_virtual x ByPP)
81dee67e215b23 Sudip Mukherjee 2015-03-03 866 * Below line maybe buggy when user mmap fb dev node and write
81dee67e215b23 Sudip Mukherjee 2015-03-03 867 * data into the bound over virtual size
d11ac7cbcc266c Sudip Mukherjee 2015-08-07 868 */
81dee67e215b23 Sudip Mukherjee 2015-03-03 869 fix->smem_len = crtc->vidmem_size;
81dee67e215b23 Sudip Mukherjee 2015-03-03 870 pr_info("fix->smem_len = %x\n", fix->smem_len);
81dee67e215b23 Sudip Mukherjee 2015-03-03 871 info->screen_size = fix->smem_len;
81dee67e215b23 Sudip Mukherjee 2015-03-03 872 fix->line_length = line_length;
e359b6a863e19f Mike Rapoport 2015-10-26 873 fix->mmio_start = sm750_dev->vidreg_start;
81dee67e215b23 Sudip Mukherjee 2015-03-03 874 pr_info("fix->mmio_start = %lx\n", fix->mmio_start);
e359b6a863e19f Mike Rapoport 2015-10-26 875 fix->mmio_len = sm750_dev->vidreg_size;
81dee67e215b23 Sudip Mukherjee 2015-03-03 876 pr_info("fix->mmio_len = %x\n", fix->mmio_len);
b610e1193a917f Matej Dujava 2020-04-30 877
b610e1193a917f Matej Dujava 2020-04-30 878 lynxfb_set_visual_mode(info);
81dee67e215b23 Sudip Mukherjee 2015-03-03 879
81dee67e215b23 Sudip Mukherjee 2015-03-03 880 /* set var */
81dee67e215b23 Sudip Mukherjee 2015-03-03 881 var->activate = FB_ACTIVATE_NOW;
81dee67e215b23 Sudip Mukherjee 2015-03-03 882 var->accel_flags = 0;
81dee67e215b23 Sudip Mukherjee 2015-03-03 883 var->vmode = FB_VMODE_NONINTERLACED;
81dee67e215b23 Sudip Mukherjee 2015-03-03 884
81dee67e215b23 Sudip Mukherjee 2015-03-03 885 pr_debug("#1 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23 Sudip Mukherjee 2015-03-03 886 info->cmap.start, info->cmap.len,
81dee67e215b23 Sudip Mukherjee 2015-03-03 887 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23 Sudip Mukherjee 2015-03-03 888 info->cmap.transp);
81dee67e215b23 Sudip Mukherjee 2015-03-03 889
61c507cf652da1 Michel von Czettritz 2015-03-26 890 ret = fb_alloc_cmap(&info->cmap, 256, 0);
61c507cf652da1 Michel von Czettritz 2015-03-26 891 if (ret < 0) {
008272072d61a8 Masanari Iida 2015-05-28 892 pr_err("Could not allocate memory for cmap.\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 893 goto exit;
81dee67e215b23 Sudip Mukherjee 2015-03-03 894 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 895
81dee67e215b23 Sudip Mukherjee 2015-03-03 896 pr_debug("#2 show info->cmap :\nstart=%d,len=%d,red=%p,green=%p,blue=%p,transp=%p\n",
81dee67e215b23 Sudip Mukherjee 2015-03-03 897 info->cmap.start, info->cmap.len,
81dee67e215b23 Sudip Mukherjee 2015-03-03 898 info->cmap.red, info->cmap.green, info->cmap.blue,
81dee67e215b23 Sudip Mukherjee 2015-03-03 899 info->cmap.transp);
81dee67e215b23 Sudip Mukherjee 2015-03-03 900
81dee67e215b23 Sudip Mukherjee 2015-03-03 901 exit:
81dee67e215b23 Sudip Mukherjee 2015-03-03 902 lynxfb_ops_check_var(var, info);
81dee67e215b23 Sudip Mukherjee 2015-03-03 903 return ret;
81dee67e215b23 Sudip Mukherjee 2015-03-03 904 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 905
81dee67e215b23 Sudip Mukherjee 2015-03-03 906 /* chip specific g_option configuration routine */
700591a9adc8b1 Mike Rapoport 2015-10-26 907 static void sm750fb_setup(struct sm750_dev *sm750_dev, char *src)
81dee67e215b23 Sudip Mukherjee 2015-03-03 908 {
81dee67e215b23 Sudip Mukherjee 2015-03-03 909 char *opt;
81dee67e215b23 Sudip Mukherjee 2015-03-03 910 int swap;
81dee67e215b23 Sudip Mukherjee 2015-03-03 911
81dee67e215b23 Sudip Mukherjee 2015-03-03 912 swap = 0;
81dee67e215b23 Sudip Mukherjee 2015-03-03 913
1757d106a9ce8c Mike Rapoport 2015-10-26 914 sm750_dev->initParm.chip_clk = 0;
1757d106a9ce8c Mike Rapoport 2015-10-26 915 sm750_dev->initParm.mem_clk = 0;
1757d106a9ce8c Mike Rapoport 2015-10-26 916 sm750_dev->initParm.master_clk = 0;
1757d106a9ce8c Mike Rapoport 2015-10-26 917 sm750_dev->initParm.powerMode = 0;
1757d106a9ce8c Mike Rapoport 2015-10-26 918 sm750_dev->initParm.setAllEngOff = 0;
1757d106a9ce8c Mike Rapoport 2015-10-26 919 sm750_dev->initParm.resetMemory = 1;
81dee67e215b23 Sudip Mukherjee 2015-03-03 920
81dee67e215b23 Sudip Mukherjee 2015-03-03 921 /* defaultly turn g_hwcursor on for both view */
81dee67e215b23 Sudip Mukherjee 2015-03-03 922 g_hwcursor = 3;
81dee67e215b23 Sudip Mukherjee 2015-03-03 923
81dee67e215b23 Sudip Mukherjee 2015-03-03 924 if (!src || !*src) {
c56de0967a658c Elise Lennion 2016-10-31 925 dev_warn(&sm750_dev->pdev->dev, "no specific g_option.\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 926 goto NO_PARAM;
81dee67e215b23 Sudip Mukherjee 2015-03-03 927 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 928
0fa96e39279988 Sudip Mukherjee 2015-03-10 929 while ((opt = strsep(&src, ":")) != NULL && *opt != 0) {
c56de0967a658c Elise Lennion 2016-10-31 930 dev_info(&sm750_dev->pdev->dev, "opt=%s\n", opt);
c56de0967a658c Elise Lennion 2016-10-31 931 dev_info(&sm750_dev->pdev->dev, "src=%s\n", src);
81dee67e215b23 Sudip Mukherjee 2015-03-03 932
144634a6b42146 Katie Dunne 2017-02-19 933 if (!strncmp(opt, "swap", strlen("swap"))) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 934 swap = 1;
144634a6b42146 Katie Dunne 2017-02-19 935 } else if (!strncmp(opt, "nocrt", strlen("nocrt"))) {
1757d106a9ce8c Mike Rapoport 2015-10-26 936 sm750_dev->nocrt = 1;
144634a6b42146 Katie Dunne 2017-02-19 937 } else if (!strncmp(opt, "36bit", strlen("36bit"))) {
1757d106a9ce8c Mike Rapoport 2015-10-26 938 sm750_dev->pnltype = sm750_doubleTFT;
144634a6b42146 Katie Dunne 2017-02-19 939 } else if (!strncmp(opt, "18bit", strlen("18bit"))) {
1757d106a9ce8c Mike Rapoport 2015-10-26 940 sm750_dev->pnltype = sm750_dualTFT;
144634a6b42146 Katie Dunne 2017-02-19 941 } else if (!strncmp(opt, "24bit", strlen("24bit"))) {
1757d106a9ce8c Mike Rapoport 2015-10-26 942 sm750_dev->pnltype = sm750_24TFT;
144634a6b42146 Katie Dunne 2017-02-19 943 } else if (!strncmp(opt, "nohwc0", strlen("nohwc0"))) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 944 g_hwcursor &= ~0x1;
144634a6b42146 Katie Dunne 2017-02-19 945 } else if (!strncmp(opt, "nohwc1", strlen("nohwc1"))) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 946 g_hwcursor &= ~0x2;
144634a6b42146 Katie Dunne 2017-02-19 947 } else if (!strncmp(opt, "nohwc", strlen("nohwc"))) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 948 g_hwcursor = 0;
144634a6b42146 Katie Dunne 2017-02-19 949 } else {
81dee67e215b23 Sudip Mukherjee 2015-03-03 950 if (!g_fbmode[0]) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 @951 g_fbmode[0] = opt;
cee9ba1c30d051 Abdul Rauf 2017-01-08 952 dev_info(&sm750_dev->pdev->dev,
cee9ba1c30d051 Abdul Rauf 2017-01-08 953 "find fbmode0 : %s\n", g_fbmode[0]);
81dee67e215b23 Sudip Mukherjee 2015-03-03 954 } else if (!g_fbmode[1]) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 955 g_fbmode[1] = opt;
cee9ba1c30d051 Abdul Rauf 2017-01-08 956 dev_info(&sm750_dev->pdev->dev,
cee9ba1c30d051 Abdul Rauf 2017-01-08 957 "find fbmode1 : %s\n", g_fbmode[1]);
81dee67e215b23 Sudip Mukherjee 2015-03-03 958 } else {
c56de0967a658c Elise Lennion 2016-10-31 959 dev_warn(&sm750_dev->pdev->dev, "How many view you wann set?\n");
81dee67e215b23 Sudip Mukherjee 2015-03-03 960 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 961 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 962 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 963
81dee67e215b23 Sudip Mukherjee 2015-03-03 964 NO_PARAM:
e359b6a863e19f Mike Rapoport 2015-10-26 965 if (sm750_dev->revid != SM750LE_REVISION_ID) {
a3f92cc94c6126 Mike Rapoport 2016-01-17 966 if (sm750_dev->fb_count > 1) {
81dee67e215b23 Sudip Mukherjee 2015-03-03 967 if (swap)
1757d106a9ce8c Mike Rapoport 2015-10-26 968 sm750_dev->dataflow = sm750_dual_swap;
81dee67e215b23 Sudip Mukherjee 2015-03-03 969 else
1757d106a9ce8c Mike Rapoport 2015-10-26 970 sm750_dev->dataflow = sm750_dual_normal;
81dee67e215b23 Sudip Mukherjee 2015-03-03 971 } else {
81dee67e215b23 Sudip Mukherjee 2015-03-03 972 if (swap)
1757d106a9ce8c Mike Rapoport 2015-10-26 973 sm750_dev->dataflow = sm750_simul_sec;
81dee67e215b23 Sudip Mukherjee 2015-03-03 974 else
1757d106a9ce8c Mike Rapoport 2015-10-26 975 sm750_dev->dataflow = sm750_simul_pri;
81dee67e215b23 Sudip Mukherjee 2015-03-03 976 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 977 } else {
81dee67e215b23 Sudip Mukherjee 2015-03-03 978 /* SM750LE only have one crt channel */
1757d106a9ce8c Mike Rapoport 2015-10-26 979 sm750_dev->dataflow = sm750_simul_sec;
81dee67e215b23 Sudip Mukherjee 2015-03-03 980 /* sm750le do not have complex attributes */
1757d106a9ce8c Mike Rapoport 2015-10-26 981 sm750_dev->nocrt = 0;
81dee67e215b23 Sudip Mukherjee 2015-03-03 982 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 983 }
81dee67e215b23 Sudip Mukherjee 2015-03-03 984
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 4+ messages in thread