From: Greg KH <gregkh@linuxfoundation.org>
To: Madhur Kumar <madhurkumar004@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Replace architecture-specific defines with CONFIG_X86
Date: Thu, 20 Mar 2025 07:12:49 -0700 [thread overview]
Message-ID: <2025032040-yesterday-maturity-2f21@gregkh> (raw)
In-Reply-To: <20250222193242.14302-1-madhurkumar004@gmail.com>
On Sun, Feb 23, 2025 at 01:02:42AM +0530, Madhur Kumar wrote:
> Replace the use of __i386__ and __x86_64__ with CONFIG_X86 to adhere to
> kernel coding guideline, make the code more portable and integrates
> better with the Kconfig system.
>
> Signed-off-by: Madhur Kumar <madhurkumar004@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_chip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c
> index 02860d3ec..67a2f6044 100644
> --- a/drivers/staging/sm750fb/ddk750_chip.c
> +++ b/drivers/staging/sm750fb/ddk750_chip.c
> @@ -229,7 +229,7 @@ int ddk750_init_hw(struct initchip_param *p_init_param)
> reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);
> poke32(VGA_CONFIGURATION, reg);
> } else {
> -#if defined(__i386__) || defined(__x86_64__)
> +#ifdef CONFIG_X86
> /* set graphic mode via IO method */
> outb_p(0x88, 0x3d4);
> outb_p(0x06, 0x3d5);
> --
> 2.48.1
>
>
Does not apply to my tree at all :(
prev parent reply other threads:[~2025-03-20 14:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-22 19:32 [PATCH] staging: sm750fb: Replace architecture-specific defines with CONFIG_X86 Madhur Kumar
2025-03-20 14:12 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025032040-yesterday-maturity-2f21@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=madhurkumar004@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).