From: Greg KH <gregkh@linuxfoundation.org>
To: Richard Akintola <princerichard17a@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, julia.lawall@inria.fr
Subject: Re: [PATCH] staging: sm750fb: modify function name to kernel code style
Date: Thu, 3 Apr 2025 15:16:47 +0100 [thread overview]
Message-ID: <2025040301-tightness-giveaway-a568@gregkh> (raw)
In-Reply-To: <67ea5813.5d0a0220.293276.775e@mx.google.com>
On Mon, Mar 31, 2025 at 09:53:36AM +0100, Richard Akintola wrote:
> Change camelCase function name sii164ResetChip to sii164_reset_chip
> as reported by checkpatch.pl
>
> CHECK: Avoid camelCase: <sii164ResetChip>
>
> Signed-off-by: Richard Akintola <princerichard17a@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_dvi.c | 2 +-
> drivers/staging/sm750fb/ddk750_sii164.c | 4 ++--
> drivers/staging/sm750fb/ddk750_sii164.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
You sent 2 different patches with different subject lines, yet they
almost did the same thing? Which one should I take or review? Please
send a new one, as a version 3, and properly document what changed
between this one and the last 2 submissions.
thanks,
greg k-h
next prev parent reply other threads:[~2025-04-03 14:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-31 8:53 [PATCH] staging: sm750fb: modify function name to kernel code style Richard Akintola
2025-04-03 14:16 ` Greg KH [this message]
2025-04-03 22:37 ` Richard Akintola
2025-04-04 6:21 ` Greg KH
2025-04-04 7:36 ` Richard Akintola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025040301-tightness-giveaway-a568@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=princerichard17a@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).