* [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue.
@ 2025-05-07 14:31 Rujra Bhatt
2025-05-07 14:37 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Rujra Bhatt @ 2025-05-07 14:31 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel
instead of "parm" structure variable, used "param" to ease the readability.
Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
---
drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
index 3b25892af713..8f2708632c88 100644
--- a/drivers/staging/sm750fb/ddk750_mode.c
+++ b/drivers/staging/sm750fb/ddk750_mode.c
@@ -203,19 +203,19 @@ static void program_mode_registers(struct mode_parameter *mode_param,
}
}
-int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)
+int ddk750_set_mode_timing(struct mode_parameter *param, enum clock_type clock)
{
struct pll_value pll;
pll.input_freq = DEFAULT_INPUT_CLOCK;
pll.clock_type = clock;
- sm750_calc_pll_value(parm->pixel_clock, &pll);
+ sm750_calc_pll_value(param->pixel_clock, &pll);
if (sm750_get_chip_type() == SM750LE) {
/* set graphic mode via IO method */
outb_p(0x88, 0x3d4);
outb_p(0x06, 0x3d5);
}
- program_mode_registers(parm, &pll);
+ program_mode_registers(param, &pll);
return 0;
}
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue.
2025-05-07 14:31 [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue Rujra Bhatt
@ 2025-05-07 14:37 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2025-05-07 14:37 UTC (permalink / raw)
To: Rujra Bhatt
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
On Wed, May 07, 2025 at 08:01:26PM +0530, Rujra Bhatt wrote:
> instead of "parm" structure variable, used "param" to ease the readability.
>
> Signed-off-by: Rujra Bhatt <braker.noob.kernel@gmail.com>
> ---
> drivers/staging/sm750fb/ddk750_mode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_mode.c b/drivers/staging/sm750fb/ddk750_mode.c
> index 3b25892af713..8f2708632c88 100644
> --- a/drivers/staging/sm750fb/ddk750_mode.c
> +++ b/drivers/staging/sm750fb/ddk750_mode.c
> @@ -203,19 +203,19 @@ static void program_mode_registers(struct mode_parameter *mode_param,
> }
> }
>
> -int ddk750_set_mode_timing(struct mode_parameter *parm, enum clock_type clock)
> +int ddk750_set_mode_timing(struct mode_parameter *param, enum clock_type clock)
> {
> struct pll_value pll;
>
> pll.input_freq = DEFAULT_INPUT_CLOCK;
> pll.clock_type = clock;
>
> - sm750_calc_pll_value(parm->pixel_clock, &pll);
> + sm750_calc_pll_value(param->pixel_clock, &pll);
> if (sm750_get_chip_type() == SM750LE) {
> /* set graphic mode via IO method */
> outb_p(0x88, 0x3d4);
> outb_p(0x06, 0x3d5);
> }
> - program_mode_registers(parm, &pll);
> + program_mode_registers(param, &pll);
This change is really not needed at all, sorry. Adding one character
doesn't make it easier to understand in my opinion.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-05-07 14:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-07 14:31 [FIRST-PATCH] staging : sm750fb : ddk750_mode.c fixed codespell issue Rujra Bhatt
2025-05-07 14:37 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).