linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, soci@c64.rulez.org, simona@ffwll.ch,
	linux@armlinux.org.uk, FlorianSchandinat@gmx.de,
	alchark@gmail.com, krzk@kernel.org
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 12/14] fbdev/sisfb: Unexport symbols
Date: Thu, 12 Jun 2025 10:16:35 +0200	[thread overview]
Message-ID: <20250612081738.197826-13-tzimmermann@suse.de> (raw)
In-Reply-To: <20250612081738.197826-1-tzimmermann@suse.de>

Fix the compile-time warning

  drivers/video/fbdev/sis/sis_main.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

The affected symbols are not used outside of their module. Some of
the symbols are not used anywhere, so remove the functions entirely.
Also remove the related, but unused, define SISFB_HAVE_MALLOC_NEW.

v2:
- remove unused functions (Helge)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/sis/sis.h      |  2 --
 drivers/video/fbdev/sis/sis_main.c | 25 -------------------------
 include/video/sisfb.h              |  6 ------
 3 files changed, 33 deletions(-)

diff --git a/drivers/video/fbdev/sis/sis.h b/drivers/video/fbdev/sis/sis.h
index d632f096083b..3d658482c69d 100644
--- a/drivers/video/fbdev/sis/sis.h
+++ b/drivers/video/fbdev/sis/sis.h
@@ -673,9 +673,7 @@ unsigned int	sisfb_read_mio_pci_word(struct SiS_Private *SiS_Pr, int reg);
 
 /* SiS-specific exported functions */
 void			sis_malloc(struct sis_memreq *req);
-void			sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req);
 void			sis_free(u32 base);
-void			sis_free_new(struct pci_dev *pdev, u32 base);
 
 /* Routines from init.c/init301.c */
 extern unsigned short	SiS_GetModeID_LCD(int VGAEngine, unsigned int VBFlags, int HDisplay,
diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c
index 75033e6be15a..84567d67f71d 100644
--- a/drivers/video/fbdev/sis/sis_main.c
+++ b/drivers/video/fbdev/sis/sis_main.c
@@ -3421,14 +3421,6 @@ sis_malloc(struct sis_memreq *req)
 		req->offset = req->size = 0;
 }
 
-void
-sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req)
-{
-	struct sis_video_info *ivideo = pci_get_drvdata(pdev);
-
-	sis_int_malloc(ivideo, req);
-}
-
 /* sis_free: u32 because "base" is offset inside video ram, can never be >4GB */
 
 static void
@@ -3455,14 +3447,6 @@ sis_free(u32 base)
 	sis_int_free(ivideo, base);
 }
 
-void
-sis_free_new(struct pci_dev *pdev, u32 base)
-{
-	struct sis_video_info *ivideo = pci_get_drvdata(pdev);
-
-	sis_int_free(ivideo, base);
-}
-
 /* --------------------- SetMode routines ------------------------- */
 
 static void
@@ -6832,12 +6816,3 @@ MODULE_PARM_DESC(videoram,
 #endif
 
 #endif 	   /*  /MODULE  */
-
-/* _GPL only for new symbols. */
-EXPORT_SYMBOL(sis_malloc);
-EXPORT_SYMBOL(sis_free);
-EXPORT_SYMBOL_GPL(sis_malloc_new);
-EXPORT_SYMBOL_GPL(sis_free_new);
-
-
-
diff --git a/include/video/sisfb.h b/include/video/sisfb.h
index 76ff628a1220..54e6632cd4a2 100644
--- a/include/video/sisfb.h
+++ b/include/video/sisfb.h
@@ -15,10 +15,4 @@
 #define	SIS_300_VGA  1
 #define	SIS_315_VGA  2
 
-#define SISFB_HAVE_MALLOC_NEW
-extern void sis_malloc(struct sis_memreq *req);
-extern void sis_malloc_new(struct pci_dev *pdev, struct sis_memreq *req);
-
-extern void sis_free(u32 base);
-extern void sis_free_new(struct pci_dev *pdev, u32 base);
 #endif
-- 
2.49.0


  parent reply	other threads:[~2025-06-12  8:22 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  8:16 [PATCH v2 00/14] fbdev: Fix warnings related to including <linux/export.h> Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 01/14] fbdev: Remove trailing whitespaces Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 02/14] fbdev: Include <linux/export.h> Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 03/14] fbdev/c2p: " Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 04/14] fbdev/cyber2000fb: Unexport symbols Thomas Zimmermann
2025-06-12 21:19   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 05/14] fbdev/matroxfb: Remove trailing whitespaces Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 06/14] fbdev/matroxfb: Include <linux/export.h> Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 07/14] fbdev/omap: " Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 08/14] fbdev/omap2: " Thomas Zimmermann
2025-06-12 21:21   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 09/14] fbdev/omap2: Do not include <linux/export.h> Thomas Zimmermann
2025-06-12 21:22   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 10/14] fbdev/mb862xx: " Thomas Zimmermann
2025-06-12 21:23   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 11/14] fbdev/pxafb: Unexport symbol Thomas Zimmermann
2025-06-12 21:24   ` Helge Deller
2025-06-12  8:16 ` Thomas Zimmermann [this message]
2025-06-12 21:25   ` [PATCH v2 12/14] fbdev/sisfb: Unexport symbols Helge Deller
2025-06-12  8:16 ` [PATCH v2 13/14] fbdev/viafb: Include <linux/export.h> Thomas Zimmermann
2025-06-12 21:26   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 14/14] fbdev/viafb: Do not include <linux/export.h> Thomas Zimmermann
2025-06-12 21:29   ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250612081738.197826-13-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=FlorianSchandinat@gmx.de \
    --cc=alchark@gmail.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=simona@ffwll.ch \
    --cc=soci@c64.rulez.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).