linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: deller@gmx.de, soci@c64.rulez.org, simona@ffwll.ch,
	linux@armlinux.org.uk, FlorianSchandinat@gmx.de,
	alchark@gmail.com, krzk@kernel.org
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v2 04/14] fbdev/cyber2000fb: Unexport symbols
Date: Thu, 12 Jun 2025 10:16:27 +0200	[thread overview]
Message-ID: <20250612081738.197826-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20250612081738.197826-1-tzimmermann@suse.de>

Fix the compile-time warning

  drivers/video/fbdev/cyber2000fb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

The affected symbols are not used anywhere, so remove the functions
entirely.

v2:
- remove unused functions (Helge)

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/cyber2000fb.c | 36 -------------------------------
 drivers/video/fbdev/cyber2000fb.h |  2 --
 2 files changed, 38 deletions(-)

diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
index 986760b90465..5cb5ee517f81 100644
--- a/drivers/video/fbdev/cyber2000fb.c
+++ b/drivers/video/fbdev/cyber2000fb.c
@@ -1089,7 +1089,6 @@ void cyber2000fb_enable_extregs(struct cfb_info *cfb)
 		cyber2000_grphw(EXT_FUNC_CTL, old, cfb);
 	}
 }
-EXPORT_SYMBOL(cyber2000fb_enable_extregs);
 
 /*
  * Disable access to the extended registers
@@ -1109,41 +1108,6 @@ void cyber2000fb_disable_extregs(struct cfb_info *cfb)
 	else
 		cfb->func_use_count -= 1;
 }
-EXPORT_SYMBOL(cyber2000fb_disable_extregs);
-
-/*
- * Attach a capture/tv driver to the core CyberX0X0 driver.
- */
-int cyber2000fb_attach(struct cyberpro_info *info, int idx)
-{
-	if (int_cfb_info != NULL) {
-		info->dev	      = int_cfb_info->fb.device;
-#ifdef CONFIG_FB_CYBER2000_I2C
-		info->i2c	      = &int_cfb_info->i2c_adapter;
-#else
-		info->i2c	      = NULL;
-#endif
-		info->regs	      = int_cfb_info->regs;
-		info->irq             = int_cfb_info->irq;
-		info->fb	      = int_cfb_info->fb.screen_base;
-		info->fb_size	      = int_cfb_info->fb.fix.smem_len;
-		info->info	      = int_cfb_info;
-
-		strscpy(info->dev_name, int_cfb_info->fb.fix.id,
-			sizeof(info->dev_name));
-	}
-
-	return int_cfb_info != NULL;
-}
-EXPORT_SYMBOL(cyber2000fb_attach);
-
-/*
- * Detach a capture/tv driver from the core CyberX0X0 driver.
- */
-void cyber2000fb_detach(int idx)
-{
-}
-EXPORT_SYMBOL(cyber2000fb_detach);
 
 #ifdef CONFIG_FB_CYBER2000_DDC
 
diff --git a/drivers/video/fbdev/cyber2000fb.h b/drivers/video/fbdev/cyber2000fb.h
index 04641aa13acc..21095df8fdb0 100644
--- a/drivers/video/fbdev/cyber2000fb.h
+++ b/drivers/video/fbdev/cyber2000fb.h
@@ -488,7 +488,5 @@ struct cyberpro_info {
  * Note! Writing to the Cyber20x0 registers from an interrupt
  * routine is definitely a bad idea atm.
  */
-int cyber2000fb_attach(struct cyberpro_info *info, int idx);
-void cyber2000fb_detach(int idx);
 void cyber2000fb_enable_extregs(struct cfb_info *cfb);
 void cyber2000fb_disable_extregs(struct cfb_info *cfb);
-- 
2.49.0


  parent reply	other threads:[~2025-06-12  8:21 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  8:16 [PATCH v2 00/14] fbdev: Fix warnings related to including <linux/export.h> Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 01/14] fbdev: Remove trailing whitespaces Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 02/14] fbdev: Include <linux/export.h> Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 03/14] fbdev/c2p: " Thomas Zimmermann
2025-06-12  8:16 ` Thomas Zimmermann [this message]
2025-06-12 21:19   ` [PATCH v2 04/14] fbdev/cyber2000fb: Unexport symbols Helge Deller
2025-06-12  8:16 ` [PATCH v2 05/14] fbdev/matroxfb: Remove trailing whitespaces Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 06/14] fbdev/matroxfb: Include <linux/export.h> Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 07/14] fbdev/omap: " Thomas Zimmermann
2025-06-12  8:16 ` [PATCH v2 08/14] fbdev/omap2: " Thomas Zimmermann
2025-06-12 21:21   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 09/14] fbdev/omap2: Do not include <linux/export.h> Thomas Zimmermann
2025-06-12 21:22   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 10/14] fbdev/mb862xx: " Thomas Zimmermann
2025-06-12 21:23   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 11/14] fbdev/pxafb: Unexport symbol Thomas Zimmermann
2025-06-12 21:24   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 12/14] fbdev/sisfb: Unexport symbols Thomas Zimmermann
2025-06-12 21:25   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 13/14] fbdev/viafb: Include <linux/export.h> Thomas Zimmermann
2025-06-12 21:26   ` Helge Deller
2025-06-12  8:16 ` [PATCH v2 14/14] fbdev/viafb: Do not include <linux/export.h> Thomas Zimmermann
2025-06-12 21:29   ` Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250612081738.197826-5-tzimmermann@suse.de \
    --to=tzimmermann@suse.de \
    --cc=FlorianSchandinat@gmx.de \
    --cc=alchark@gmail.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=simona@ffwll.ch \
    --cc=soci@c64.rulez.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).