From: Greg KH <gregkh@linuxfoundation.org>
To: Eric Florin <ericflorin@google.com>
Cc: teddy.wang@siliconmotion.com, sudipm.mukherjee@gmail.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/6] staging: sm750fb: Rename local var `nDirection`
Date: Thu, 19 Jun 2025 17:30:25 +0200 [thread overview]
Message-ID: <2025061916-overcoat-deduce-5a62@gregkh> (raw)
In-Reply-To: <f247ceee80387ece536aa5657f105321809470f1.1748365488.git.ericflorin@google.com>
On Tue, May 27, 2025 at 10:11:28AM -0700, Eric Florin wrote:
> Rename local variable `nDirection` to `n_direction` in
> `sm750_hw_copyarea` to conform with kernel style guidelines as reported
> by checkpatch.pl
>
> CHECK: Avoid CamelCase: <nDirection>
>
> Signed-off-by: Eric Florin <ericflorin@google.com>
> ---
> drivers/staging/sm750fb/sm750_accel.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
> index a34d8f6a033d..b9f90c934b7d 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -153,9 +153,9 @@ int sm750_hw_copyarea(struct lynx_accel *accel,
> unsigned int width, unsigned int height,
> unsigned int rop2)
> {
> - unsigned int nDirection, de_ctrl;
> + unsigned int n_direction, de_ctrl;
Why keep the "n" at all?
prev parent reply other threads:[~2025-06-19 15:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 17:11 [PATCH 0/6] staging: sm750fb: cleanup `sm750_hw_copyarea` Eric Florin
2025-05-27 17:11 ` [PATCH 1/6] staging: sm750fb: rename `sBase` parameter Eric Florin
2025-06-19 15:29 ` Greg KH
2025-05-27 17:11 ` [PATCH 2/6] staging: sm750fb: rename `sPitch` parameter Eric Florin
2025-06-19 15:29 ` Greg KH
2025-05-27 17:11 ` [PATCH 3/6] staging: sm750fb: rename `dBase` parameter Eric Florin
2025-06-19 15:30 ` Greg KH
2025-05-27 17:11 ` [PATCH 4/6] staging: sm750fb: rename `dPitch` parameter Eric Florin
2025-06-19 15:29 ` Greg KH
2025-05-27 17:11 ` [PATCH 5/6] staging: sm750fb: rename `Bpp` parameter Eric Florin
2025-06-19 15:30 ` Greg KH
2025-05-27 17:11 ` [PATCH 6/6] staging: sm750fb: Rename local var `nDirection` Eric Florin
2025-06-19 15:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025061916-overcoat-deduce-5a62@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ericflorin@google.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).