From: Greg KH <gregkh@linuxfoundation.org>
To: chalianis1@gmail.com
Cc: andy@kernel.org, linux-staging@lists.linux.dev,
linux-fbdev@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] staging: fbtft: add support for a device tree of backlight.
Date: Sat, 26 Jul 2025 08:31:09 +0200 [thread overview]
Message-ID: <2025072640-consonant-flashcard-1805@gregkh> (raw)
In-Reply-To: <20250726000416.23960-1-chalianis1@gmail.com>
On Fri, Jul 25, 2025 at 08:04:16PM -0400, chalianis1@gmail.com wrote:
> From: Chali Anis <chalianis1@gmail.com>
>
> Support the of backlight from device tree and keep compatibility
> for the legacy gpio backlight.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Chali Anis <chalianis1@gmail.com>
> ---
> drivers/staging/fbtft/fbtft-core.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c
> index da9c64152a60..5f0220dbe397 100644
> --- a/drivers/staging/fbtft/fbtft-core.c
> +++ b/drivers/staging/fbtft/fbtft-core.c
> @@ -170,6 +170,18 @@ void fbtft_register_backlight(struct fbtft_par *par)
> struct backlight_device *bd;
> struct backlight_properties bl_props = { 0, };
>
> + bd = devm_of_find_backlight(par->info->device);
> + if (IS_ERR(bd)) {
> + dev_warn(par->info->device,
> + "cannot find of backlight device (%ld), trying legacy\n",
> + PTR_ERR(bd));
So now you are going to get a warning message for a system that
previously did not at all? That's not very nice to those users :(
prev parent reply other threads:[~2025-07-26 6:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-26 0:04 [PATCH] staging: fbtft: add support for a device tree of backlight chalianis1
2025-07-26 6:31 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025072640-consonant-flashcard-1805@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy@kernel.org \
--cc=chalianis1@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).