From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A3ECA26E17A; Tue, 19 Aug 2025 19:50:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755633011; cv=none; b=a5DTlnRZdm7AS0SmvJwxk+vdTg6r29gG88JvO9G9ulD0346LjhOTCfLQYk8YaWLycKPledorrZ/eWPTlf0Fxm+tHQVaY86YPy7zWFJGmpiZ7wIRfbozEA8TzTqb1aF9R3rdJcUsKLSv6eb41jnkamh9kPfGEUbO9gjLd2fpag9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755633011; c=relaxed/simple; bh=rXxbSd4NGFsxG7Du96tt0eWEUIA3BJVgGFwkWbEkdlI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=KO1QRVUODhOBgEfSJ+RgAOXERHDEplTpVSjinBNhlsRkZeQN/tVrQb3794dfp6q+xburA5mKFKIH9mWeqsExSghzhIJS1oTWDEBplZwEJSSMshkZ7QU/H1BKd4Wb9/pcVNB2LGOga/QBPDoQlUyXw0iMzral1eczYHzu8OrVQco= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=hbSR4YNA; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hbSR4YNA" Received: by smtp.kernel.org (Postfix) with ESMTPSA id DEF38C4CEF1; Tue, 19 Aug 2025 19:50:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1755633009; bh=rXxbSd4NGFsxG7Du96tt0eWEUIA3BJVgGFwkWbEkdlI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hbSR4YNABzlsy9pJN7WzfYzMVwnfolauDV1rXZvGW1mI57p37MW6oOe/+01+xg9uF zOXCvwuNvXPxm6cWiQ+QwG4+aQ5CfXoZ0i5/CzsnUVt8SMTgpdKuzYChqbu9fZs7FM WQl10SuiBy8dl8BBGcq8xO+lE7sfEYW1Ll9/qOBU7AjSmHPDXQBC/eU36HnOrllsLg 1tWHtEsc0si4gDYUsimTmzNppaCEJ2nBflrXkrQjRUTnlVAgSc5CY+2Sa6hb9i0Dsf GZyAXddObnGMRBLA4YPev/YmuJ+IsW4i9++EooA4pKs4GusYblwazFzCp2/tINsGiy atSDfqecI84Lw== Date: Tue, 19 Aug 2025 14:50:08 -0500 From: Rob Herring To: Maud Spierings Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 1/4] dt-bindings: backlight: Add max25014 bindings Message-ID: <20250819195008.GA1218175-robh@kernel.org> References: <20250819-max25014-v2-0-5fd7aeb141ea@gocontroll.com> <20250819-max25014-v2-1-5fd7aeb141ea@gocontroll.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250819-max25014-v2-1-5fd7aeb141ea@gocontroll.com> On Tue, Aug 19, 2025 at 12:58:59PM +0200, Maud Spierings wrote: > The Maxim MAX25014 is a 4-channel automotive grade backlight driver IC > with intgrated boost controller. > > Signed-off-by: Maud Spierings > --- > .../bindings/leds/backlight/maxim,max25014.yaml | 79 ++++++++++++++++++++++ > MAINTAINERS | 5 ++ > 2 files changed, 84 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml > new file mode 100644 > index 0000000000000000000000000000000000000000..30b591152fa31d5e43243cac44c72028b05b5f8a > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml > @@ -0,0 +1,79 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/leds/backlight/maxim,max25014.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Maxim max25014 backlight controller > + > +maintainers: > + - Maud Spierings > + > +allOf: > + - $ref: common.yaml# > + > +properties: > + compatible: > + enum: > + - maxim,max25014 > + > + reg: > + maxItems: 1 > + > + enable-gpios: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + power-supply: > + description: Regulator which controls the boost converter input rail. > + > + pwms: > + maxItems: 1 > + > + maxim,iset: > + $ref: /schemas/types.yaml#/definitions/uint32 maximum: 15 > + default: 11 > + description: > + Value of the ISET register field (0-15). Perhaps a little on what this controls? > + > + maxim,strings: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: > + A 4-bit bitfield that describes which led strings to turn on. > + minItems: 4 > + maxItems: 4 items: maximum: 1 But why not just an 8-bit value 0x0-0xF? > + > +required: > + - compatible > + - reg > + - maxim,strings > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + backlight: backlight@6f { Drop unused labels. > + reg = <0x6f>; > + compatible = "maxim,max25014"; compatible is always first. > + default-brightness = <50>; > + enable-gpios = <&gpio1 4 GPIO_ACTIVE_HIGH>; > + interrupt-parent = <&gpio1>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_backlight>; Generally we don't put pinctrl properties in examples as they are always allowed. > + power-supply = <®_backlight>; > + pwms = <&pwm1>; > + maxim,iset = <7>; > + maxim,strings = <1 1 1 1>; > + }; > + }; > + > diff --git a/MAINTAINERS b/MAINTAINERS > index e81d5f9fbd16cc384356804390d65652bbb9e3f6..11c73d2e37fac22aea852152746236c1472f41b8 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14972,6 +14972,11 @@ F: Documentation/userspace-api/media/drivers/max2175.rst > F: drivers/media/i2c/max2175* > F: include/uapi/linux/max2175.h > > +MAX25014 BACKLIGHT DRIVER > +M: Maud Spierings > +S: Maintained > +F: Documentation/devicetree/bindings/leds/backlight/maxim,max25014.yaml > + > MAX31335 RTC DRIVER > M: Antoniu Miclaus > L: linux-rtc@vger.kernel.org > > -- > 2.50.1 >