* [PATCH] staging: sm750fb: fix coding style issues in sm750.h
@ 2025-09-08 5:21 Yiming Qian
2025-09-08 5:45 ` Dan Carpenter
0 siblings, 1 reply; 6+ messages in thread
From: Yiming Qian @ 2025-09-08 5:21 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang
Cc: gregkh, linux-fbdev, linux-staging, linux-kernel, Yiming Qian
This patch addresses several coding style warnings
reported by checkpatch.pl:
1. Replaces CamelCase variable names with snake_case:
- dprBase -> dpr_base
- dpPortBase -> dp_port_base
2. Removes unnecessary use of 'volatile' qualifier
from the lynx_share_struct members.
These changes improve code readability and maintain
consistency with the kernel coding style guidelines.
No functional changes are introduced.
Signed-off-by: Yiming Qian <qianym1996@gmail.com>
---
drivers/staging/sm750fb/sm750.h | 6 +++---
drivers/staging/sm750fb/sm750_accel.c | 7 +++----
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index d7f40efe3..fcb7d586e 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -50,9 +50,9 @@ struct init_status {
struct lynx_accel {
/* base virtual address of DPR registers */
- volatile unsigned char __iomem *dprBase;
+ unsigned char __iomem *dpr_base;
/* base virtual address of de data port */
- volatile unsigned char __iomem *dpPortBase;
+ unsigned char __iomem *dp_port_base;
/* function pointers */
void (*de_init)(struct lynx_accel *accel);
@@ -128,7 +128,7 @@ struct lynx_cursor {
char __iomem *vstart;
int offset;
/* mmio addr of hw cursor */
- volatile char __iomem *mmio;
+ char __iomem *mmio;
};
struct lynxfb_crtc {
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 44b9e3fe3..6bee37bf5 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -19,17 +19,17 @@
#include "sm750_accel.h"
static inline void write_dpr(struct lynx_accel *accel, int offset, u32 regValue)
{
- writel(regValue, accel->dprBase + offset);
+ writel(regValue, accel->dpr_base + offset);
}
static inline u32 read_dpr(struct lynx_accel *accel, int offset)
{
- return readl(accel->dprBase + offset);
+ return readl(accel->dpr_base + offset);
}
static inline void write_dpPort(struct lynx_accel *accel, u32 data)
{
- writel(data, accel->dpPortBase);
+ writel(data, accel->dp_port_base);
}
void sm750_hw_de_init(struct lynx_accel *accel)
@@ -410,4 +410,3 @@ int sm750_hw_imageblit(struct lynx_accel *accel, const char *pSrcbuf,
return 0;
}
-
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 7119b67ef..ce46f240c 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -58,8 +58,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
}
pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg);
- sm750_dev->accel.dprBase = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
- sm750_dev->accel.dpPortBase = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
+ sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
+ sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
mmio750 = sm750_dev->pvReg;
sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] staging: sm750fb: fix coding style issues in sm750.h
2025-09-08 5:21 [PATCH] staging: sm750fb: fix coding style issues in sm750.h Yiming Qian
@ 2025-09-08 5:45 ` Dan Carpenter
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2025-09-08 5:45 UTC (permalink / raw)
To: Yiming Qian
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel
On Mon, Sep 08, 2025 at 01:21:33PM +0800, Yiming Qian wrote:
> This patch addresses several coding style warnings
> reported by checkpatch.pl:
>
> 1. Replaces CamelCase variable names with snake_case:
> - dprBase -> dpr_base
> - dpPortBase -> dp_port_base
>
> 2. Removes unnecessary use of 'volatile' qualifier
> from the lynx_share_struct members.
>
> These changes improve code readability and maintain
> consistency with the kernel coding style guidelines.
> No functional changes are introduced.
>
> Signed-off-by: Yiming Qian <qianym1996@gmail.com>
You need to split this into "one thing per patch".
[patch 1] remove volatile
[patch 2] rename snake case variables
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 0/2] fix coding style issues in sm750.h
2025-09-08 5:45 ` Dan Carpenter
@ 2025-09-09 6:01 ` Yiming Qian
2025-09-09 6:01 ` [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers Yiming Qian
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yiming Qian @ 2025-09-09 6:01 UTC (permalink / raw)
To: dan.carpenter
Cc: gregkh, linux-fbdev, linux-kernel, linux-staging, qianym1996,
sudipm.mukherjee, teddy.wang
Fix volatile and camelCase issues in coding style:
changes in v2:
- Split single patch into two separate patches as suggested
Yiming Qian (2):
staging: sm750fb: remove unnecessary volatile qualifiers
staging: sm750fb: rename snake case variables
drivers/staging/sm750fb/sm750.h | 6 +++---
drivers/staging/sm750fb/sm750_accel.c | 6 +++---
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 8 insertions(+), 8 deletions(-)
--
2.51.0
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
@ 2025-09-09 6:01 ` Yiming Qian
2025-09-09 6:01 ` [PATCH v2 2/2] staging: sm750fb: rename snake case variables Yiming Qian
2025-09-09 7:54 ` [PATCH v2 0/2] fix coding style issues in sm750.h Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: Yiming Qian @ 2025-09-09 6:01 UTC (permalink / raw)
To: dan.carpenter
Cc: gregkh, linux-fbdev, linux-kernel, linux-staging, qianym1996,
sudipm.mukherjee, teddy.wang
The use of 'volatile' for memory-mapped I/O pointers is discouraged
in the Linux kernel as per
Documentation/process/volatile-considered-harmful.rst.
This patch removes the unnecessary 'volatile' qualifiers from the
lynx_accel struct members, improving code quality and maintainability.
Signed-off-by: Yiming Qian <qianym1996@gmail.com>
---
drivers/staging/sm750fb/sm750.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index d7f40efe3..41f1fb390 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -50,9 +50,9 @@ struct init_status {
struct lynx_accel {
/* base virtual address of DPR registers */
- volatile unsigned char __iomem *dprBase;
+ unsigned char __iomem *dprBase;
/* base virtual address of de data port */
- volatile unsigned char __iomem *dpPortBase;
+ unsigned char __iomem *dpPortBase;
/* function pointers */
void (*de_init)(struct lynx_accel *accel);
@@ -128,7 +128,7 @@ struct lynx_cursor {
char __iomem *vstart;
int offset;
/* mmio addr of hw cursor */
- volatile char __iomem *mmio;
+ char __iomem *mmio;
};
struct lynxfb_crtc {
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2 2/2] staging: sm750fb: rename snake case variables
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
2025-09-09 6:01 ` [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers Yiming Qian
@ 2025-09-09 6:01 ` Yiming Qian
2025-09-09 7:54 ` [PATCH v2 0/2] fix coding style issues in sm750.h Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: Yiming Qian @ 2025-09-09 6:01 UTC (permalink / raw)
To: dan.carpenter
Cc: gregkh, linux-fbdev, linux-kernel, linux-staging, qianym1996,
sudipm.mukherjee, teddy.wang
Replaces CamelCase variable names with snake_case:
- dprBase -> dpr_base
- dpPortBase -> dp_port_base
Signed-off-by: Yiming Qian <qianym1996@gmail.com>
---
drivers/staging/sm750fb/sm750.h | 4 ++--
drivers/staging/sm750fb/sm750_accel.c | 6 +++---
drivers/staging/sm750fb/sm750_hw.c | 4 ++--
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 41f1fb390..fcb7d586e 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -50,9 +50,9 @@ struct init_status {
struct lynx_accel {
/* base virtual address of DPR registers */
- unsigned char __iomem *dprBase;
+ unsigned char __iomem *dpr_base;
/* base virtual address of de data port */
- unsigned char __iomem *dpPortBase;
+ unsigned char __iomem *dp_port_base;
/* function pointers */
void (*de_init)(struct lynx_accel *accel);
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/staging/sm750fb/sm750_accel.c
index 44b9e3fe3..7ac2e7b6e 100644
--- a/drivers/staging/sm750fb/sm750_accel.c
+++ b/drivers/staging/sm750fb/sm750_accel.c
@@ -19,17 +19,17 @@
#include "sm750_accel.h"
static inline void write_dpr(struct lynx_accel *accel, int offset, u32 regValue)
{
- writel(regValue, accel->dprBase + offset);
+ writel(regValue, accel->dpr_base + offset);
}
static inline u32 read_dpr(struct lynx_accel *accel, int offset)
{
- return readl(accel->dprBase + offset);
+ return readl(accel->dpr_base + offset);
}
static inline void write_dpPort(struct lynx_accel *accel, u32 data)
{
- writel(data, accel->dpPortBase);
+ writel(data, accel->dp_port_base);
}
void sm750_hw_de_init(struct lynx_accel *accel)
diff --git a/drivers/staging/sm750fb/sm750_hw.c b/drivers/staging/sm750fb/sm750_hw.c
index 7119b67ef..ce46f240c 100644
--- a/drivers/staging/sm750fb/sm750_hw.c
+++ b/drivers/staging/sm750fb/sm750_hw.c
@@ -58,8 +58,8 @@ int hw_sm750_map(struct sm750_dev *sm750_dev, struct pci_dev *pdev)
}
pr_info("mmio virtual addr = %p\n", sm750_dev->pvReg);
- sm750_dev->accel.dprBase = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
- sm750_dev->accel.dpPortBase = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
+ sm750_dev->accel.dpr_base = sm750_dev->pvReg + DE_BASE_ADDR_TYPE1;
+ sm750_dev->accel.dp_port_base = sm750_dev->pvReg + DE_PORT_ADDR_TYPE1;
mmio750 = sm750_dev->pvReg;
sm750_set_chip_type(sm750_dev->devid, sm750_dev->revid);
--
2.51.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2 0/2] fix coding style issues in sm750.h
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
2025-09-09 6:01 ` [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers Yiming Qian
2025-09-09 6:01 ` [PATCH v2 2/2] staging: sm750fb: rename snake case variables Yiming Qian
@ 2025-09-09 7:54 ` Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2025-09-09 7:54 UTC (permalink / raw)
To: Yiming Qian
Cc: gregkh, linux-fbdev, linux-kernel, linux-staging,
sudipm.mukherjee, teddy.wang
On Tue, Sep 09, 2025 at 02:01:28PM +0800, Yiming Qian wrote:
> Fix volatile and camelCase issues in coding style:
>
> changes in v2:
> - Split single patch into two separate patches as suggested
>
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-09-09 7:54 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-08 5:21 [PATCH] staging: sm750fb: fix coding style issues in sm750.h Yiming Qian
2025-09-08 5:45 ` Dan Carpenter
2025-09-09 6:01 ` [PATCH v2 0/2] " Yiming Qian
2025-09-09 6:01 ` [PATCH v2 1/2] staging: sm750fb: remove unnecessary volatile qualifiers Yiming Qian
2025-09-09 6:01 ` [PATCH v2 2/2] staging: sm750fb: rename snake case variables Yiming Qian
2025-09-09 7:54 ` [PATCH v2 0/2] fix coding style issues in sm750.h Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).