linux-fbdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shi Hao <i.shihao.999@gmail.com>
To: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, deller@gmx.de,
	adaplas@gmail.com, Shi Hao <i.shihao.999@gmail.com>
Subject: [RFC PATCH] fdev: i810: use appropriate log interface pr_info
Date: Wed, 15 Oct 2025 19:38:45 +0530	[thread overview]
Message-ID: <20251015140845.31671-1-i.shihao.999@gmail.com> (raw)

use appropriate logging interface pr_info instead of printk
without KERN_INFO with it. It could be updated with proper
logging interfaces.

Legacy printk() calls in the i810 fbdev driver can be replaced
with the standard kernel logging interface pr_info() which will
help to allow proper log level handling, making messages easier
to filter and manage.

No functional changes to the driver behavior are introduced.
Only the logging method has been updated to follow modern
kernel coding guidelines.

Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
---
 drivers/video/fbdev/i810/i810_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index d73a795fe1be..8c4b9eae151d 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -2137,7 +2137,7 @@ static void i810fb_remove_pci(struct pci_dev *dev)

 	unregister_framebuffer(info);
 	i810fb_release_resource(info, par);
-	printk("cleanup_module:  unloaded i810 framebuffer device\n");
+	pr_info("cleanup_module: unloaded i810 framebuffer device\n");
 }

 #ifndef MODULE
--
2.51.0


             reply	other threads:[~2025-10-15 14:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-15 14:08 Shi Hao [this message]
2025-10-30 18:13 ` [RFC PATCH] fdev: i810: use appropriate log interface pr_info Helge Deller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251015140845.31671-1-i.shihao.999@gmail.com \
    --to=i.shihao.999@gmail.com \
    --cc=adaplas@gmail.com \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).