[RFC PATCH] fdev: i810: use appropriate log interface pr_info

[RFC PATCH] fdev: i810: use appropriate log interface pr_info

[Shi Hao]

use appropriate logging interface pr_info instead of printk
without KERN_INFO with it. It could be updated with proper
logging interfaces.

Legacy printk() calls in the i810 fbdev driver can be replaced
with the standard kernel logging interface pr_info() which will
help to allow proper log level handling, making messages easier
to filter and manage.

No functional changes to the driver behavior are introduced.
Only the logging method has been updated to follow modern
kernel coding guidelines.

Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
---
 drivers/video/fbdev/i810/i810_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index d73a795fe1be..8c4b9eae151d 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -2137,7 +2137,7 @@ static void i810fb_remove_pci(struct pci_dev *dev)

 	unregister_framebuffer(info);
 	i810fb_release_resource(info, par);
-	printk("cleanup_module:  unloaded i810 framebuffer device\n");
+	pr_info("cleanup_module: unloaded i810 framebuffer device\n");
 }

 #ifndef MODULE
--
2.51.0

Re: [RFC PATCH] fdev: i810: use appropriate log interface pr_info

[Helge Deller]

On 10/15/25 16:08, Shi Hao wrote:
> use appropriate logging interface pr_info instead of printk
> without KERN_INFO with it. It could be updated with proper
> logging interfaces.
> 
> Legacy printk() calls in the i810 fbdev driver can be replaced
> with the standard kernel logging interface pr_info() which will
> help to allow proper log level handling, making messages easier
> to filter and manage.
> 
> No functional changes to the driver behavior are introduced.
> Only the logging method has been updated to follow modern
> kernel coding guidelines.
> 
> Signed-off-by: Shi Hao <i.shihao.999@gmail.com>
> ---
>   drivers/video/fbdev/i810/i810_main.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
> index d73a795fe1be..8c4b9eae151d 100644
> --- a/drivers/video/fbdev/i810/i810_main.c
> +++ b/drivers/video/fbdev/i810/i810_main.c
> @@ -2137,7 +2137,7 @@ static void i810fb_remove_pci(struct pci_dev *dev)
> 
>   	unregister_framebuffer(info);
>   	i810fb_release_resource(info, par);
> -	printk("cleanup_module:  unloaded i810 framebuffer device\n");
> +	pr_info("cleanup_module: unloaded i810 framebuffer device\n");

Thanks for your patch!
It's possible to change it like this, but I wonder:
Why did you choose to change that specific line?
What about the other printk() in this file ?
Ideally we then should use dev_info() or dev_warn() [...] instead.
and most important:
There is no actual reason to change it. Usually we touch such lines
and clean then up when we anyway change code in this area.

So, your patch is appreciated, but I'm a little hesitant to take it
(although it's basically correct!).

Helge