From: Greg KH <gregkh@linuxfoundation.org>
To: Cristian Del Gobbo <cristiandelgobbo87@gmail.com>
Cc: sudip.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH v2] staging: sm750fb: style fixes: align call and split chained assignment
Date: Wed, 29 Oct 2025 11:16:32 +0100 [thread overview]
Message-ID: <2025102946-thickness-audacious-5c22@gregkh> (raw)
In-Reply-To: <20251029021449.5420-1-cristiandelgobbo87@gmail.com>
On Wed, Oct 29, 2025 at 03:14:49AM +0100, Cristian Del Gobbo wrote:
> - Drop previous change that made g_fbmode[] elements const (broke build).
> - Align the continued arguments of sm750_hw_cursor_set_size() with the
> opening parenthesis.
> - Replace a chained assignment of red/green/blue with a temporary
> variable to satisfy checkpatch and improve readability.
>
> No functional change intended.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Signed-off-by: Cristian Del Gobbo <cristiandelgobbo87@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
On top of what Dan said, I see 4 different copies of this patch in my
inbox, which one is the correct one? Please make it easy for
maintainers to know what patch to review, we get 1000+ emails a day to
deal with and have no short term memory :)
thanks,
greg k-h
next prev parent reply other threads:[~2025-10-29 10:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-29 2:14 [PATCH v2] staging: sm750fb: style fixes: align call and split chained assignment Cristian Del Gobbo
2025-10-29 10:16 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-10-29 2:17 Cristian Del Gobbo
2025-10-29 2:20 Cristian Del Gobbo
2025-10-29 12:49 ` kernel test robot
2025-10-29 15:46 ` kernel test robot
2025-10-29 2:21 Cristian Del Gobbo
2025-10-29 5:29 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025102946-thickness-audacious-5c22@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=cristiandelgobbo87@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudip.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).