From: Javier Garcia <rampxxxx@gmail.com>
To: deller@gmx.de
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, shuah@kernel.org,
Javier Garcia <rampxxxx@gmail.com>
Subject: [PATCH v3] fbdev: vga16fb: Request memory region.
Date: Sat, 8 Nov 2025 10:33:48 +0100 [thread overview]
Message-ID: <20251108093348.2842180-1-rampxxxx@gmail.com> (raw)
In-Reply-To: <f9998d60-e532-48ae-8e03-d867cc0ec847@gmx.de>
This patch reserve and release VGA memory region.
This align with Documentation/drm/todo.rst
"Request memory regions in all fbdev drivers"
I've tested with 32bits kernel and qemu.
Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
---
v1 -> v3:
* Add space after comma.
* v2 https://lore.kernel.org/lkml/20251028191615.2765711-1-rampxxxx@gmail.com/
v1 -> v2:
* Add release in vga16fb_remove , thanks Helge Deller.
* v1 https://lore.kernel.org/lkml/20251016171845.1397153-1-rampxxxx@gmail.com/
drivers/video/fbdev/vga16fb.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/video/fbdev/vga16fb.c b/drivers/video/fbdev/vga16fb.c
index eedab14c7d51..3b4c50d98ba6 100644
--- a/drivers/video/fbdev/vga16fb.c
+++ b/drivers/video/fbdev/vga16fb.c
@@ -1319,6 +1319,11 @@ static int vga16fb_probe(struct platform_device *dev)
if (ret)
return ret;
+ if (!request_mem_region(vga16fb_fix.smem_start, vga16fb_fix.smem_len,
+ "vga16b")) {
+ dev_err(&dev->dev, "vga16b: cannot reserve video memory at 0x%lx\n",
+ vga16fb_fix.smem_start);
+ }
printk(KERN_DEBUG "vga16fb: initializing\n");
info = framebuffer_alloc(sizeof(struct vga16fb_par), &dev->dev);
@@ -1398,6 +1403,8 @@ static int vga16fb_probe(struct platform_device *dev)
err_ioremap:
framebuffer_release(info);
err_fb_alloc:
+ release_mem_region(vga16fb_fix.smem_start,
+ vga16fb_fix.smem_len);
return ret;
}
@@ -1407,6 +1414,8 @@ static void vga16fb_remove(struct platform_device *dev)
if (info)
unregister_framebuffer(info);
+ release_mem_region(vga16fb_fix.smem_start,
+ vga16fb_fix.smem_len);
}
static const struct platform_device_id vga16fb_driver_id_table[] = {
--
2.50.1
next prev parent reply other threads:[~2025-11-08 9:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 17:18 [PATCH] fbdev: vga16fb: Request memory region Javier Garcia
2025-10-27 18:02 ` Javier Garcia
2025-10-27 20:07 ` Helge Deller
2025-10-28 19:16 ` [PATCH v2] " Javier Garcia
2025-10-28 21:09 ` Helge Deller
2025-11-08 9:33 ` Javier Garcia [this message]
2025-11-15 7:31 ` [PATCH v3] " Javier Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251108093348.2842180-1-rampxxxx@gmail.com \
--to=rampxxxx@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).