From: Javier Garcia <rampxxxx@gmail.com>
To: deller@gmx.de
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, shuah@kernel.org,
Javier Garcia <rampxxxx@gmail.com>
Subject: [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover.
Date: Mon, 10 Nov 2025 17:52:14 +0100 [thread overview]
Message-ID: <20251110165214.3076586-1-rampxxxx@gmail.com> (raw)
I coundn't test as not have that hw but cross compiled to check the code
change.
Fixes: a3d899839064 ("[PATCH] Fbdev driver for IBM GXT4500P videocards")
Signed-off-by: Javier Garcia <rampxxxx@gmail.com>
---
drivers/video/fbdev/gxt4500.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c
index 15a82c6b609e..27a46e364419 100644
--- a/drivers/video/fbdev/gxt4500.c
+++ b/drivers/video/fbdev/gxt4500.c
@@ -704,7 +704,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
}
info->var = var;
if (gxt4500_set_par(info)) {
- printk(KERN_ERR "gxt4500: cannot set video mode\n");
+ dev_err(&pdev->dev, "gxt4500: cannot set video mode\n");
goto err_free_cmap;
}
--
2.50.1
next reply other threads:[~2025-11-10 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 16:52 Javier Garcia [this message]
2025-11-14 17:03 ` [PATCH] fbdev/gxt4500: Use dev_err instead printk leftover Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251110165214.3076586-1-rampxxxx@gmail.com \
--to=rampxxxx@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).