From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-189.mta1.migadu.com (out-189.mta1.migadu.com [95.215.58.189]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CED912D0C7F for ; Tue, 2 Dec 2025 18:17:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.189 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764699432; cv=none; b=bmU02A9nFmqTuPVWQqyW88rNlGXOLber3iyixk1KQz02Sx0nY2fYCYlgYlujUoJ1ux87hpaD2v0JHWAlf9emPyWqQBnAhJUH+rr+w2neYQM6R9g615l09F/WVVVI336EEIRVGd3dEtsftt9aWw3UR5jAWMEVghEHa9UNgaz+9oU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764699432; c=relaxed/simple; bh=Gkf9/viPqGJiUs2DsUJKG0ohtBxtunbn/hMJY79K2ew=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Sysz7LSeX9gY6BW6S3SosYWTQfrIt6Eipuzmcqshjdt9+bZisn6AJ03H9TOcU4dNXfmsyWs0GBt6ZLig5ug9i1JqXC+S7ydmKrZQ92fLLZIaCHf/YvH6eN1r/c9njSAos24jQ57/bBLD3FLeluoJC/euEJeRM8q7KHU+CLYktMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=QU3gFqS8; arc=none smtp.client-ip=95.215.58.189 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="QU3gFqS8" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1764699418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=pl72qzIOzrYUk8v9JNDm8vYai5+J2tm/+q9u/2KEJQg=; b=QU3gFqS82ZU9PLt/RC6mfJ3vzXtBVuZkYYa8LQsocu/eqqHZuyshvW7lqYb5vddPkY27rE oZ9ZBYCtF5/tr33zIHsCW5R4XcFmCq78N+IWTh+62JRO3Bvtu6Qlcq2blwT4RXsUpo5Uet HwSIen91KQK5rRHOGlyL+3vScF6kojs= From: Thorsten Blum To: Helge Deller , Chelsy Ratnawat , Thomas Zimmermann , Andy Shevchenko , Raag Jadav Cc: Thorsten Blum , stable@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH] fbdev/pxafb: Fix multiple clamped values in pxafb_adjust_timing Date: Tue, 2 Dec 2025 19:15:32 +0100 Message-ID: <20251202181600.511166-2-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT The variables were never clamped because the return value of clamp_val() was not used. Fix this by assigning the clamped values, and use clamp() instead of clamp_val(). Cc: stable@vger.kernel.org Fixes: 3f16ff608a75 ("[ARM] pxafb: cleanup of the timing checking code") Signed-off-by: Thorsten Blum --- drivers/video/fbdev/pxafb.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/video/fbdev/pxafb.c b/drivers/video/fbdev/pxafb.c index b96a8a96bce8..e418eee825fb 100644 --- a/drivers/video/fbdev/pxafb.c +++ b/drivers/video/fbdev/pxafb.c @@ -419,12 +419,12 @@ static int pxafb_adjust_timing(struct pxafb_info *fbi, var->yres = max_t(int, var->yres, MIN_YRES); if (!(fbi->lccr0 & LCCR0_LCDT)) { - clamp_val(var->hsync_len, 1, 64); - clamp_val(var->vsync_len, 1, 64); - clamp_val(var->left_margin, 1, 255); - clamp_val(var->right_margin, 1, 255); - clamp_val(var->upper_margin, 1, 255); - clamp_val(var->lower_margin, 1, 255); + var->hsync_len = clamp(var->hsync_len, 1, 64); + var->vsync_len = clamp(var->vsync_len, 1, 64); + var->left_margin = clamp(var->left_margin, 1, 255); + var->right_margin = clamp(var->right_margin, 1, 255); + var->upper_margin = clamp(var->upper_margin, 1, 255); + var->lower_margin = clamp(var->lower_margin, 1, 255); } /* make sure each line is aligned on word boundary */ -- Thorsten Blum GPG: 1D60 735E 8AEF 3BE4 73B6 9D84 7336 78FD 8DFE EAD4