From: Greg KH <gregkh@linuxfoundation.org>
To: MottiKumar <mottikumarbabu@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
skhan@linuxfoundation.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: fix const array warning
Date: Tue, 30 Dec 2025 08:42:10 +0100 [thread overview]
Message-ID: <2025123055-procurer-prodigal-27b6@gregkh> (raw)
In-Reply-To: <20251226120417.2599020-1-mottikumarbabu@gmail.com>
On Fri, Dec 26, 2025 at 05:34:17PM +0530, MottiKumar wrote:
> Add a missing const to g_fbmode to fix a checkpatch warning:
> "static const char * array should probably be static const char * const"
>
> Signed-off-by: MottiKumar <mottikumarbabu@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index d100b9e1d3d5..7afb58561a0c 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.43.0
>
>
Did you test build this change? If not, please do so.
thanks,
greg k-h
next prev parent reply other threads:[~2025-12-30 7:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-26 12:04 [PATCH] staging: sm750fb: fix const array warning MottiKumar
2025-12-30 7:42 ` Greg KH [this message]
[not found] ` <CAC9bbDKw-TGY81wecEnmhbMror0R=y8McTJGU5CPRf2N8UM9fQ@mail.gmail.com>
2025-12-30 12:51 ` Greg KH
2025-12-31 3:31 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025123055-procurer-prodigal-27b6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mottikumarbabu@gmail.com \
--cc=skhan@linuxfoundation.org \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).