* [PATCH] staging: fbtft: align tinylcd write_reg args
@ 2026-01-08 9:47 Chaitanya Mishra
2026-01-08 9:57 ` Greg KH
2026-01-08 10:10 ` Chaitanya Mishra
0 siblings, 2 replies; 3+ messages in thread
From: Chaitanya Mishra @ 2026-01-08 9:47 UTC (permalink / raw)
To: andy, gregkh
Cc: dri-devel, linux-fbdev, linux-staging, linux-kernel,
chaitanyamishra.ai
Checkpatch reports a misaligned continuation line in the
fb_tinylcd init_display() write_reg() gamma table. Align the
continuation line with the open parenthesis to match kernel style.
No functional change.
Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com>
---
drivers/staging/fbtft/fb_tinylcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
index 9469248f2c50..60cda57bcb33 100644
--- a/drivers/staging/fbtft/fb_tinylcd.c
+++ b/drivers/staging/fbtft/fb_tinylcd.c
@@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
write_reg(par, 0xE5, 0x00);
write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
- 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
+ 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
write_reg(par, MIPI_DCS_SET_PIXEL_FORMAT, 0x55);
write_reg(par, MIPI_DCS_EXIT_SLEEP_MODE);
udelay(250);
--
2.50.1 (Apple Git-155)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: fbtft: align tinylcd write_reg args
2026-01-08 9:47 [PATCH] staging: fbtft: align tinylcd write_reg args Chaitanya Mishra
@ 2026-01-08 9:57 ` Greg KH
2026-01-08 10:10 ` Chaitanya Mishra
1 sibling, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-01-08 9:57 UTC (permalink / raw)
To: Chaitanya Mishra
Cc: andy, dri-devel, linux-fbdev, linux-staging, linux-kernel
On Thu, Jan 08, 2026 at 03:17:09PM +0530, Chaitanya Mishra wrote:
> Checkpatch reports a misaligned continuation line in the
>
> fb_tinylcd init_display() write_reg() gamma table. Align the
>
> continuation line with the open parenthesis to match kernel style.
>
> No functional change.
>
> Signed-off-by: Chaitanya Mishra <chaitanyamishra.ai@gmail.com>
> ---
> drivers/staging/fbtft/fb_tinylcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/fbtft/fb_tinylcd.c b/drivers/staging/fbtft/fb_tinylcd.c
> index 9469248f2c50..60cda57bcb33 100644
> --- a/drivers/staging/fbtft/fb_tinylcd.c
> +++ b/drivers/staging/fbtft/fb_tinylcd.c
> @@ -38,7 +38,7 @@ static int init_display(struct fbtft_par *par)
> write_reg(par, 0xE5, 0x00);
> write_reg(par, 0xF0, 0x36, 0xA5, 0x53);
> write_reg(par, 0xE0, 0x00, 0x35, 0x33, 0x00, 0x00, 0x00,
> - 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
> + 0x00, 0x35, 0x33, 0x00, 0x00, 0x00);
That kind of makes the code harder to read, right?
checkpatch is a guide, always use it as a hint, not as a rule.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: fbtft: align tinylcd write_reg args
2026-01-08 9:47 [PATCH] staging: fbtft: align tinylcd write_reg args Chaitanya Mishra
2026-01-08 9:57 ` Greg KH
@ 2026-01-08 10:10 ` Chaitanya Mishra
1 sibling, 0 replies; 3+ messages in thread
From: Chaitanya Mishra @ 2026-01-08 10:10 UTC (permalink / raw)
To: gregkh; +Cc: andy, dri-devel, linux-fbdev, linux-staging, linux-kernel
Thanks Greg,
Agreed. This change does not improve readability, and checkpatch is only a guide.
I will drop this patch.
Regards,
Chaitanya
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-08 10:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-08 9:47 [PATCH] staging: fbtft: align tinylcd write_reg args Chaitanya Mishra
2026-01-08 9:57 ` Greg KH
2026-01-08 10:10 ` Chaitanya Mishra
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox