* [PATCH] staging: sm750fb: rename fixId to fix_id
@ 2025-12-23 19:24 Tejas Chaudhari
0 siblings, 0 replies; 3+ messages in thread
From: Tejas Chaudhari @ 2025-12-23 19:24 UTC (permalink / raw)
To: linux-staging
Cc: linux-fbdev, sudipm.mukherjee, teddy.wang, gregkh,
Tejas Chaudhari
Rename the local fixId array to fix_id to follow
kernel naming conventions and fix a checkpatch
CamelCase warning.
No functional changes.
Signed-off-by: Tejas Chaudhari <tejaschaudhari038@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 15b5de33b..7afb58561 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
"kernel HELPERS prepared vesa_modes",
};
- static const char *fixId[2] = {
+ static const char *fix_id[2] = {
"sm750_fb1", "sm750_fb2",
};
@@ -862,7 +862,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
fix->ywrapstep = crtc->ywrapstep;
fix->accel = FB_ACCEL_SMI;
- strscpy(fix->id, fixId[index], sizeof(fix->id));
+ strscpy(fix->id, fix_id[index], sizeof(fix->id));
fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
pr_info("fix->smem_start = %lx\n", fix->smem_start);
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] staging: sm750fb: rename fixId to fix_id
@ 2025-12-23 19:27 Tejas Chaudhari
2026-01-11 12:51 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Tejas Chaudhari @ 2025-12-23 19:27 UTC (permalink / raw)
To: linux-staging
Cc: linux-fbdev, sudipm.mukherjee, teddy.wang, gregkh,
Tejas Chaudhari
Rename the local fixId array to fix_id to follow
kernel naming conventions and fix a checkpatch
CamelCase warning.
No functional changes.
Signed-off-by: Tejas Chaudhari <tejaschaudhari038@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 15b5de33b..7afb58561 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
"kernel HELPERS prepared vesa_modes",
};
- static const char *fixId[2] = {
+ static const char *fix_id[2] = {
"sm750_fb1", "sm750_fb2",
};
@@ -862,7 +862,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
fix->ywrapstep = crtc->ywrapstep;
fix->accel = FB_ACCEL_SMI;
- strscpy(fix->id, fixId[index], sizeof(fix->id));
+ strscpy(fix->id, fix_id[index], sizeof(fix->id));
fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
pr_info("fix->smem_start = %lx\n", fix->smem_start);
--
2.39.5 (Apple Git-154)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: sm750fb: rename fixId to fix_id
2025-12-23 19:27 [PATCH] staging: sm750fb: rename fixId to fix_id Tejas Chaudhari
@ 2026-01-11 12:51 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2026-01-11 12:51 UTC (permalink / raw)
To: Tejas Chaudhari; +Cc: linux-staging, linux-fbdev, sudipm.mukherjee, teddy.wang
On Wed, Dec 24, 2025 at 12:57:03AM +0530, Tejas Chaudhari wrote:
> Rename the local fixId array to fix_id to follow
> kernel naming conventions and fix a checkpatch
> CamelCase warning.
>
> No functional changes.
>
> Signed-off-by: Tejas Chaudhari <tejaschaudhari038@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 15b5de33b..7afb58561 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> "kernel HELPERS prepared vesa_modes",
> };
>
> - static const char *fixId[2] = {
> + static const char *fix_id[2] = {
> "sm750_fb1", "sm750_fb2",
> };
>
> @@ -862,7 +862,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> fix->ywrapstep = crtc->ywrapstep;
> fix->accel = FB_ACCEL_SMI;
>
> - strscpy(fix->id, fixId[index], sizeof(fix->id));
> + strscpy(fix->id, fix_id[index], sizeof(fix->id));
>
> fix->smem_start = crtc->o_screen + sm750_dev->vidmem_start;
> pr_info("fix->smem_start = %lx\n", fix->smem_start);
> --
> 2.39.5 (Apple Git-154)
>
Does not apply to the tree anymore :(
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-01-11 12:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-12-23 19:27 [PATCH] staging: sm750fb: rename fixId to fix_id Tejas Chaudhari
2026-01-11 12:51 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2025-12-23 19:24 Tejas Chaudhari
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox