From: Greg KH <gregkh@linuxfoundation.org>
To: Lorenzo Simonelli <lorenzosimonelli02@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fbdev@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: sm750fb: fix static const char array warning
Date: Sun, 11 Jan 2026 13:58:20 +0100 [thread overview]
Message-ID: <2026011155-unworried-service-d78e@gregkh> (raw)
In-Reply-To: <20260107094714.300380-2-lorenzosimonelli02@gmail.com>
On Wed, Jan 07, 2026 at 10:47:12AM +0100, Lorenzo Simonelli wrote:
> Fix the checkpatch.pl warning: "static const char * array should
> probably be static const char * const" by adding the missing
> const modifier.
>
> Signed-off-by: Lorenzo Simonelli <lorenzosimonelli02@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index fecd7457e..15b5de33b 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.52.0
>
Please ALWAYS test-build your patches before sending them out. That way
you catch obvious bugs like the one that this change introduces :(
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-11 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 9:47 [PATCH 0/3] staging: style cleanups for sm750fb and rtl8723bs Lorenzo Simonelli
2026-01-07 9:47 ` [PATCH 1/3] staging: sm750fb: fix static const char array warning Lorenzo Simonelli
2026-01-11 12:58 ` Greg KH [this message]
2026-01-07 9:47 ` [PATCH 2/3] staging: rtl8723bs: remove trailing whitespace Lorenzo Simonelli
2026-01-07 9:47 ` [PATCH 3/3] staging: rtl8723bs: remove unnecessary parentheses and true comparisons Lorenzo Simonelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011155-unworried-service-d78e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lorenzosimonelli02@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox