From: Greg KH <gregkh@linuxfoundation.org>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Chintan Patel <chintanlike@gmail.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, tzimmermann@suse.de,
andy@kernel.org, deller@gmx.de, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v5] staging: fbtft: use dev_of_fbinfo() instead of info->dev
Date: Mon, 12 Jan 2026 08:17:56 +0100 [thread overview]
Message-ID: <2026011205-ideally-swoop-b04e@gregkh> (raw)
In-Reply-To: <CAHp75VeF+Sj=dxA4RZAvVddGSG3brUsy8kz7mvtst2YpqNm99w@mail.gmail.com>
On Mon, Jan 12, 2026 at 09:07:42AM +0200, Andy Shevchenko wrote:
> On Mon, Jan 12, 2026 at 3:07 AM Chintan Patel <chintanlike@gmail.com> wrote:
> > - dev_dbg(info->dev, "%s(blank=%d)\n",
> > + dev_dbg(dev, "%s(blank=%d)\n",
> > __func__, blank);
>
> Since you are changing it anyway, make it one line.
Wait, why would dev_dbg() ever had __func__ added to it? That's
automatically included in the output if the user wants it, please do not
duplicate it again.
thanks,
greg k-h
next prev parent reply other threads:[~2026-01-12 7:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-12 1:07 [PATCH v5] staging: fbtft: use dev_of_fbinfo() instead of info->dev Chintan Patel
2026-01-12 6:48 ` Greg KH
2026-01-12 7:07 ` Andy Shevchenko
2026-01-12 7:17 ` Greg KH [this message]
2026-01-12 8:36 ` Thomas Zimmermann
2026-01-12 10:05 ` kernel test robot
2026-01-12 17:31 ` kernel test robot
2026-01-12 18:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026011205-ideally-swoop-b04e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=chintanlike@gmail.com \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox