From: Steven Rostedt <rostedt@goodmis.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-fbdev@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
John Ogness <john.ogness@linutronix.de>,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Simona Vetter <simona@ffwll.ch>, Helge Deller <deller@gmx.de>
Subject: Re: printk's threaded legacy console + fbcon => schedule where it should not
Date: Tue, 20 Jan 2026 11:08:45 -0500 [thread overview]
Message-ID: <20260120110845.2922a91a@gandalf.local.home> (raw)
In-Reply-To: <20260114145955.d924Z-zu@linutronix.de>
On Wed, 14 Jan 2026 15:59:55 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> @@ -3362,22 +3362,6 @@ void console_unlock(void)
> }
> EXPORT_SYMBOL(console_unlock);
>
> -/**
> - * console_conditional_schedule - yield the CPU if required
Egad! That goes all the way back to 2002:
https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=a880f45a48be2956d2c78a839c472287d54435c1
> - *
> - * If the console code is currently allowed to sleep, and
> - * if this CPU should yield the CPU to another task, do
> - * so here.
> - *
> - * Must be called within console_lock();.
> - */
> -void __sched console_conditional_schedule(void)
> -{
> - if (console_may_schedule)
> - cond_resched();
> -}
> -EXPORT_SYMBOL(console_conditional_schedule);
I'm assuming this likely isn't needed anymore. I don't know of any reason
it needs to stay.
Should we just remove it and see what breaks?
-- Steve
> -
> void console_unblank(void)
> {
> bool found_unblank = false;
next prev parent reply other threads:[~2026-01-20 16:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-14 14:59 printk's threaded legacy console + fbcon => schedule where it should not Sebastian Andrzej Siewior
2026-01-20 16:08 ` Steven Rostedt [this message]
2026-01-20 17:06 ` Sebastian Andrzej Siewior
2026-01-21 13:43 ` Petr Mladek
2026-01-21 13:57 ` Sebastian Andrzej Siewior
2026-01-21 16:08 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260120110845.2922a91a@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=deller@gmx.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=senozhatsky@chromium.org \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox