* [PATCH] fbdev: fix fb_pad_unaligned_buffer mask
@ 2026-01-27 19:30 Osama Abdelkader
2026-01-27 20:47 ` Helge Deller
0 siblings, 1 reply; 2+ messages in thread
From: Osama Abdelkader @ 2026-01-27 19:30 UTC (permalink / raw)
To: Simona Vetter, Helge Deller, Thomas Zimmermann, Lee Jones,
Murad Masimov, Osama Abdelkader, Yongzhen Zhang, Quanmin Yan,
linux-fbdev, dri-devel, linux-kernel
mask is u8, so it should use 0xff instead of 0xfff
Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
---
drivers/video/fbdev/core/fbmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/core/fbmem.c b/drivers/video/fbdev/core/fbmem.c
index eff757ebbed1..cf199038f069 100644
--- a/drivers/video/fbdev/core/fbmem.c
+++ b/drivers/video/fbdev/core/fbmem.c
@@ -100,7 +100,7 @@ EXPORT_SYMBOL(fb_pad_aligned_buffer);
void fb_pad_unaligned_buffer(u8 *dst, u32 d_pitch, u8 *src, u32 idx, u32 height,
u32 shift_high, u32 shift_low, u32 mod)
{
- u8 mask = (u8) (0xfff << shift_high), tmp;
+ u8 mask = (u8) (0xff << shift_high), tmp;
int i, j;
for (i = height; i--; ) {
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fbdev: fix fb_pad_unaligned_buffer mask
2026-01-27 19:30 [PATCH] fbdev: fix fb_pad_unaligned_buffer mask Osama Abdelkader
@ 2026-01-27 20:47 ` Helge Deller
0 siblings, 0 replies; 2+ messages in thread
From: Helge Deller @ 2026-01-27 20:47 UTC (permalink / raw)
To: Osama Abdelkader, Simona Vetter, Thomas Zimmermann, Lee Jones,
Murad Masimov, Yongzhen Zhang, Quanmin Yan, linux-fbdev,
dri-devel, linux-kernel
On 1/27/26 20:30, Osama Abdelkader wrote:
> mask is u8, so it should use 0xff instead of 0xfff
> Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>
> ---
> drivers/video/fbdev/core/fbmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied.
Thanks!
Helge
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-27 20:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-27 19:30 [PATCH] fbdev: fix fb_pad_unaligned_buffer mask Osama Abdelkader
2026-01-27 20:47 ` Helge Deller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox