* [PATCH] staging: sm750fb: make fixId array const
@ 2026-01-27 11:42 Madhumitha Sundar
2026-01-27 14:49 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Madhumitha Sundar @ 2026-01-27 11:42 UTC (permalink / raw)
To: sudipm.mukherjee, teddy.wang, gregkh
Cc: linux-fbdev, linux-staging, linux-kernel, Madhumitha Sundar
The fixId array contains constant string literals, but the array itself is
currently mutable.
Make the array const so that the compiler can place it in the read-only
data section (.rodata) instead of writable memory.
This fixes a warning detected by checkpatch.pl:
WARNING: static const char * array should probably be static const char * const
Signed-off-by: Madhumitha Sundar <madhuananda18@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index fecd7457e..ff590061c 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
"kernel HELPERS prepared vesa_modes",
};
- static const char *fixId[2] = {
+ static const char * const fixId[2] = {
"sm750_fb1", "sm750_fb2",
};
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: sm750fb: make fixId array const
2026-01-27 11:42 [PATCH] staging: sm750fb: make fixId array const Madhumitha Sundar
@ 2026-01-27 14:49 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2026-01-27 14:49 UTC (permalink / raw)
To: Madhumitha Sundar
Cc: sudipm.mukherjee, teddy.wang, linux-fbdev, linux-staging,
linux-kernel
On Tue, Jan 27, 2026 at 11:42:32AM +0000, Madhumitha Sundar wrote:
> The fixId array contains constant string literals, but the array itself is
> currently mutable.
>
> Make the array const so that the compiler can place it in the read-only
> data section (.rodata) instead of writable memory.
>
> This fixes a warning detected by checkpatch.pl:
> WARNING: static const char * array should probably be static const char * const
>
> Signed-off-by: Madhumitha Sundar <madhuananda18@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index fecd7457e..ff590061c 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -740,7 +740,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
> "kernel HELPERS prepared vesa_modes",
> };
>
> - static const char *fixId[2] = {
> + static const char * const fixId[2] = {
> "sm750_fb1", "sm750_fb2",
> };
>
> --
> 2.43.0
>
>
Does not apply to my tree at all, please rebase and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-01-27 14:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-27 11:42 [PATCH] staging: sm750fb: make fixId array const Madhumitha Sundar
2026-01-27 14:49 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox