* [PATCH v2] staging: sm750fb: add missing const to g_fbmode array
@ 2026-02-16 0:39 Eyüp Kerem Baş
2026-02-19 6:55 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Eyüp Kerem Baş @ 2026-02-16 0:39 UTC (permalink / raw)
To: Ethan Tidmore
Cc: sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev, linux-staging,
linux-kernel, Eyüp Kerem Baş
Checkpatch reported a warning that the static const char * array should
probably be static const char * const. This patch adds the missing const
keyword to g_fbmode array, moving it to read-only memory.
Signed-off-by: Eyüp Kerem Baş <baseyupkerem@gmail.com>
---
drivers/staging/sm750fb/sm750.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index fecd7457e615..15b5de33b8d9 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -33,7 +33,7 @@
static int g_hwcursor = 1;
static int g_noaccel;
static int g_nomtrr;
-static const char *g_fbmode[] = {NULL, NULL};
+static const char * const g_fbmode[] = {NULL, NULL};
static const char *g_def_fbmode = "1024x768-32@60";
static char *g_settings;
static int g_dualview;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: sm750fb: add missing const to g_fbmode array
2026-02-16 0:39 [PATCH v2] staging: sm750fb: add missing const to g_fbmode array Eyüp Kerem Baş
@ 2026-02-19 6:55 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2026-02-19 6:55 UTC (permalink / raw)
To: Eyüp Kerem Baş
Cc: Ethan Tidmore, sudipm.mukherjee, teddy.wang, gregkh, linux-fbdev,
linux-staging, linux-kernel
On Mon, Feb 16, 2026 at 03:39:39AM +0300, Eyüp Kerem Baş wrote:
> Checkpatch reported a warning that the static const char * array should
> probably be static const char * const. This patch adds the missing const
> keyword to g_fbmode array, moving it to read-only memory.
>
> Signed-off-by: Eyüp Kerem Baş <baseyupkerem@gmail.com>
> ---
This beaks the build.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-02-19 6:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-16 0:39 [PATCH v2] staging: sm750fb: add missing const to g_fbmode array Eyüp Kerem Baş
2026-02-19 6:55 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox