From: Greg KH <gregkh@linuxfoundation.org>
To: Shreyas Ravi <shreyasravi320@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/2] staging: sm750fb: remove Hungarian notation prefixes
Date: Mon, 23 Feb 2026 15:13:35 +0100 [thread overview]
Message-ID: <2026022316-subtype-hurdle-8b18@gregkh> (raw)
In-Reply-To: <20260208184344.657617-2-shreyasravi320@gmail.com>
On Sun, Feb 08, 2026 at 10:43:44AM -0800, Shreyas Ravi wrote:
> Remove Hungarian notation prefixes from variable names to comply
> with kernel coding style.
>
> No functional changes.
>
> Signed-off-by: Shreyas Ravi <shreyasravi320@gmail.com>
> ---
> Changes in v4:
> - Fix merge conflicts (forgot to do in v3)
>
> Changes in v3:
> - Added changelog (was missing in v2)
>
> Changes in v2:
> - Split original patch into two patches per Greg's feedback
> - This patch addresses Hungarian prefix removal
> ---
> drivers/staging/sm750fb/sm750.c | 22 ++++++------
> drivers/staging/sm750fb/sm750.h | 6 ++--
> drivers/staging/sm750fb/sm750_accel.c | 48 +++++++++++++--------------
> drivers/staging/sm750fb/sm750_accel.h | 2 +-
> drivers/staging/sm750fb/sm750_hw.c | 20 +++++------
> 5 files changed, 49 insertions(+), 49 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 1ed7ff57c142..afcfc9e6c207 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -624,27 +624,27 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
> output->paths = sm750_pnc;
> crtc->channel = sm750_primary;
> crtc->o_screen = 0;
> - crtc->v_screen = sm750_dev->p_v_mem;
> + crtc->v_screen = sm750_dev->v_mem;
You are fixing up your patch 1 of this series, why not just do it
properly the first time?
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-23 14:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 5:47 [PATCH] staging: sm750fb: fix CamelCase and Hungarian prefix in variable names Shreyas Ravi
2026-02-07 12:43 ` Greg KH
2026-02-08 2:59 ` [PATCH v2 1/2] staging: sm750fb: Fix CamelCase " Shreyas Ravi
2026-02-08 2:59 ` [PATCH v2 2/2] staging: sm750fb: remove Hungarian notation prefixes Shreyas Ravi
2026-02-08 6:36 ` [PATCH v2 1/2] staging: sm750fb: Fix CamelCase variable names Greg KH
2026-02-08 18:15 ` [PATCH v3 " Shreyas Ravi
2026-02-08 18:15 ` [PATCH v3 2/2] staging: sm750fb: remove Hungarian notation prefixes Shreyas Ravi
2026-02-08 18:43 ` [PATCH v4 1/2] staging: sm750fb: Fix CamelCase variable names Shreyas Ravi
2026-02-08 18:43 ` [PATCH v4 2/2] staging: sm750fb: remove Hungarian notation prefixes Shreyas Ravi
2026-02-23 14:13 ` Greg KH [this message]
2026-02-23 14:12 ` [PATCH v4 1/2] staging: sm750fb: Fix CamelCase variable names Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026022316-subtype-hurdle-8b18@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=shreyasravi320@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox