From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BF1D330334 for ; Fri, 27 Feb 2026 12:25:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772195115; cv=none; b=GyfZ5vLNQjkef7WOlMvzCkBvCYEIsy0lTULBJYQnJCTshdrX1qIMsLsNXrmVAfNQfmI1EUfX58BKLkDXJMXaoK7S/cKFyAm/qCebr3u9cM1f2X4LTvmJD7NFeSFuy+tn5huD2/WM9+Olf6WdHPSyE+26jGW/jCuQHbmKYjkm8Ow= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772195115; c=relaxed/simple; bh=P+qkb+46r1pOhfXqbnnaPkQ6Y0J/SoJAGu2MyiHuEv0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=hRVcPf5hQJt32DKw/RQGLZ0VQNPsotW32qlfk2sEjDAU1h9cSUfXpFtCe8ZHsxInoiarQnWnTL/CFF0udSak+p9MvY/XK0ZIWX62Y+xgOaMsPct1Q1n5FtVwz8lgiHhBnsa0ha0DOh4u5fxXLirBBAg/KpMeA6ooWu8bzGk2iF0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thingy.jp; spf=pass smtp.mailfrom=0x0f.com; dkim=pass (1024-bit key) header.d=thingy.jp header.i=@thingy.jp header.b=fAXeXlni; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=thingy.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=0x0f.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=thingy.jp header.i=@thingy.jp header.b="fAXeXlni" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-3594d7b36bdso646529a91.1 for ; Fri, 27 Feb 2026 04:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thingy.jp; s=google; t=1772195112; x=1772799912; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4DTCycSkXD9AMNo6HpXSEpzM+j7SRgkLeP93XH/2s3c=; b=fAXeXlni5g8rv+SeT8kVGc6LC9C3tGPG9A5kSHq6bQBmwQKIJJ2UwpRkaijV/rtHpq 3KBvC4in5BzjGeQJLa93lm6R8f/kQAiR71kwzTCxBnNtdpTdjaZR0DCE8/6mELSdvEru wLRBY64VtVlNzXIEi1m+p+IE6P06kZI2apWJ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772195112; x=1772799912; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4DTCycSkXD9AMNo6HpXSEpzM+j7SRgkLeP93XH/2s3c=; b=RXxf0iZadnXhp5LVEKKLEt2pkBkYWFV4N+HHsZf8vphi4nqzIjXajuGgMjQIkJHgv4 v/QO32uPXdqSgF0eSJtR0LhRcvhXQonxsz0zmwQKUjiZCnFWsTnCKcw80y11JEFfzBdY O+8CikPObV38+rtOgjGvsAztaRTpxU9D+AL3w56ZOK6LFwYe7z6yAthSSDpGoi3/byhe 6v7cWb8Y/W4rnoAmJX4QccalKxk1HwE9mwgMSqyPpNbticUssMeLzLe02qmpZtN8OoA2 wSHw7MWvCICTz0YvNmI7mTQ8E6vkHbEz+l4Zy7DZVGpiwjMI/V2DQGPiPbq7Jy60HTKV FNlg== X-Forwarded-Encrypted: i=1; AJvYcCUhXA7Tw7w+l6eLnfaQ1dvpNntzfO8Wgj1stsp+WgSVO7bJAuxr2KPFUrr3LWMYE+1NW1mAXOFMwjpQRw==@vger.kernel.org X-Gm-Message-State: AOJu0Yx3taDpGEQz+t5mDjYdc7Z8V9muYrGji2voPq+ntkgNSR/Oe9vT VmfcYO6FBUgBvGSqKPVwqAfJuu+9McZ2zRzJ3mA4PldveIfRT8Z0PWNjT0otE+vcP/sE2CsOaS7 YTY8T X-Gm-Gg: ATEYQzxU30IoPlyywnTtncIYnLILLrGzGJAdDk6pzM88OC4DhHMK4nJGga9ah3E1QT0 5R/x/Ce3r2XvliFBOyZQkcJUNfP2OsHwKI5qn+CXdJu2DQmp6s+qt9zuTOzIgGaz/y++bHO0Fg/ 7GlBBFIOeSNe8MTml8opggL9JCmuWmAGy0fFsk9PVPN0X806t2hWRPurO/9CuJv+5OcL49JOQjj AHafUQyrG8tayI9swUuYPEIYRhX0sDkYAD6RMcjZozSBLKZHDfElP0mTgjFH3U4vtGfdlFLoxVU kDYJKK1Bn2lkkRkSLLEIvnAlI3Ifo34yNmJ9oHoCBTUcUIUpWvHltP58jSU/FfGQM+qBzFFmmjk 5//qcMdXK7F13NCXDCh83to4mvJWRb9tgg0KPJqNsQkJxxGjJ+tz21IrMZH198GK3Pv0xuBQqs/ p323mmMMjGdFGkpdQ3wwwrqz3LZ7aV6sSGLGlC35HcOuW4BIKcFJF3WV6CjuPu7R4DDn0uk3E7e vw1WqKPOl3guoA= X-Received: by 2002:a17:90b:5111:b0:343:eb40:8dca with SMTP id 98e67ed59e1d1-35965cad678mr2014537a91.19.1772195112207; Fri, 27 Feb 2026 04:25:12 -0800 (PST) Received: from kinako.work.home.arpa (p1590226-ipxg00c01sizuokaden.shizuoka.ocn.ne.jp. [153.227.10.226]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-3591342f19fsm3612094a91.10.2026.02.27.04.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Feb 2026 04:25:11 -0800 (PST) From: Daniel Palmer To: deller@gmx.de, linux-fbdev@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniel Palmer Subject: [PATCH] fbdev/tdfxfb: Make the VGA register initialisation a bit more obvious Date: Fri, 27 Feb 2026 21:25:00 +0900 Message-ID: <20260227122500.3885069-1-daniel@thingy.jp> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit For a while I was trying to get this working on m68k, for some reason the card doesn't display anything if it's own video BIOS didn't run.. Anyhow, I spent a long time looking up what each of these offsets were to work out what the code is configuring and eventually replaced them with the human readable defines in video/vga.h. Functionally there is no change but maybe it makes it a bit easier to look at for the next person that finds themselves in here. Tested on a real voodoo 3 on x86_64. Signed-off-by: Daniel Palmer --- drivers/video/fbdev/tdfxfb.c | 109 ++++++++++++++++++----------------- 1 file changed, 55 insertions(+), 54 deletions(-) diff --git a/drivers/video/fbdev/tdfxfb.c b/drivers/video/fbdev/tdfxfb.c index 51ebe78359ec..7606e024fa3f 100644 --- a/drivers/video/fbdev/tdfxfb.c +++ b/drivers/video/fbdev/tdfxfb.c @@ -77,6 +77,7 @@ #include #include