From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Gabriel Windlin <gawindlin@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/8] staging: sm750fb: remove unused GPIO_MUX bit field definitions
Date: Mon, 9 Mar 2026 17:39:37 +0100 [thread overview]
Message-ID: <2026030913-deliverer-scorpion-d940@gregkh> (raw)
In-Reply-To: <20260303232434.1850583-1-gawindlin@gmail.com>
On Wed, Mar 04, 2026 at 12:24:22AM +0100, Gabriel Windlin wrote:
> The GPIO_MUX_0 through GPIO_MUX_31 bit field macros defined in
> ddk750_reg.h are not referenced anywhere in the driver. The register
> address GPIO_MUX itself is still used by ddk750_swi2c.c. Remove the
> unused bit definitions to reduce dead code as noted in the TODO file.
As Dan says, it's good to keep hardware documentation like this around,
as it's not taking any runtime space.
thanks,
greg k-h
prev parent reply other threads:[~2026-03-09 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 23:24 [PATCH 1/8] staging: sm750fb: remove unused GPIO_MUX bit field definitions Gabriel Windlin
2026-03-03 23:24 ` [PATCH 2/8] staging: sm750fb: remove unused CSC register definitions Gabriel Windlin
2026-03-03 23:24 ` [PATCH 3/8] staging: sm750fb: remove unused ZV capture " Gabriel Windlin
2026-03-03 23:24 ` [PATCH 4/8] staging: sm750fb: remove unused alpha and cursor " Gabriel Windlin
2026-03-03 23:24 ` [PATCH 5/8] staging: sm750fb: remove unused memory arbitration " Gabriel Windlin
2026-03-03 23:24 ` [PATCH 6/8] staging: sm750fb: remove unused interrupt " Gabriel Windlin
2026-03-03 23:24 ` [PATCH 7/8] staging: sm750fb: remove unused CURRENT_GATE, CRT_HWC, and DMA " Gabriel Windlin
2026-03-04 8:10 ` Dan Carpenter
2026-03-03 23:24 ` [PATCH 8/8] staging: sm750fb: remove unused GPIO bit field and interrupt definitions Gabriel Windlin
2026-03-09 16:39 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026030913-deliverer-scorpion-d940@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=gawindlin@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox