From: robgithub <rob.github@jumpstation.co.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: robgithub <rob.github@jumpstation.co.uk>,
"Helge Deller" <deller@gmx.de>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
linux-fbdev@vger.kernel.org,
"Prasanna Kumar T S M" <ptsm@linux.microsoft.com>,
"Wei Liu" <wei.liu@kernel.org>,
"Michael Kelley" <mhklinux@outlook.com>,
"Sukrut Heroorkar" <hsukrut3@gmail.com>,
"Mukesh Rathor" <mrathor@linux.microsoft.com>,
"Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: fbdev: update outdated help text for CONFIG_FB_NVIDIA
Date: Fri, 13 Mar 2026 20:35:42 +0000 [thread overview]
Message-ID: <20260313203443.7cf0a8f5@hexa5> (raw)
In-Reply-To: <034989df-cf86-4136-8522-6c48e5523645@infradead.org>
From 688a061ba0db71fc2d5facd8344db7a4d5b1575a Mon Sep 17 00:00:00 2001
From: robgithub <rob.github@jumpstation.co.uk>
Date: Wed, 11 Mar 2026 22:14:43 +0000
Subject: [PATCH] fbdev: update outdated help text for CONFIG_FB_NVIDIA
The help text for CONFIG_FB_NVIDIA refers to obsolete hardware and
incorrect default behaviour. This patch updates the description to
reflect the current state of the driver and supported devices.
Signed-off-by: robgithub <rob.github@jumpstation.co.uk>
---
drivers/video/fbdev/Kconfig | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index ac9ac4287c6a..d8e331427443 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -668,10 +668,10 @@ config FB_NVIDIA
select BITREVERSE
select VGASTATE
help
- This driver supports graphics boards with the nVidia chips, TNT
- and newer. For very old chipsets, such as the RIVA128, then use
- the rivafb.
- Say Y if you have such a graphics board.
+ Supports NVIDIA GPUs from TNT through early GeForce generations
+ (NV4–NV2x: Twintor, Twintor2, Celsius, Kelvin).
+ Later architectures (Rankine and newer) are not reliably supported.
+ If unsure, say N.
To compile this driver as a module, choose M here: the
module will be called nvidiafb.
--
2.52.0
Thanks, this my first time submitting a patch.
I have fixed the invisible whitespace inconsistency, wonder why I missed that :)
I really wanted to stop future users reading the "and newer" and enabling it on an unsupported card. It stopped my kernel booting with no errors.
The references I used to confirm the Nvidia devices affected are
List of devices documented in the code between lines 1228-1277
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/tree/drivers/video/fbdev/nvidia/nvidia.c?h=v6.19.6
with more human readable extraction available at
https://cateee.net/lkddb/web-lkddb/FB_NVIDIA.html
and the code names for all Nvidia cards are here
https://nouveau.freedesktop.org/CodeNames.html
Regards
Rob
On Thu, 12 Mar 2026 14:02:18 -0700
Randy Dunlap <rdunlap@infradead.org> wrote:
> Hi,
>
> On 3/12/26 1:55 PM, robgithub wrote:
> > The help text for CONFIG_FB_NVIDIA refers to obsolete hardware and
> > incorrect default behaviour. This patch updates the description to
> > reflect the current state of the driver and supported devices.
> >
> > Signed-off-by: robgithub <rob.github@jumpstation.co.uk>
>
> Inline patches are preferred over attachments.
>
> I thought that Claws mail could send inline patches successfully. (?)
>
> Documentation/process/email-clients.rst says that it works (after a little
> configuration setting).
>
> I don't know anything about which products are supported, so I have no
> comment on that.
>
> In the patch, the indentation is incorrect. Kconfig help text should be
> indented with one tab + 2 spaces, not with 4 spaces.
>
> thanks.
next prev parent reply other threads:[~2026-03-13 20:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 20:55 fbdev: update outdated help text for CONFIG_FB_NVIDIA robgithub
2026-03-12 21:02 ` Randy Dunlap
2026-03-13 20:35 ` robgithub [this message]
2026-03-20 16:56 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260313203443.7cf0a8f5@hexa5 \
--to=rob.github@jumpstation.co.uk \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsukrut3@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=mrathor@linux.microsoft.com \
--cc=ptsm@linux.microsoft.com \
--cc=rdunlap@infradead.org \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox