From: Greg KH <gregkh@linuxfoundation.org>
To: Emmanuel Arias <eamanu@riseup.net>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: [PATCH v2] staging: sm750fb: fix CamelCase variables name in sm750
Date: Tue, 26 May 2026 18:20:58 +0200 [thread overview]
Message-ID: <2026052623-cause-region-02e3@gregkh> (raw)
In-Reply-To: <20260526131631.1237672-1-eamanu@riseup.net>
On Tue, May 26, 2026 at 10:16:31AM -0300, Emmanuel Arias wrote:
> Replace CamelCase variable name with snake_case:
> - pvReg -> pv_reg
Why are you keeping the "pv_"? What does that mean?
> - setAllEngOff -> set_all_eng_off
>
> Reported-by: kernel test robot <lkp@intel.com>
The test robot told you to make this change?
> Closes: https://lore.kernel.org/oe-kbuild-all/202605171049.KbaBnrJV-lkp@intel.com/
> Signed-off-by: Emmanuel Arias <eamanu@riseup.net>
> ---
> drivers/staging/sm750fb/sm750.c | 6 +++---
> drivers/staging/sm750fb/sm750.h | 4 ++--
> drivers/staging/sm750fb/sm750_hw.c | 12 ++++++------
> 3 files changed, 11 insertions(+), 11 deletions(-)
What changed from v1?
thanks,
greg k-h
next prev parent reply other threads:[~2026-05-26 16:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-26 13:16 [PATCH v2] staging: sm750fb: fix CamelCase variables name in sm750 Emmanuel Arias
2026-05-26 16:20 ` Greg KH [this message]
2026-05-26 20:30 ` eamanu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026052623-cause-region-02e3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=eamanu@riseup.net \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=lkp@intel.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox