From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6781F218E91; Tue, 2 Jun 2026 13:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780407755; cv=none; b=E1iwYOuFz68mns4wjOg4POLBF6qkhxiY9EUbUfPqyz/SzC0yHF1PfAkg7gxwXCGgaGp2zoqc8B/U/6mZ5225tPvsD73hZU3qhAHwQAt9lGt3lCq5uNesK9EB3NkPk5lC0LbCDFawZvGhh1g/uKMu6VFusM/CKZU3xXESU1uu81M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780407755; c=relaxed/simple; bh=Yb7daYDsVq36BbcozNedyFxELYgKgIyx0p22hMyRMkw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G3/MqvvM+cLQczO465pjVDMeg9K6OTwlEaLnxl83nndr6jOhsvOUiB5rg5ZipTOzH6l4VeHQbcrXkgnFTb3ukwxmNWaotlQySDE6dR0GoqKNrlOYnplbtlBMEFO0L/bFXA53gAXEoLKFm2yniijOodZcgUrciuxHgQzkbUTCe9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=QkQaNHIK; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="QkQaNHIK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE6291F00893; Tue, 2 Jun 2026 13:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780407754; bh=+NOwv3nIu/Ot0KxPJsgbaT8KLyjfpqdRwQOPFZyGDyo=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=QkQaNHIKyHnxMEEHWFbu6OWHwnFZgNn0fwEiT2qDWJ5O1QLY9A3iMv7cwzbppdQoN 820Oo4HpnFSOU0L/FP6lp/cFc3ZUXGm/X520P0Gke8BIFOJkMqHe3yveARrrH6irRh 39y3QNs6j0FZIs6sy9U1ulKhOrUvnOMKLbuEiBTfm5nWAN3J3xn6Yi0gbnna0gh1D9 TQg/YW88ip7M0Cki+Jpdo/nJtZ3KeRpp7h7gi9kEYi+sydK5gPl//Eo9iu8jSrSZyL vE+KhsNX+C5rkpNSQWADDGZY4KOfKXZQFs8Imh0rVGTOg8OpdamhgQxy/oIt3cwxlt OyVgr5uekFYEg== Date: Tue, 2 Jun 2026 14:42:22 +0100 From: Jonathan Cameron To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , David Lechner , Nuno =?UTF-8?B?U8Oh?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 03/11] iio: light: lm3533-als: Remove redundant pdata helpers Message-ID: <20260602144222.7a50a041@jic23-huawei> In-Reply-To: <20260601151831.76350-4-clamor95@gmail.com> References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-4-clamor95@gmail.com> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 1 Jun 2026 18:18:23 +0300 Svyatoslav Ryhel wrote: > The lm3533_als_set_input_mode and lm3533_als_set_resistor functions are > used only in lm3533_als_setup. Incorporate their code into > lm3533_als_setup directly to simplify driver readability. Minor stuff inline. > > Signed-off-by: Svyatoslav Ryhel > --- > drivers/iio/light/lm3533-als.c | 61 +++++++++------------------------- > 1 file changed, 16 insertions(+), 45 deletions(-) > > diff --git a/drivers/iio/light/lm3533-als.c b/drivers/iio/light/lm3533-als.c > index fb61904f110f..52136ca1abc9 100644 > --- a/drivers/iio/light/lm3533-als.c > +++ b/drivers/iio/light/lm3533-als.c > static int lm3533_als_setup(struct lm3533_als *als, > const struct lm3533_als_platform_data *pdata) > { > + struct device *dev = &als->pdev->dev; > int ret; > > - ret = lm3533_als_set_input_mode(als, pdata->pwm_mode); > + ret = regmap_update_bits(als->lm3533->regmap, LM3533_REG_ALS_CONF, Maybe a local struct regmap pointer given dereferenced in a couple of places. > + LM3533_ALS_INPUT_MODE_MASK, > + pdata->pwm_mode ? LM3533_ALS_INPUT_MODE_MASK : 0); Andy raised this in previous patch but in the interests of being specific regmap_assign_bits() is going to be cleaner here. > if (ret) > - return ret; > + return dev_err_probe(dev, ret, "failed to set input mode %d\n", > + pdata->pwm_mode); > + > > /* ALS input is always high impedance in PWM-mode. */ > if (!pdata->pwm_mode) { > - ret = lm3533_als_set_resistor(als, pdata->r_select); > + if (pdata->r_select < LM3533_ALS_RESISTOR_MIN || > + pdata->r_select > LM3533_ALS_RESISTOR_MAX) { > + dev_err(&als->pdev->dev, "invalid resistor value\n"); > + return -EINVAL; > + } > + > + ret = regmap_write(als->lm3533->regmap, LM3533_REG_ALS_RESISTOR_SELECT, > + pdata->r_select); > if (ret) > - return ret; > + return dev_err_probe(dev, ret, "failed to set resistor\n"); > } > > return 0;