From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 588ED3D0934 for ; Wed, 17 Jun 2026 08:00:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781683261; cv=none; b=jSmgkCyHJM+EzhUDGT616YZtxB2mrGrLZq1+CsXipv9PqHaWFhmIXuInJygUcXVuL6QPdg5t/fgEdGCUzhqEerY+0Yy1NanlwyE+xwESV+zZX5svqWCczvNkrbd137dnOtlKLuie2U/sONCMYeVBU5yjbfoScJ7wlVxVH5sfq6k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781683261; c=relaxed/simple; bh=TTELV8IpYd68DmqOR1f5rOCgz/ySoag1Ez1+u/elF8g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IM5DQHRq3+3PVyXO9a9P9tVGQGxkRgx8lPxG50cEPcAqwTD2rEoTeguuxExqLdGmaQQ0M/BuBWkDK7WlY+9V6g0EE+56kqlWDZ25yjOXIbsJGUKTiUCMC2EwZJgKgpMeBf7H5lfZxlZQNlEXeYr+uVTsQ7zjZVJPpixwO4tua3w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LQ/iw4xP; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LQ/iw4xP" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-bf1141c26ecso652518866b.0 for ; Wed, 17 Jun 2026 01:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1781683252; x=1782288052; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XN/2fWo04yb49XoOXlEMtfv2zfwELjeaHNjw1feXliI=; b=LQ/iw4xPQsM6MpB8IebcysDbUOYAKgmbUbwpBtuFDwI+niiWcvKe3SGf60jNnAxBKT wm6reAgrEKK9arskZozrm7cr+ubbjGSktQAd0o7Bsn2Y0TL8yhJwYVAtUSg3knqStRf6 sytWKBe92DonLcFKr5+gbfQwQpwvWsN/7bb7lH98+VHcz70o8ooUTwNAHIwM7wJRLOtf c3YHCpGbXFxCEeMzxaJtDsDJln6QtE6nyI0l0mBSRTOTjR7H01XFTWIn6pAcgw3Bg6A7 tOTOZl5zL/wQjloFUn0EufhkP6X5Dv+TqCicfHPQf3i54QP7SCm8jMpfjAF03KTSt8nP lYkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781683252; x=1782288052; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XN/2fWo04yb49XoOXlEMtfv2zfwELjeaHNjw1feXliI=; b=RQvgpEzplbfDUivmm4FBGnG5LbELf7nQ70AVGifU6n92ib4/YFrtJNiqEmy+YV6ntg 0q3me/BspnPEC6Cf8Wz3wLQUWBLe6ApAxIIvugrZyvZrMM5F0BLg1AE4/5kCzsHQLroB EiJW0CEAiAKtxJdqSDPYKn5VyI0i6bxFbD5lO0W9j/2M0ZX8ZD/7B/bS4HxGlF2XHjJD N01HWPtGSKbhNaXi24HSBLPPpz2NFZCl+kBNqZTSt/1km/FwHMsQzOCWuwsdcStosaGV mnIyhM+fH+olOme29b4zTLsaTcmOSz+A8iXQqd2FW1506mHeNfkmBjpB1OlhyKTCCAKj 4oAg== X-Forwarded-Encrypted: i=1; AFNElJ805DtoypFlzY3HKLxkNE7G+1k1L2kq01dTBoJDvubRDzX+v9hE4sF3wEzVW2T+B0bLTy8Nn1yMGIYvCg==@vger.kernel.org X-Gm-Message-State: AOJu0YyVI5haZAjoW3OdnDF6y2VWhsBjoE2pMQnOOmJS+qvJou/wFTCt PWWkyeKxh9/KGDVq4tccd/6wxolqsIwpRctvh0yOR1x5jONysNUaxzZ8 X-Gm-Gg: AfdE7cl/w6L3tBsCBubqs2+Va19IRIDYK7vDdKIyrDxS/FE88ruiVWjvX0KkZXNquDi LWm/kqXeHlvZSMAvDjI7B4GSI+ZwTwZMPigp7ngQLMCqXCfj7IMsdsHoxUJ7zeBEl1PN/DyeQ17 iuBT7mnyd0BF61pnVL5kaHp2CTKX/oAC06KMuJwCqonWmEnuuz/jKfmIMo13jMI1jlh03KGkb2d nY/sDVJtn6He4CbcTE1wcF6miahpZmBpzFYEqtYvySF3826wwuG1i1myfplkKf9mPZGQNhrHcoa uIUS2LmkJD4hhsbd+pnrs+vbFzv2igkjw7f51+jR12BJLxSNEOU7PW9vaEOdoioOODdfnBzaS/Q XDtNGNL2bXDqFYTZXvcjZe5DXzHHsYVFFLWZkYNWDrxiWoAcbjQEzIiu8SzHNgCaAEieY5IZj1e Y92BzD8J3hrjRI X-Received: by 2002:a17:907:d78a:b0:bed:275:5e5b with SMTP id a640c23a62f3a-c05a77cb897mr178021366b.42.1781683252049; Wed, 17 Jun 2026 01:00:52 -0700 (PDT) Received: from xeon ([188.163.112.61]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb058fa59sm755339766b.0.2026.06.17.01.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2026 01:00:51 -0700 (PDT) From: Svyatoslav Ryhel To: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Helge Deller , Svyatoslav Ryhel Cc: Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: [PATCH v5 07/14] mfd: lm3533: Use dev_groups in struct device_driver Date: Wed, 17 Jun 2026 11:00:24 +0300 Message-ID: <20260617080031.99156-8-clamor95@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260617080031.99156-1-clamor95@gmail.com> References: <20260617080031.99156-1-clamor95@gmail.com> Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Instead of creating and removing the device sysfs attributes directly during probe and remove of the driver, respectively, use dev_groups in struct device_driver to point to the attribute definitions and let the core take care of creating and removing them. No intentional functional impact. Signed-off-by: Svyatoslav Ryhel --- drivers/mfd/lm3533-core.c | 16 ++++++---------- drivers/video/backlight/lm3533_bl.c | 22 ++++++++-------------- 2 files changed, 14 insertions(+), 24 deletions(-) diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c index 45e7f7481aa0..b03a3ae96c10 100644 --- a/drivers/mfd/lm3533-core.c +++ b/drivers/mfd/lm3533-core.c @@ -296,6 +296,11 @@ static struct attribute_group lm3533_attribute_group = { .attrs = lm3533_attributes }; +static const struct attribute_group *lm3533_attribute_groups[] = { + &lm3533_attribute_group, + NULL, +}; + static int lm3533_device_als_init(struct lm3533 *lm3533) { struct lm3533_platform_data *pdata = dev_get_platdata(lm3533->dev); @@ -416,16 +421,8 @@ static int lm3533_device_init(struct lm3533 *lm3533) lm3533_device_bl_init(lm3533); lm3533_device_led_init(lm3533); - ret = sysfs_create_group(&lm3533->dev->kobj, &lm3533_attribute_group); - if (ret < 0) { - dev_err(lm3533->dev, "failed to create sysfs attributes\n"); - goto err_unregister; - } - return 0; -err_unregister: - mfd_remove_devices(lm3533->dev); err_disable: lm3533_disable(lm3533); @@ -436,8 +433,6 @@ static void lm3533_device_exit(struct lm3533 *lm3533) { dev_dbg(lm3533->dev, "%s\n", __func__); - sysfs_remove_group(&lm3533->dev->kobj, &lm3533_attribute_group); - mfd_remove_devices(lm3533->dev); lm3533_disable(lm3533); } @@ -532,6 +527,7 @@ MODULE_DEVICE_TABLE(i2c, lm3533_i2c_ids); static struct i2c_driver lm3533_i2c_driver = { .driver = { .name = "lm3533", + .dev_groups = lm3533_attribute_groups, }, .id_table = lm3533_i2c_ids, .probe = lm3533_i2c_probe, diff --git a/drivers/video/backlight/lm3533_bl.c b/drivers/video/backlight/lm3533_bl.c index 4d6f68033480..9ef171d3aaea 100644 --- a/drivers/video/backlight/lm3533_bl.c +++ b/drivers/video/backlight/lm3533_bl.c @@ -237,6 +237,11 @@ static struct attribute_group lm3533_bl_attribute_group = { .attrs = lm3533_bl_attributes }; +static const struct attribute_group *lm3533_bl_attribute_groups[] = { + &lm3533_bl_attribute_group, + NULL, +}; + static int lm3533_bl_setup(struct lm3533_bl *bl, struct lm3533_bl_platform_data *pdata) { @@ -304,28 +309,17 @@ static int lm3533_bl_probe(struct platform_device *pdev) platform_set_drvdata(pdev, bl); - ret = sysfs_create_group(&bd->dev.kobj, &lm3533_bl_attribute_group); - if (ret < 0) { - dev_err(&pdev->dev, "failed to create sysfs attributes\n"); - return ret; - } - backlight_update_status(bd); ret = lm3533_bl_setup(bl, pdata); if (ret) - goto err_sysfs_remove; + return ret; ret = lm3533_ctrlbank_enable(&bl->cb); if (ret) - goto err_sysfs_remove; + return ret; return 0; - -err_sysfs_remove: - sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); - - return ret; } static void lm3533_bl_remove(struct platform_device *pdev) @@ -339,7 +333,6 @@ static void lm3533_bl_remove(struct platform_device *pdev) bd->props.brightness = 0; lm3533_ctrlbank_disable(&bl->cb); - sysfs_remove_group(&bd->dev.kobj, &lm3533_bl_attribute_group); } #ifdef CONFIG_PM_SLEEP @@ -377,6 +370,7 @@ static struct platform_driver lm3533_bl_driver = { .driver = { .name = "lm3533-backlight", .pm = &lm3533_bl_pm_ops, + .dev_groups = lm3533_bl_attribute_groups, }, .probe = lm3533_bl_probe, .remove = lm3533_bl_remove, -- 2.53.0