From: Pan Chuang <panchuang@vivo.com>
To: Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Pan Chuang <panchuang@vivo.com>,
dri-devel@lists.freedesktop.org (open list:FBTFT Framebuffer
drivers),
linux-fbdev@vger.kernel.org (open list:FBTFT Framebuffer drivers),
linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/7] staging: fbtft: Remove redundant dev_err_probe()
Date: Mon, 20 Jul 2026 21:43:08 +0800 [thread overview]
Message-ID: <20260720134324.239391-3-panchuang@vivo.com> (raw)
In-Reply-To: <20260720134324.239391-1-panchuang@vivo.com>
Since commit
55b48e23f5c4 ("genirq/devres: Add error handling in devm_request_*_irq()"),
devm_request_irq() automatically logs detailed error messages on
failure. Remove the now-redundant driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/staging/fbtft/fb_st7789v.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_st7789v.c b/drivers/staging/fbtft/fb_st7789v.c
index 861a154144e6..ec46ad3f6a91 100644
--- a/drivers/staging/fbtft/fb_st7789v.c
+++ b/drivers/staging/fbtft/fb_st7789v.c
@@ -119,7 +119,7 @@ static int init_tearing_effect_line(struct fbtft_par *par)
rc = devm_request_irq(dev, irq_te, panel_te_handler,
IRQF_TRIGGER_RISING, "TE_GPIO", par);
if (rc)
- return dev_err_probe(dev, rc, "TE IRQ request failed.\n");
+ return rc;
disable_irq_nosync(irq_te);
--
2.34.1
next prev parent reply other threads:[~2026-07-20 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 13:43 [PATCH 0/7] staging: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-20 13:43 ` Pan Chuang [this message]
2026-07-20 18:18 ` [PATCH 2/7] staging: fbtft: Remove redundant dev_err_probe() Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260720134324.239391-3-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox