From: Pan Chuang <panchuang@vivo.com>
To: "Helge Deller" <deller@gmx.de>, "Pan Chuang" <panchuang@vivo.com>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-omap@vger.kernel.org (open list:OMAP DISPLAY SUBSYSTEM and
FRAMEBUFFER SUPPORT...),
linux-fbdev@vger.kernel.org (open list:OMAP DISPLAY SUBSYSTEM
and FRAMEBUFFER SUPPORT...),
dri-devel@lists.freedesktop.org (open list:FRAMEBUFFER LAYER),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 2/7] fbdev: omapfb/dsi-cm: Remove redundant dev_err()
Date: Wed, 22 Jul 2026 15:57:42 +0800 [thread overview]
Message-ID: <20260722075803.570532-3-panchuang@vivo.com> (raw)
In-Reply-To: <20260722075803.570532-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() call.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
index 5e7963b4aa93..7c3463ee02ef 100644
--- a/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
+++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-dsi-cm.c
@@ -1185,10 +1185,8 @@ static int dsicm_probe(struct platform_device *pdev)
IRQF_TRIGGER_RISING,
"taal vsync", ddata);
- if (r) {
- dev_err(dev, "IRQ request failed\n");
+ if (r)
return r;
- }
INIT_DEFERRABLE_WORK(&ddata->te_timeout_work,
dsicm_te_timeout_work_callback);
--
2.34.1
next prev parent reply other threads:[~2026-07-22 7:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-22 7:57 [PATCH 0/7] video: fbdev: Remove redundant dev_err() Pan Chuang
2026-07-22 7:57 ` [PATCH 1/7] fbdev: mmp: " Pan Chuang
2026-07-22 7:57 ` Pan Chuang [this message]
2026-07-22 7:57 ` [PATCH 3/7] fbdev: pxa168fb: " Pan Chuang
2026-07-22 7:57 ` [PATCH 4/7] fbdev: pxa3xx-gcu: " Pan Chuang
2026-07-22 7:57 ` [PATCH 5/7] fbdev: pxafb: " Pan Chuang
2026-07-22 7:57 ` [PATCH 6/7] fbdev: s3c-fb: " Pan Chuang
2026-07-22 7:57 ` [PATCH 7/7] fbdev: sa1100fb: " Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260722075803.570532-3-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=bhelgaas@google.com \
--cc=dakr@kernel.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox