From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Mohit Mishra <mishraloopmohit@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Align prototype parameter names to implementation
Date: Tue, 28 Jul 2026 09:24:27 +0200 [thread overview]
Message-ID: <2026072814-napkin-legume-4b5e@gregkh> (raw)
In-Reply-To: <20260720142605.63454-1-mishraloopmohit@gmail.com>
On Mon, Jul 20, 2026 at 07:56:05PM +0530, Mohit Mishra wrote:
> The declarations for sm750_hw_copyarea and sm750_hw_imageblit in sm750_accel.h
> use legacy CamelCase parameters, which do not match the snake_case names
> in the actual implementation in sm750_accel.c. The de_copyarea and
> de_imageblit function pointers in struct lynx_accel (sm750.h) also use
> outdated parameter names.
>
> Rename these prototype parameters to match their implementation names.
>
> Signed-off-by: Mohit Mishra <mishraloopmohit@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.h | 10 +++++-----
> drivers/staging/sm750fb/sm750_accel.h | 12 ++++++------
> 2 files changed, 11 insertions(+), 11 deletions(-)
Does not apply to the staging-testing branch :(
prev parent reply other threads:[~2026-07-28 7:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-20 14:26 [PATCH] staging: sm750fb: Align prototype parameter names to implementation Mohit Mishra
2026-07-28 7:24 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026072814-napkin-legume-4b5e@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mishraloopmohit@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox