From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nils Lehnen <nils.lehnen@proton.me>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] staging: sm750fb: remove dead VALIDATION_CHIP conditionals
Date: Tue, 28 Jul 2026 09:13:22 +0200 [thread overview]
Message-ID: <2026072845-curliness-overcook-68a0@gregkh> (raw)
In-Reply-To: <20260724131121.438-1-nils.lehnen@proton.me>
On Fri, Jul 24, 2026 at 01:12:59PM +0000, Nils Lehnen wrote:
> @@ -1020,9 +996,7 @@
> #define CRT_DISPLAY_CTRL_CRTSELECT BIT(25)
> #define CRT_DISPLAY_CTRL_RGBBIT BIT(24)
>
> -#ifndef VALIDATION_CHIP
> #define CRT_DISPLAY_CTRL_CENTERING BIT(24)
> -#endif
But this define isn't used anywhere.
> #define CRT_DISPLAY_CTRL_LOCK_TIMING BIT(23)
> #define CRT_DISPLAY_CTRL_EXPANSION BIT(22)
> #define CRT_DISPLAY_CTRL_VERTICAL_MODE BIT(21)
> @@ -1121,22 +1095,17 @@
>
> /* This vertical expansion below start at 0x080240 ~ 0x080264 */
> #define CRT_VERTICAL_EXPANSION 0x080240
> -#ifndef VALIDATION_CHIP
> #define CRT_VERTICAL_CENTERING_VALUE_MASK (0xff << 24)
> -#endif
And neither is this. And now the indentation for all of these does not
make any sense, right?
thanks,
greg k-h
prev parent reply other threads:[~2026-07-28 7:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 13:12 [PATCH v3] staging: sm750fb: remove dead VALIDATION_CHIP conditionals Nils Lehnen
2026-07-28 7:13 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026072845-curliness-overcook-68a0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nils.lehnen@proton.me \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox