From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: [PATCH 02/03] fbdev: maxine: elide an unused function
Date: Thu, 13 Aug 2026 16:29:33 -0700 [thread overview]
Message-ID: <20260813232934.2718291-3-rdunlap@infradead.org> (raw)
In-Reply-To: <20260813232934.2718291-1-rdunlap@infradead.org>
maxinefb_ims332_read_register() is not used, but since it describes a
hardware interface, leave it in the source file as documentation
and surround it inside an #if 0/#endif block.
../drivers/video/fbdev/maxinefb.c:74:21: warning: 'maxinefb_ims332_read_register' defined but not used [-Wunused-function]
74 | static unsigned int maxinefb_ims332_read_register(int regno)
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
drivers/video/fbdev/maxinefb.c | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20260812.orig/drivers/video/fbdev/maxinefb.c
+++ linux-next-20260812/drivers/video/fbdev/maxinefb.c
@@ -71,6 +71,8 @@ static void maxinefb_ims332_write_regist
*((volatile unsigned short *) (wptr)) = val;
}
+#if 0
+/* dead code: leave here for hardware interface documentation */
static unsigned int maxinefb_ims332_read_register(int regno)
{
register unsigned char *regs = (char *) MAXINEFB_IMS332_ADDRESS;
@@ -83,6 +85,7 @@ static unsigned int maxinefb_ims332_read
return (j & 0xffff) | ((k & 0xff00) << 8);
}
+#endif
/* Set the palette */
static int maxinefb_setcolreg(unsigned regno, unsigned red, unsigned green,
next prev parent reply other threads:[~2026-08-13 23:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 23:29 [PATCH 00/03] fbdev: maxine: clean up build issues Randy Dunlap
2026-08-13 23:29 ` [PATCH 01/03] fbdev: maxine: make functions static Randy Dunlap
2026-08-13 23:29 ` Randy Dunlap [this message]
2026-08-13 23:29 ` [PATCH 03/03] fbdev: maxine: fix 64-bit build error Randy Dunlap
2026-08-14 7:39 ` [PATCH 00/03] fbdev: maxine: clean up build issues Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813232934.2718291-3-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox