Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wim de With <wf@dewith.io>
Cc: Lee Jones <lee@kernel.org>, Daniel Thompson <danielt@kernel.org>,
	 Jingoo Han <jingoohan1@gmail.com>,
	Pavel Machek <pavel@kernel.org>, Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Helge Deller <deller@gmx.de>,
	 dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] backlight: Add support for Orient Chip OCP8178
Date: Fri, 14 Aug 2026 11:22:15 +0200	[thread overview]
Message-ID: <20260814-peculiar-mega-mandrill-3a3148@quoll> (raw)
In-Reply-To: <20260812-ocp8178-backlight-v2-2-4ad18b48bef8@dewith.io>

On Wed, Aug 12, 2026 at 09:21:47PM +0200, Wim de With wrote:
> +	props = (typeof(props)){
> +		.type = BACKLIGHT_RAW,
> +		.brightness = brightness,
> +		.max_brightness = max_brightness,
> +		.power = BACKLIGHT_POWER_ON,
> +		.scale = BACKLIGHT_SCALE_NON_LINEAR,
> +	};
> +
> +	bl = devm_backlight_device_register(dev, dev_name(dev), dev, ocp8178,
> +					    &ocp8178_bl_ops, &props);
> +	if (IS_ERR(bl))
> +		return dev_err_probe(dev, PTR_ERR(bl),
> +				     "failed to register backlight\n");
> +
> +	platform_set_drvdata(pdev, bl);
> +	backlight_update_status(bl);
> +
> +	dev_dbg(dev, "probed, brightness=%u/%u\n", brightness, max_brightness);

You should not have probe success messages even as debug. It's not
printing anything useful as brightness is fixed (comes from DTB) and
devices appear in sysfs thus you can check them. Printing debug probe
success messages applies for core SoC drivers which might fail before
reaching initramfs mount and starting init.

Best regards,
Krzysztof


      parent reply	other threads:[~2026-08-14  9:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-12 19:21 [PATCH v2 0/2] backlight: Add support for Orient Chip OCP8178 Wim de With
2026-08-12 19:21 ` [PATCH v2 1/2] dt-bindings: backlight: Add " Wim de With
2026-08-13  9:42   ` Daniel Thompson
2026-08-13  9:59     ` Wim de With
2026-08-12 19:21 ` [PATCH v2 2/2] backlight: Add support for " Wim de With
2026-08-13  9:42   ` Daniel Thompson
2026-08-14  9:22   ` Krzysztof Kozlowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814-peculiar-mega-mandrill-3a3148@quoll \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=danielt@kernel.org \
    --cc=deller@gmx.de \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jingoohan1@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=pavel@kernel.org \
    --cc=robh@kernel.org \
    --cc=wf@dewith.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox