From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Helge Deller <deller@gmx.de>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
"Maciej W. Rozycki" <macro@orcam.me.uk>
Subject: [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally
Date: Fri, 14 Aug 2026 11:42:34 -0700 [thread overview]
Message-ID: <20260814184234.3013510-1-rdunlap@infradead.org> (raw)
This driver cannot be built as a loadable module so testing for
"#ifdef MODULE" is not appropriate here.
Also, MODULE_LICENSE() is always available.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
Cc: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: "Maciej W. Rozycki" <macro@orcam.me.uk>
drivers/video/fbdev/maxinefb.c | 2 --
1 file changed, 2 deletions(-)
--- linux-next-20260814.orig/drivers/video/fbdev/maxinefb.c
+++ linux-next-20260814/drivers/video/fbdev/maxinefb.c
@@ -169,9 +169,7 @@ static void __exit maxinefb_exit(void)
unregister_framebuffer(&fb_info);
}
-#ifdef MODULE
MODULE_LICENSE("GPL");
-#endif
module_init(maxinefb_init);
module_exit(maxinefb_exit);
next reply other threads:[~2026-08-14 18:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 18:42 Randy Dunlap [this message]
2026-08-14 19:40 ` [PATCH] fbdev: maxine: use MODULE_LICENSE() unconditionally Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814184234.3013510-1-rdunlap@infradead.org \
--to=rdunlap@infradead.org \
--cc=deller@gmx.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@orcam.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox