From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D903496D4B; Mon, 14 Sep 2026 18:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789409658; cv=none; b=eN0THxb2FyTcwhdJfdE1F3L26MLlwdR3ZVEKWYjxJ5Skfnt44MVQWqXUBZNaKVD75hAIxbdnNNKAjTNToudjMAsQ7+D5qLNHM3IItOcrhFZNuylNea4ouQ1ci9dI3PwEwtLd9f+QOFD99RJQSOHiXfxvcg/Y1olKFsZTXOuG3uU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789409658; c=relaxed/simple; bh=amXM8PKIKM/ToVfiVB0vQgptloCgyaQyxAlLwhGLl88=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fVafeeoG089NPFULG9eOuuIYdkHjp3epQw7I5Hp7/7srz63h6hmzAU5lOWcPJjITFAWiWzivKxbJQhDn9Ae4E/lpdrEeWiVnjcsjndsI8OjyBaPlDA9Qtir+SnpA0Tvop8959GeXZwWIBybsIe4YOrD3kNsqkD0WLDWJk2SHHg0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=pFKpZpZa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="pFKpZpZa" Received: by smtp.kernel.org (Postfix) with ESMTPS id CBF2DC2BCFA; Mon, 14 Sep 2026 18:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789409657; bh=amXM8PKIKM/ToVfiVB0vQgptloCgyaQyxAlLwhGLl88=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=pFKpZpZaEMCFVSX+WdizcaK6/XRKL5FLhRv7yVwmrAPQJgjdiyxUcMDd6M12hkBVk M8iMA5oGAadWM9Lwox4N2kzpnPufMf2VQwKrbedk4Uf2E2316r5PEW4lj39QYWPzbv OpvFlJBQi2r4ryW0xOMw7XxC7Wh6t1cACHKFI1Qshv50fop1akH+LLepmlyqqkzUQ+ iQgQvuRFNGk2sNjgSU06w2v1toeify1owwT21An0muGGqk/cycUwytSPtGKGXj37ty /iqQbtO0+DlhN0lNhMdrbO3DScFvOzaU4XMKobdq19DAxPDF9soiN1NG1cpHqd4rEm 9QDnTCKOdN38A== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB519C88E6F; Mon, 14 Sep 2026 18:14:17 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Mon, 14 Sep 2026 20:14:14 +0200 Subject: [PATCH v3 1/4] backlight: qcom-wled: Fix NULL pointer dereference in PM callbacks Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260914-qcom-wled-backlight-v3-1-d69fe9843841@ixit.cz> References: <20260914-qcom-wled-backlight-v3-0-d69fe9843841@ixit.cz> In-Reply-To: <20260914-qcom-wled-backlight-v3-0-d69fe9843841@ixit.cz> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Kiran Gunda , Marco Mattiolo , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Konrad Dybcio , Joel Selvaraj , David Heidelberg , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1308; i=david@ixit.cz; h=from:subject:message-id; bh=+wgGNECp4AfVjE6eGXUZbwV3oC+I+6OGlHWyUvqiSrU=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqqDl4wE0G4LCdwH1KOt8U61clGOca51ytgIZld bwFVgJO6baJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaqg5eAAKCRBgAj/E00kg cq2qD/0aMFIPasz9Dr94KFeN+OxZvH6cPkbIhJIaEwboFgwpvYifAXOdMXNhX1s0b5O+mU4PuAC lnHE89ggJu+ZRaIN2k8qfpie2vfRSND14nbhZh7l5CF9kDvoVDpauI3z70Qy2Nt/7x27gFXL99L Td9b7Mj6mehn0nODie3NarMSA4TgsoPYE71WlSgKTMSScu8uHSa1nAFECYmn+yENhruMdFu/uNy J702QAjh/qVCzq2lstGHcuNdjCoWNSsvxiyAjMddfd9nhET3zF2+feFHDuMZCTSEIxn0/l2sKBP Va6yml3X4HMw1NGv79ALiDs3Sb+kH38WSd8exp5kbWUgImmMz3h3fwrSgD4/fg9hqX9MtNYrrK3 nnVoeFSK8C11dsx3390zveC5DWbETJBr7N8P6BoC126OYiOzQ27ssjeSpTonBIldGk5/gpXBTi5 5uw23oHm7a0MOqlmqDipazRf4RCElQPjsjlE/wVi6MttfVcb4BTELPLtI8Lz1fds0/TyZJECGhU Zti23oUC1n8snGjP/2/kp+eqwlAm/VQAsIKgw5oN3mxT1t4+RYNgeypDN0wb2D/YOlRTA8maspw Qzt7O/FvAOgm4WG5hF6CfRdzUEj9dzKvnhuOdNxWpx4YHg3IbhxD9jjOi1/yPdN5g6TwvV1XSAh wo1dKof/VZRK06A== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg wled_probe() doesn't set the driver data for the platform device. As a result, dev_get_drvdata() in wled_remove() will return NULL, leading to a NULL pointer dereference afterward. Set the platform device driver data in wled_probe(). Cc: stable@vger.kernel.org Fixes: feeab87b3072 ("backlight: qcom-wled: Add support for short circuit handling") Signed-off-by: David Heidelberg --- drivers/video/backlight/qcom-wled.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index 650dd95f06ef5..a76158a298335 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -1747,16 +1747,17 @@ static int wled_probe(struct platform_device *pdev) memset(&props, 0, sizeof(struct backlight_properties)); props.type = BACKLIGHT_RAW; props.brightness = val; props.max_brightness = wled->max_brightness; bl = devm_backlight_device_register(&pdev->dev, wled->name, &pdev->dev, wled, &wled_ops, &props); + platform_set_drvdata(pdev, bl); return PTR_ERR_OR_ZERO(bl); }; static void wled_remove(struct platform_device *pdev) { struct wled *wled = platform_get_drvdata(pdev); mutex_destroy(&wled->lock); -- 2.55.0