From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D75735AC03; Mon, 14 Sep 2026 18:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789409658; cv=none; b=kAdapcEwlQZhpQ2EMEguivZZfTWvu+xRIYUNrRYXocbJqlnkmb6M3M9PF/ZS0c0vPUOrmBCpDrSnV97UQMd8yMxQs4M89s8kWY0Y9u/sHgRw3cwy2xZkw01aoGvhlh244jzmS+wRq8Sko+6JERJ02KNBMFFe6Ra4riuxup1urF0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789409658; c=relaxed/simple; bh=WkUHM9dV7a2xSjD7kRnCTymeU+hrBQnaiHSi4mSqU5Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=PLZmhQHCk0KjUl60kvo+qJOH3jiC7heUaPly5IYq1R9rKaypQanX23U/FDYVaTMZ35mglxCu4X2U5CzCVHJVQX9FrDzSxc0xHCy3rDxoN/8cGI8buDnaSsoTmSy/oarTxiS787R/BLygWtHJBo4vT9Pn4D9gitNTz10Wydlvw0A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=u0Y+yrSZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="u0Y+yrSZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id D9E9BC2BCFB; Mon, 14 Sep 2026 18:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1789409657; bh=WkUHM9dV7a2xSjD7kRnCTymeU+hrBQnaiHSi4mSqU5Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=u0Y+yrSZRSblbLzrGRY8dRknzD0JQ7BglSRlMLwb++05uGU+SmruTziSoro75Lrqr Wf1j2J05Yyf4l1cXB9w68rfkjzAlu/OUKQxNl922mOqTSjRlJUO9gE0VBX5WOm373m Zz3pnMGMMUoHl9Iep+dO7lrgOtDz1NY3RaHAl96qXEd1l2Ze8BBGIJekQXHaxl73lk Y/vAUxBiyFtMzGLK+mQoB5+XMvwz4+RO8DID3RTUbhIEDyPKrQJgK/xNBlG9RRhvxs WcGYEYNv6urDjIAK2PzQKhBpTcoZp9mXIiGPCXb+aJybImIdaWR8ePFGKnBIctPqT3 Lcs7qzogG0jHQ== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAFB0C88E72; Mon, 14 Sep 2026 18:14:17 +0000 (UTC) From: David Heidelberg via B4 Relay Date: Mon, 14 Sep 2026 20:14:15 +0200 Subject: [PATCH v3 2/4] backlight: qcom-wled: Fix WLED3 brightness register stride Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20260914-qcom-wled-backlight-v3-2-d69fe9843841@ixit.cz> References: <20260914-qcom-wled-backlight-v3-0-d69fe9843841@ixit.cz> In-Reply-To: <20260914-qcom-wled-backlight-v3-0-d69fe9843841@ixit.cz> To: Lee Jones , Daniel Thompson , Jingoo Han , Helge Deller , Kiran Gunda , Marco Mattiolo , =?utf-8?q?Barnab=C3=A1s_Cz=C3=A9m=C3=A1n?= Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, Konrad Dybcio , Joel Selvaraj , David Heidelberg , stable@vger.kernel.org X-Mailer: b4 0.16.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1777; i=david@ixit.cz; h=from:subject:message-id; bh=l2V9M/mtqxNb2sIjHPyjkihrWhmivYuqBuqKZxlIoYM=; b=owEBbQKS/ZANAwAIAWACP8TTSSByAcsmYgBqqDl4e+EJzY/iCyxKxGF4mhW9oay6H5NgaCsGd Ohbw0JWgXWJAjMEAAEIAB0WIQTXegnP7twrvVOnBHRgAj/E00kgcgUCaqg5eAAKCRBgAj/E00kg cmttD/4g8nziAhjgPhmtm3FoI3IvdN4iwbPG/MHGtdHuGY5A/UGENs944vkL0FDaObco14X87RS PWvcnas3xWcFqqi8SRIq9W3VjCmY1lYTKC/iMA7voLvBveHndyxNbuAwsEeg/52HbWMhJqzcHSu jI+F0WILo1resu1sMN6JWtDEdPGTbVFApxVG5lvDSvpivqMu4qFiC/VCqm7k+jJNd0HJIyixPyB 9s5tOcOHL7+tlsY7Mi3Y+1fodLRVB537xn7+wOiKErHPPjL5g4/sMH9+go7L7F+yt37vrelpF4W JsoawBydmLnDQf387r/558axlGsDKfX3K/eZ5m7ZlqimE5VOqMhAJcoBNWy9w/qhAWvkxDL3y26 uVatY0mKQEXnhWoAbpGL4TzEV48jGejbg/ynxt/VVCCKKPguiUyxVjDiK1Fgn/joxyyKi204XqR s1MXMSYiG/VuB4HpBmKEYiox8Wuk7Y6sFvvi/3cAqCyxAL5SOnhV+PY2g0iMLvjgd8UsvJS8fCJ cP6Nl0yvvTBfltTML1LGX/YHPu58+kdXUbD+49NgFG7KcFtU0MsD0UzkkKyBqRQqgkmmb7laDqh IXKneKRRpqvmLmSWum0wYBlOogDmy36YxZQdAIcepMkFPJ4rwRDb/HGk8NHSesqLk8pHIbmspMC X+UMNFwk1DlrFVQ== X-Developer-Key: i=david@ixit.cz; a=openpgp; fpr=D77A09CFEEDC2BBD53A7047460023FC4D3492072 X-Endpoint-Received: by B4 Relay for david@ixit.cz/default with auth_id=355 X-Original-From: David Heidelberg Reply-To: david@ixit.cz From: David Heidelberg WLED3 has a 16-bit brightness register pair per string, at 0x40 + 2*n, which is what the pm8941-wled driver wrote to: rc = regmap_bulk_write(wled->regmap, wled->addr + WLED3_CTRL_REG_VAL_BASE + 2 * i, v, 2); The restructuring for WLED3 turned that into WLED3_SINK_REG_BRIGHT(n), defined as 0x40 + n, so the two byte writes for consecutive strings overlap: string 1 overwrites the MSB of string 0 with its own LSB, and with the default three strings only string 1 ends up with the requested value. Use the 2 byte stride. Fixes: 775d2ffb4af6 ("backlight: qcom-wled: Restructure the driver for WLED3") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: David Heidelberg --- drivers/video/backlight/qcom-wled.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c index a76158a298335..e1962c2d90ed4 100644 --- a/drivers/video/backlight/qcom-wled.c +++ b/drivers/video/backlight/qcom-wled.c @@ -54,17 +54,17 @@ #define WLED3_SINK_REG_SYNC 0x47 #define WLED3_SINK_REG_SYNC_CLEAR 0x00 #define WLED3_SINK_REG_CURR_SINK 0x4f #define WLED3_SINK_REG_CURR_SINK_MASK GENMASK(7, 5) #define WLED3_SINK_REG_CURR_SINK_SHFT 5 /* WLED3 specific per-'string' registers below */ -#define WLED3_SINK_REG_BRIGHT(n) (0x40 + n) +#define WLED3_SINK_REG_BRIGHT(n) (0x40 + (n * 0x10)) #define WLED3_SINK_REG_STR_MOD_EN(n) (0x60 + (n * 0x10)) #define WLED3_SINK_REG_STR_MOD_MASK BIT(7) #define WLED3_SINK_REG_STR_FULL_SCALE_CURR(n) (0x62 + (n * 0x10)) #define WLED3_SINK_REG_STR_FULL_SCALE_CURR_MASK GENMASK(4, 0) #define WLED3_SINK_REG_STR_MOD_SRC(n) (0x63 + (n * 0x10)) -- 2.55.0