Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Lee Jones <lee@kernel.org>
To: "Daniel Thompson" <danielt@kernel.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Helge Deller" <deller@gmx.de>,
	"Kiran Gunda" <quic_kgunda@quicinc.com>,
	"Marco Mattiolo" <marco.mattiolo@hotmail.it>,
	"Barnabás Czémán" <barnabas.czeman@mainlining.org>,
	"David Heidelberg" <david@ixit.cz>
Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	phone-devel@vger.kernel.org,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	Joel Selvaraj <foss@joelselvaraj.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH v4 0/4] backlight: qcom-wled: Fix OVP IRQ imbalance and start from the hardware state
Date: Wed, 14 Oct 2026 16:48:10 +0100	[thread overview]
Message-ID: <20261014154810.GB1182143@google.com> (raw)
In-Reply-To: <179198100282.808561.2750105116872314866.b4-ty@b4>

On Wed, 14 Oct 2026, Lee Jones wrote:

> On Mon, 21 Sep 2026 12:46:21 +0200, David Heidelberg wrote:
> > The qcom-wled OVP interrupt is enabled at probe whenever the module is
> > already on, but the driver still believes the backlight is off, so the
> > first brightness update re-enables the interrupt and trips "Unbalanced
> > enable for IRQ". sdm845-mainline has carried a workaround for years and
> > Joel posted a flag-based version last October [1], which Konrad and
> > Daniel asked to be replaced by something that does not track the IRQ
> > state by hand.
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/4] backlight: qcom-wled: Fix NULL pointer dereference in wled_remove()
>       commit: 186fc521f211a207c323b753659f28d3dda7bc45
> [2/4] backlight: qcom-wled: Fix WLED3 brightness register stride
>       commit: e60dc9c05e0f415ef8bc63b3179abdd49830a619
> [3/4] backlight: qcom-wled: Fix unbalanced OVP IRQ enable at probe
>       commit: b32a8c32fea3855e707717155f198f03fdbf6f1e
> [4/4] backlight: qcom-wled: Read back the programmed brightness at probe
>       commit: 2ffcac916578f4a57347e717786d1e07e85cbf2b

No idea what this is.  The other one is the correct one.

-- 
Lee Jones

  reply	other threads:[~2026-10-14 15:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 10:46 [PATCH v4 0/4] backlight: qcom-wled: Fix OVP IRQ imbalance and start from the hardware state David Heidelberg via B4 Relay
2026-09-21 10:46 ` [PATCH v4 1/4] backlight: qcom-wled: Fix NULL pointer dereference in wled_remove() David Heidelberg via B4 Relay
2026-09-21 11:06   ` Konrad Dybcio
2026-10-06  9:59   ` Daniel Thompson
2026-09-21 10:46 ` [PATCH v4 2/4] backlight: qcom-wled: Fix WLED3 brightness register stride David Heidelberg via B4 Relay
2026-09-21 11:08   ` Konrad Dybcio
2026-09-21 11:11     ` David Heidelberg
2026-10-06 10:03   ` Daniel Thompson
2026-09-21 10:46 ` [PATCH v4 3/4] backlight: qcom-wled: Fix unbalanced OVP IRQ enable at probe David Heidelberg via B4 Relay
2026-10-06 10:07   ` Daniel Thompson
2026-09-21 10:46 ` [PATCH v4 4/4] backlight: qcom-wled: Read back the programmed brightness " David Heidelberg via B4 Relay
2026-10-06 10:11   ` Daniel Thompson
2026-10-14 12:30 ` [PATCH v4 0/4] backlight: qcom-wled: Fix OVP IRQ imbalance and start from the hardware state Lee Jones
2026-10-14 15:48   ` Lee Jones [this message]
2026-10-14 12:30 ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261014154810.GB1182143@google.com \
    --to=lee@kernel.org \
    --cc=barnabas.czeman@mainlining.org \
    --cc=danielt@kernel.org \
    --cc=david@ixit.cz \
    --cc=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=foss@joelselvaraj.com \
    --cc=jingoohan1@gmail.com \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marco.mattiolo@hotmail.it \
    --cc=phone-devel@vger.kernel.org \
    --cc=quic_kgunda@quicinc.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox