From: himanshu bakshi <himanshu.bakshi478@gmail.com>
To: andy@kernel.org
Cc: gregkh@linuxfoundation.org, dri-devel@lists.freedesktop.org,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Himanshu Bakshi <himanshu.bakshi478@gmail.com>
Subject: [PATCH v2] staging: fbtft: Fix line length warning
Date: Sun, 25 Oct 2026 22:10:03 +0530 [thread overview]
Message-ID: <20261025164003.143864-1-himanshu.bakshi478@gmail.com> (raw)
From: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
Hi Andy,
I have made sure that the \ (backslash) is properly aligned to the same
column as the rest of the macro. I have also taken into account your
advice and hence added a local variable for platform data.
After some thorough searching through the respective directory, I have
not found any calls for fbtft_init_dbg. This might be because it's a
helper macro that might be useful as the driver progresses.
I have also noticed that some other macros around this one have simple
style issues and if you would like, I can send another different patch
cleaning up those too.
I have also done minimal testing by using the macro once to make sure it
compiles and has no errors, if you would like, I can also run any
standalone tests for this macro.
Thanks and Regards,
Himanshu Bakshi
Signed-off-by: Himanshu Bakshi <himanshu.bakshi478@gmail.com>
---
drivers/staging/fbtft/fbtft.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft.h b/drivers/staging/fbtft/fbtft.h
index fd7f8fc2afba..ceaa9a3906ef 100644
--- a/drivers/staging/fbtft/fbtft.h
+++ b/drivers/staging/fbtft/fbtft.h
@@ -421,12 +421,11 @@ module_spi_driver(fbtft_driver_spi_driver);
#define DEBUG_REQUEST_GPIOS_MATCH BIT(30)
#define DEBUG_VERIFY_GPIOS BIT(31)
-#define fbtft_init_dbg(dev, format, arg...) \
-do { \
- if (unlikely((dev)->platform_data && \
- (((struct fbtft_platform_data *)(dev)->platform_data)-> \
- display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
- dev_info(dev, format, ##arg); \
+#define fbtft_init_dbg(dev, format, arg...) \
+do { \
+ struct fbtft_platform_data *pdata = dev_get_platdata((dev)); \
+ if (unlikely(pdata && (pdata->display.debug & DEBUG_DRIVER_INIT_FUNCTIONS))) \
+ dev_info(dev, format, ##arg); \
} while (0)
#define fbtft_par_dbg(level, par, format, arg...) \
--
2.56.0
next reply other threads:[~2026-10-25 16:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 16:40 himanshu bakshi [this message]
2026-10-25 21:02 ` [PATCH v2] staging: fbtft: Fix line length warning Andy Shevchenko
2026-10-26 5:48 ` Dan Carpenter
2026-10-26 5:53 ` Himanshu Bakshi
2026-10-26 6:02 ` Dan Carpenter
2026-10-26 6:16 ` Himanshu Bakshi
2026-10-26 6:31 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2026-10-26 4:45 himanshu bakshi
2026-10-26 9:20 ` Andy Shevchenko
2026-10-26 9:28 ` Himanshu Bakshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261025164003.143864-1-himanshu.bakshi478@gmail.com \
--to=himanshu.bakshi478@gmail.com \
--cc=andy@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox