Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Jiaqi Shi <shijiaqi_develop@163.com>
To: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	gregkh@linuxfoundation.org
Cc: linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Jiaqi Shi <shijiaqi_develop@163.com>
Subject: [PATCH 2/3] staging: sm750fb: remove more unused struct fields
Date: Thu, 19 Nov 2026 22:06:19 +0800	[thread overview]
Message-ID: <20261119140620.169368-3-shijiaqi_develop@163.com> (raw)
In-Reply-To: <20261119140620.169368-1-shijiaqi_develop@163.com>

The hw_cursor, o_cursor, dpms, horizontal_frequency and
vertical_frequency fields are never read. Remove them and the only
assignment to hw_cursor.

Signed-off-by: Jiaqi Shi <shijiaqi_develop@163.com>
---
 drivers/staging/sm750fb/ddk750_mode.h |  2 --
 drivers/staging/sm750fb/sm750.c       |  2 --
 drivers/staging/sm750fb/sm750.h       | 10 ----------
 3 files changed, 14 deletions(-)

diff --git a/drivers/staging/sm750fb/ddk750_mode.h b/drivers/staging/sm750fb/ddk750_mode.h
index 1b70885f85e5..f52f893c6a6d 100644
--- a/drivers/staging/sm750fb/ddk750_mode.h
+++ b/drivers/staging/sm750fb/ddk750_mode.h
@@ -26,8 +26,6 @@ struct mode_parameter {
 
 	/* Refresh timing. */
 	unsigned long pixel_clock;
-	unsigned long horizontal_frequency;
-	unsigned long vertical_frequency;
 
 	/* Clock Phase. This clock phase only applies to Panel. */
 	enum spolarity clock_phase_polarity;
diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
index 21e310274330..99d410e184bd 100644
--- a/drivers/staging/sm750fb/sm750.c
+++ b/drivers/staging/sm750fb/sm750.c
@@ -584,8 +584,6 @@ static int sm750fb_set_drv(struct lynxfb_par *par)
 		crtc->vidmem_size >>= 1;
 
 	/* setup crtc and output member */
-	sm750_dev->hw_cursor = g_hwcursor;
-
 	crtc->line_pad = 16;
 	crtc->xpanstep = 8;
 	crtc->ypanstep = 1;
diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
index 7511fab2e0e3..ea8f445b5fd4 100644
--- a/drivers/staging/sm750fb/sm750.h
+++ b/drivers/staging/sm750fb/sm750.h
@@ -95,14 +95,6 @@ struct sm750_dev {
 	enum sm750_pnltype pnltype;
 	enum sm750_dataflow dataflow;
 	int nocrt;
-
-	/*
-	 * 0: no hardware cursor
-	 * 1: primary crtc hw cursor enabled,
-	 * 2: secondary crtc hw cursor enabled
-	 * 3: both ctrc hw cursor enabled
-	 */
-	int hw_cursor;
 };
 
 struct lynx_cursor {
@@ -123,7 +115,6 @@ struct lynx_cursor {
 struct lynxfb_crtc {
 	unsigned char __iomem *v_cursor; /* virtual address of cursor */
 	unsigned char __iomem *v_screen; /* virtual address of on_screen */
-	int o_cursor; /* cursor address offset in vidmem */
 	int o_screen; /* onscreen address offset in vidmem */
 	int channel;/* which channel this crtc stands for*/
 	resource_size_t vidmem_size;/* this view's video memory max size */
@@ -139,7 +130,6 @@ struct lynxfb_crtc {
 };
 
 struct lynxfb_output {
-	int dpms;
 	int paths;
 	/*
 	 * which paths(s) this output stands for,for sm750:
-- 
2.53.0


  parent reply	other threads:[~2026-11-19 14:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19 14:06 [PATCH 0/3] staging: sm750fb: remove dead code and redundant definitions Jiaqi Shi
2026-11-19 14:06 ` [PATCH 1/3] staging: sm750fb: remove unused MHZ macro Jiaqi Shi
2026-11-19 14:06 ` Jiaqi Shi [this message]
2026-11-19 14:06 ` [PATCH 3/3] staging: sm750fb: remove duplicate SM750LE_REVISION_ID definition Jiaqi Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119140620.169368-3-shijiaqi_develop@163.com \
    --to=shijiaqi_develop@163.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox