Linux Framebuffer Layer development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Ali Köse" <shroot1337@gmail.com>
Cc: sudipm.mukherjee@gmail.com, teddy.wang@siliconmotion.com,
	rppt@kernel.org, linux-fbdev@vger.kernel.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] staging: sm750fb: Clean up helpers and fix DAC power-off handling
Date: Fri, 20 Nov 2026 08:13:27 +0100	[thread overview]
Message-ID: <2026112013-profound-stoppage-4efe@gregkh> (raw)
In-Reply-To: <20261114100207.9124-1-shroot1337@gmail.com>

On Sat, Nov 14, 2026 at 01:02:04PM +0300, Ali Köse wrote:
> This series replaces the set_DAC macro with a local static function,
> corrects the DAC power-off bit handling, and removes an empty software
> I2C acknowledgement helper and its ineffective parameter.
> 
> The first and third patches preserve existing behavior. The second
> patch maps the extracted 0/1 DAC state to bit 20 rather than OR-ing it
> into bit 0 of MISC_CTRL.
> 
> Based on staging-next at 6628e7d4c6b (Linux 7.4-rc1).
> 
> Validation:
> - All SM750 driver objects compiled and linked into sm750fb.o with W=1,
>   CONFIG_FB=y, CONFIG_STAGING=y, and CONFIG_FB_SM750=m.
> - A standalone mocked-register test checked 72 DAC state and register
>   preservation cases: 36 failed before the fix and none failed afterward.
> - checkpatch.pl reported no errors or warnings.
> - git diff --check passed.
> 
> Hardware testing was not performed.

Please read:
	https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh


      parent reply	other threads:[~2026-11-20  7:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 10:02 [PATCH 0/3] staging: sm750fb: Clean up helpers and fix DAC power-off handling Ali Köse
2026-11-14 10:02 ` [PATCH 1/3] staging: sm750fb: Replace set_DAC macro with a static function Ali Köse
2026-11-14 10:02 ` [PATCH 2/3] staging: sm750fb: Fix DAC power-off bit handling Ali Köse
2026-11-14 10:02 ` [PATCH 3/3] staging: sm750fb: Remove empty software I2C acknowledgement helper Ali Köse
2026-11-20  7:13 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026112013-profound-stoppage-4efe@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=rppt@kernel.org \
    --cc=shroot1337@gmail.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=teddy.wang@siliconmotion.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox